From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 17 Oct 2019 21:05:40 +0200 Message-ID: <87zhhzfb0b.fsf@gmail.com> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <831rvcgbn2.fsf@gnu.org> <20191016131813.62i6xuwguc7nxyrn@Ergus> <83a7a0egtf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="153686"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37774@debbugs.gnu.org, Ergus To: Andrey Orst Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 17 21:22:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iLBLf-000dpU-Mf for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Oct 2019 21:22:11 +0200 Original-Received: from localhost ([::1]:57744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLBLe-0007X9-GT for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Oct 2019 15:22:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37062) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLB64-00010p-LQ for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 15:06:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLB63-0003uH-H7 for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 15:06:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40121) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLB63-0003u8-EE for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 15:06:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iLB62-0005J2-NN for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 15:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Oct 2019 19:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157133915620380 (code B ref 37774); Thu, 17 Oct 2019 19:06:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 17 Oct 2019 19:05:56 +0000 Original-Received: from localhost ([127.0.0.1]:48942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLB5v-0005Ie-M4 for submit@debbugs.gnu.org; Thu, 17 Oct 2019 15:05:55 -0400 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:36074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLB5s-0005IO-J6 for 37774@debbugs.gnu.org; Thu, 17 Oct 2019 15:05:53 -0400 Original-Received: by mail-wr1-f47.google.com with SMTP id w18so3018524wrt.3 for <37774@debbugs.gnu.org>; Thu, 17 Oct 2019 12:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=y8cwGuDHXqq9jQnsefAyg0mDyvmLxWC7PRqhx4NDhJM=; b=tDlJ9D2VcHq4H6mSuK4A6vIBCdOujs16HtQ/Dlh1Fvye0v+GT/X1XwfyTtA83rlrZS 8EJTrwh58uiNJAGVuIaWNNqhQf5wbj+z+YBwwMGQyJWbsYnqUuMB3BJJhpXCN69kTJ3k 4qjkkAhXdOdP+MctuChyMfcZwENiADxm+obyer1lqB0BerSX2cuZQDAHP2MiVNTruJLW L/gvxqK4NA7ZZGC/XrArhIMCfPDKQycfrYiW6POmTl/92iQ7wV9yxi/CMs5mqY2SPLLP 0b8x7Dj1/Otf4MlU+76bOF9h8sEECAEI3PaFv6cKj2/zXW8qsYdRSbXsrrlwIGZYC3RD T91g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=y8cwGuDHXqq9jQnsefAyg0mDyvmLxWC7PRqhx4NDhJM=; b=PUj4OOZvHRF17xXYGPTNvfr6j3JxrVIPOZati61xulJd4JeRf389IJEhs+u3DVnWgN xIFtdMyPwWzPWqy2VTPS7AyoLneI190gJX/pfDmm59v5XHuM1wm7J3hYU7tOWk7lkJL4 traM1TixTL3xcyFWfpyJUfQj2ndL1im3wT7Y8izH9g+tKYaGU6+Y4ULSjmJ4fMdcFp7G US0G0R7SirW82U+RqJpHIXhRFad8Ebp9vkGXL+kxv1wcRgKjwINjN7qvhlYtMZrYZ7KO nJ03yP+6W+T5/r/ADcBBJHI4KPJHTo5ZbCcmR3ZPSeh4L8gD1AjyPXGsxEQNbzDm9403 vVUg== X-Gm-Message-State: APjAAAVMLUcJabWOP+CVKaafRFukzGa180Av90vDUu5nIdWnaBrOqE7K ptWZMKFox0mGpTQeVTCKybYMiLtrHAo= X-Google-Smtp-Source: APXvYqxyUBaclvkV6ntRf8mL9Iu6lpT/1TQ63q9IGQwkQ7V/I5FMESbV9nG1xJ7c7NPG4Q7JTt8JkQ== X-Received: by 2002:adf:fa92:: with SMTP id h18mr4353744wrr.220.1571339145166; Thu, 17 Oct 2019 12:05:45 -0700 (PDT) Original-Received: from my-little-tumbleweed (71.142.13.109.rev.sfr.net. [109.13.142.71]) by smtp.gmail.com with ESMTPSA id n7sm3032170wrt.59.2019.10.17.12.05.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 12:05:43 -0700 (PDT) In-Reply-To: (Andrey Orst's message of "Wed, 16 Oct 2019 21:13:23 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169617 Archived-At: --=-=-= Content-Type: text/plain Andrey Orst writes: > (defface foo...) > (when (>= emacs-major-version 27) > (set-face-attribute foo... :extend t)) Unless I'm mistaken, this has the disadvantage of making Custom confused as to who changed the face, i.e. M-x customize-face RET foo... RET will say that the face was "CHANGED outside Customize". For all intents and purposes a package author may wish the face to be described as "STANDARD" as long as no theming or user customization has been applied. Maybe some backquote trickery may help? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=magit-extend-demo.patch --- magit-diff.el.bkp 2019-10-17 20:29:21.771892709 +0200 +++ magit-diff.el 2019-10-17 20:53:47.927829447 +0200 @@ -509,12 +509,14 @@ :group 'magit-faces) (defface magit-diff-hunk-heading - '((((class color) (background light)) + `((((class color) (background light)) :background "grey80" - :foreground "grey30") + :foreground "grey30" + ,@(unless (version<= emacs-version "27") '(:extend t))) (((class color) (background dark)) :background "grey25" - :foreground "grey70")) + :foreground "grey70" + ,@(unless (version<= emacs-version "27") '(:extend t)))) "Face for diff hunk headings." :group 'magit-faces) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable (I did not look for a way to factor out the (:extend t) into a leading (default =E2=80=A6) clause, but there ought to be a way to do it.) This method should be usable by theme authors too, crufty as it looks=E2=80= =A6 --=-=-=--