From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37943: assoc-default is wrongly flagged as side-effect-free. Date: Mon, 28 Oct 2019 16:24:32 +0100 Message-ID: <87zhhk99lb.fsf@gnus.org> References: <20191027122455.GB27491@ACM> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="191594"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37943@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 28 16:34:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iP722-000nh2-1X for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Oct 2019 16:34:10 +0100 Original-Received: from localhost ([::1]:50830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iP71z-0005dk-OR for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Oct 2019 11:34:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49265) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iP6tL-0003Fb-MR for bug-gnu-emacs@gnu.org; Mon, 28 Oct 2019 11:25:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iP6tF-0002be-MV for bug-gnu-emacs@gnu.org; Mon, 28 Oct 2019 11:25:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37379) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iP6tC-0002a1-6B for bug-gnu-emacs@gnu.org; Mon, 28 Oct 2019 11:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iP6tC-0008TK-14 for bug-gnu-emacs@gnu.org; Mon, 28 Oct 2019 11:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Oct 2019 15:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37943 X-GNU-PR-Package: emacs Original-Received: via spool by 37943-submit@debbugs.gnu.org id=B37943.157227627932528 (code B ref 37943); Mon, 28 Oct 2019 15:25:01 +0000 Original-Received: (at 37943) by debbugs.gnu.org; 28 Oct 2019 15:24:39 +0000 Original-Received: from localhost ([127.0.0.1]:46200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iP6so-0008Sa-QB for submit@debbugs.gnu.org; Mon, 28 Oct 2019 11:24:38 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:42006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iP6sl-0008SQ-W9 for 37943@debbugs.gnu.org; Mon, 28 Oct 2019 11:24:36 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iP6si-0000VB-LV; Mon, 28 Oct 2019 16:24:35 +0100 In-Reply-To: <20191027122455.GB27491@ACM> (Alan Mackenzie's message of "Sun, 27 Oct 2019 12:24:55 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170308 Archived-At: Alan Mackenzie writes: > In the source for assoc-default (in subr.el) appears > > (declare (side-effect-free t)) > > . This is not true when the TEST argument to assoc-default itself > changes the match-data. > > I suggest removing this declaration from the function rather than > amending the code with a save-match-data. There are calls to > assoc-default in set-auto-mode where the caller relies on the match data > set by the function when TEST is string-match. :-( Yeah, I don't think any function that takes a closure as an argument should be marked side-effect free? The TEST function can side-effect as much as it wants. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no