From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.bugs Subject: bug#38583: [PATCH] 27.0.50; Add unattended spell-checking to checkdoc Date: Fri, 17 Jan 2020 10:06:09 +0100 Message-ID: <87zhem8nb2.fsf@cassou.me> References: <87immlw7zo.fsf@cassou.me> <83blsc8ujl.fsf@gnu.org> <871rt8gfy0.fsf@cassou.me> <83mubw6lpb.fsf@gnu.org> <87o8vu7zqp.fsf@cassou.me> <83d0c9q2t3.fsf@gnu.org> <87blrt7rso.fsf@cassou.me> <874kx28b7m.fsf@cassou.me> <83sgkm6uxj.fsf@gnu.org> <87o8v8q6f7.fsf@cassou.me> <83k15r2qdw.fsf@gnu.org> <87muanqfe2.fsf@cassou.me> <83blr2344q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="46346"; mail-complaints-to="usenet@ciao.gmane.io" Cc: alex.branham@gmail.com, eggert@cs.ucla.edu, k.stevens@ieee.org, 38583-done@debbugs.gnu.org, larsi@gnus.org, zappo@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 17 10:07:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1isNb2-000BuS-1r for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jan 2020 10:07:16 +0100 Original-Received: from localhost ([::1]:54230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isNb0-0001JI-UP for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jan 2020 04:07:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45928) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isNar-0001Iv-8y for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 04:07:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isNan-0007DS-Tl for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 04:07:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32875) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1isNan-0007DH-QU for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 04:07:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1isNan-0002Cm-Li for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 04:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jan 2020 09:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38583 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38583-done@debbugs.gnu.org id=D38583.15792519838433 (code D ref 38583); Fri, 17 Jan 2020 09:07:01 +0000 Original-Received: (at 38583-done) by debbugs.gnu.org; 17 Jan 2020 09:06:23 +0000 Original-Received: from localhost ([127.0.0.1]:38848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isNa7-0002Bo-69 for submit@debbugs.gnu.org; Fri, 17 Jan 2020 04:06:23 -0500 Original-Received: from mail.choca.pics ([80.67.172.235]:43756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isNa1-0002Bc-TC for 38583-done@debbugs.gnu.org; Fri, 17 Jan 2020 04:06:17 -0500 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 4CCBD18192B27; Fri, 17 Jan 2020 10:06:12 +0100 (CET) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id KWpXaMy65W28; Fri, 17 Jan 2020 10:06:11 +0100 (CET) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 24A6A181929D0; Fri, 17 Jan 2020 10:06:11 +0100 (CET) X-Virus-Scanned: amavisd-new at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id wFHYGWMrjqXt; Fri, 17 Jan 2020 10:06:10 +0100 (CET) Original-Received: from luz4 (unknown [86.215.185.132]) by mail.choca.pics (Postfix) with ESMTPSA id B888618192B27; Fri, 17 Jan 2020 10:06:10 +0100 (CET) In-Reply-To: <83blr2344q.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174751 Archived-At: Eli Zaretskii writes: > In general, yes. But you can try convincing me that it is so > important to have in Emacs 27 that we should make an exception. I > considered this, and concluded that it's a minor convenience feature. > But maybe I'm missing something? Integrating into Emacs 27 late in the process is risky because my code could have introduced subtle bugs inside checkdoc and I would not like to be responsible for a delay in the release. That being said and checkdoc being automatically activated by flycheck (which I believe many people use), I think we will find bugs in my code quite fast if there are any. Moreover, I think that improving the overall quality of Emacs code is important and every little step in this direction would be helpful. I'm not sure this is convincing enough but I would have tried :-D. FYI, this work on checkdoc is part of a larger piece of work I've started some years ago on improving the quality of Emacs packages. Here are some of my activities in this area: - opening issues and sending patches on Emacs core regarding checkdoc (e.g., this one, bug#37063, bug#37034); - giving very detailed reviews of packages sent to melpa (e.g., https://github.com/melpa/melpa/pull/5451); - rewriting melpa's CONTRIBUTING.org from scratch (https://github.com/melpa/melpa/blob/master/CONTRIBUTING.org); - collaborating with emake's developer (https://github.com/vermiculus/emake.el/pull/8); - writing makel (https://gitea.petton.fr/DamienCassou/makel); - doing a conference on the subject at EmacsConf 2019 (https://media.emacsconf.org/2019/16.html); - prototyping a linting engine for everyone to easily write lint rules (https://gitlab.com/lintel/lintel). -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill