From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#25496: 25.1.91; INSIDE_EMACS env variable is not set in eshell Date: Sat, 28 Mar 2020 20:21:20 -0400 Message-ID: <87zhc0huyn.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="90832"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.90 (gnu/linux) Cc: 25496@debbugs.gnu.org To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 30 04:38:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jIkJc-000NWK-Am for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Mar 2020 04:38:16 +0200 Original-Received: from localhost ([::1]:43790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIkJb-00078p-97 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Mar 2020 22:38:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54904) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIkHq-0003bH-8p for bug-gnu-emacs@gnu.org; Sun, 29 Mar 2020 22:36:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIkHp-0003Zd-2v for bug-gnu-emacs@gnu.org; Sun, 29 Mar 2020 22:36:26 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48639) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jIkHo-0003ZQ-UX for bug-gnu-emacs@gnu.org; Sun, 29 Mar 2020 22:36:25 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jIkHo-0004he-SY for bug-gnu-emacs@gnu.org; Sun, 29 Mar 2020 22:36:24 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Mar 2020 02:36:24 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25496-submit@debbugs.gnu.org id=B25496.158553573417392 (code B ref 25496); Mon, 30 Mar 2020 02:36:24 +0000 Original-Received: (at 25496) by debbugs.gnu.org; 30 Mar 2020 02:35:34 +0000 Original-Received: from mail-qt1-f179.google.com ([209.85.160.179]:41135) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jILhg-0004SU-7F for 25496@debbugs.gnu.org; Sat, 28 Mar 2020 20:21:28 -0400 Original-Received: by mail-qt1-f179.google.com with SMTP id i3so12057214qtv.8 for <25496@debbugs.gnu.org>; Sat, 28 Mar 2020 17:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=KimYZIDfF3Ij4BZvksRExEQT/d9F35aJ26qzz9otFHE=; b=gUfC1hRI74M+RQLRfp3Ui39pkxb9ZjGtlg00nmOC+haU9vRv2EeLaBTvCcVC6/5LCC vGE7Dk8NeSpf7Oqc6PjX32itiwYz2fLl/nUdA0DDvgM6AwjVNLOpTicMz7LbrJDpYuQG MIfyYt9k7dXYcLsdL2FRsxsA6S1ljjlXYW7gg1yobR/uyRbIK6S7u3f46LYGGH8GJzFo jbmC5b5qkXk8m5fp4vYJiMaXpKGsHptR7A/zNG20qEmzKlRhVttC5KcPPnA6y0mPQq5R oLSCdgBvU+1X+32j+yqneLuPp62NT01g8StEt1qTKWc4lHL3poiBYFTdj1xL10FyrO4T bacQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=KimYZIDfF3Ij4BZvksRExEQT/d9F35aJ26qzz9otFHE=; b=cboMxJBQ4Chx/sC9gQYwz4cgNMZbBEGGkhz9th2zMiCLaCtmbsVYI/znYWBigZLAmV r+dVgjwZPeujBwHn1TL2LpJX/KOf35V8j3cK85uPqMLO6AMLeQ/tOfDwVDf+nwNXC6n5 PNwei349oi8RNiP30O7qvBvqhG3ltq+YOBi8IVbxzfiNHcQ9EhbX3b2v0e18xlTEY+zC 5RPWRAYTqCUklWkKa+zkD0FpSw2fiMMF4j/kLz60bGFfxVpo7ztSy7q8hSt1FOE3s69o q60BlkO9OBinTo+nIxCrCvpSTkKg4HTyM19eBuVrJoFoxcPVpeJcCivjPwtov0+7nXq7 ZTgg== X-Gm-Message-State: ANhLgQ3z2OxV/lvR+50SmPyedoWKbO9EcrR8TSwfP+9JP3C4xFMXCPVj 3JOeSqIMLOd58oCasH+wE1G1c7fp X-Google-Smtp-Source: ADFU+vvS8fQVJFk9d1zK7GcVnJNqOzNvhNI0MZU/gV+Mmv5VlNRKSeWmWQjExu44IuAgrfKLkZ0sow== X-Received: by 2002:aed:3ed0:: with SMTP id o16mr5881041qtf.3.1585441281840; Sat, 28 Mar 2020 17:21:21 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id m67sm6848470qke.101.2020.03.28.17.21.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 28 Mar 2020 17:21:21 -0700 (PDT) In-Reply-To: (Federico Tedin's message of "Sun, 08 Mar 2020 17:50:51 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-List-Received-Date: Sun, 29 Mar 2020 00:21:28 -0000 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177847 Archived-At: Federico Tedin writes: > Pinging this thread again in case a maintainer can take a look at the > patch I submitted on my last message. Thanks for the ping, I had forgotten about this one. > * lisp/eshell/em-dirs.el (eshell-dirs-initialize): Add INSIDE_EMACS > variable to buffer-local value of eshell-variable-aliases-alist. > * lisp/eshell/esh-var.el (eshell-variable-aliases-list): Update doc > string; remove mention of eshell-user-aliases-list and explain that I think eshell-user-aliases-list was meant to refer to eshell-command-aliases-list (though maybe the reference isn't really needed anyway). > + ("INSIDE_EMACS" ,(lambda (_indices) > + (format "%s,eshell" emacs-version)) Since emacs-version generally doesn't change during an Emacs session, is there any need for a lambda at all here? > "This list provides aliasing for variable references. > -It is very similar in concept to what `eshell-user-aliases-list' does > -for commands. Each member of this defines the name of a command, > -and the Lisp value to return for that variable if it is accessed > -via the syntax `$NAME'. > +Each member of this defines the name of a command, and the Lisp value ^^^^^^^ ^^^^^^^ > +to return for that variable if it is accessed via the syntax `$NAME'. (These problems weren't introduced by your patch, but) I think the "of this" is redundant, and it should say "variable" instead of "command".