From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#40693: 28.0.50; json-encode-alist changes alist Date: Tue, 19 May 2020 00:50:33 +0100 Message-ID: <87zha43ira.fsf@gmail.com> References: <87a738jotd.fsf@tcd.ie> <87mu6utxd1.fsf@tcd.ie> <83r1w6ziql.fsf@gnu.org> <82572c3f-fb24-0b01-06ec-47067d9219ca@yandex.ru> <83blnazdly.fsf@gnu.org> <87wo5yqrqo.fsf@tcd.ie> <87ftbyavbq.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="119003"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Cc: darthandrus@gmail.com, 40693@debbugs.gnu.org, Dmitry Gutov To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 19 01:51:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1japXM-000UqW-Jg for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 May 2020 01:51:12 +0200 Original-Received: from localhost ([::1]:55120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1japXL-00048g-Cj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 May 2020 19:51:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1japXC-00048a-Bh for bug-gnu-emacs@gnu.org; Mon, 18 May 2020 19:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37041) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1japXC-0000Ui-26 for bug-gnu-emacs@gnu.org; Mon, 18 May 2020 19:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1japXC-0004qs-1N for bug-gnu-emacs@gnu.org; Mon, 18 May 2020 19:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 May 2020 23:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40693 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40693-submit@debbugs.gnu.org id=B40693.158984585018632 (code B ref 40693); Mon, 18 May 2020 23:51:01 +0000 Original-Received: (at 40693) by debbugs.gnu.org; 18 May 2020 23:50:50 +0000 Original-Received: from localhost ([127.0.0.1]:48587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1japWw-0004qM-92 for submit@debbugs.gnu.org; Mon, 18 May 2020 19:50:50 -0400 Original-Received: from mail-wm1-f68.google.com ([209.85.128.68]:33383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1japWr-0004q4-Su for 40693@debbugs.gnu.org; Mon, 18 May 2020 19:50:45 -0400 Original-Received: by mail-wm1-f68.google.com with SMTP id d207so1110731wmd.0 for <40693@debbugs.gnu.org>; Mon, 18 May 2020 16:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=edMwMbCu9ARudHfR7IDV06DtkHFt87eItTXNmvgo8Bc=; b=pgNPQ1bq9PWREF/LslYQLGONkJe3pGibhtIY7w/9i7WP2ar4UBnAabmHH6COAlPLe6 tEMimBeC38CZ0Hmw06jdxOailkFCqi9CT3T+VlokGVra3JpUKnCf8f4BWk9aLHzKeeI/ 9ao30+1i6VcFf5G8p3TBAWKjCewp7uSR8u1yV2mzmh3/kKAghkKzIl+wF32AygMOEajG gq6pUgPyzUjkn0x1aTWXZSf/41JM3zoq/+HRAnObFqHEADWBlj29qLg3yCys1cT/6qD9 Fuv9qrvWOz/cgZtQTYnw5KecBR/NpeqBwvZ8LX4yseiIUMUG1wcDfFhw1fcTjoXNMUUQ xkTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=edMwMbCu9ARudHfR7IDV06DtkHFt87eItTXNmvgo8Bc=; b=Dpzal9n5BwcQZs5rp/LVitkAaEcAyFeUBB82S3kPCoDIq5fkrFP6o/Edx0OfuCfrye yGOAicB0GmZukvOdaaJcieA39+VygcoRFi4n9UN2ofTS5k4rCOjoZoj/UyBUo5hEIVeL JoHoMmnxlBwf2ivqu9VGAI86NHSqc6FxhrbkalzUxewoNXk71Om8oP70/WRNejB6faFH vqtUcDv42KGooa9/zICeWKnuk4sIN4dYVFENrwxPjJgzYhPJeGfI4VWAQRjnFwqB4J2e 7j4wOoBwrkJ9B2Vps8QGS/dzjyo/mZH+EwC3HEEd8t/LtZjeYyEKg0qcNXoUyJlW3D4v bV7A== X-Gm-Message-State: AOAM5309LKdlHzgoUdLM7W+6iATc1lvqzV1o5oYwdBG4/voNXoqcmY1K yKBZ/t65qhIj61Bq73knBwhgW46pQyiU7g== X-Google-Smtp-Source: ABdhPJxz/SyG59AkVYWggEzQD/ww8qnqsZVzUZlWkH+e1J6gA9LmLZSam8nP2w1k46viUxd+7cByCw== X-Received: by 2002:a1c:1f16:: with SMTP id f22mr1922985wmf.46.1589845835489; Mon, 18 May 2020 16:50:35 -0700 (PDT) Original-Received: from krug ([2001:818:d820:9500:824a:171:15a:2213]) by smtp.gmail.com with ESMTPSA id d9sm1566496wmd.10.2020.05.18.16.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2020 16:50:34 -0700 (PDT) In-Reply-To: <87ftbyavbq.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 18 May 2020 02:24:57 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180564 Archived-At: Hi Basil, "Basil L. Contovounesios" writes: > * lisp/jsonrpc.el (jsonrpc--json-read, jsonrpc--json-encode): Check > whether native JSON functions are fboundp only once, at load time. I welcome this small improvement: in fact I had a TODO there to make something similar. In the TODO i suggested the jsonrpc--json-read could be a macro. You used `defalias` instead and that's fine. However, I don't understand the need for the ugly (require 'json), defvar and declare-function there. Can't we just use sth like `eval-and-compile` at the top of the file?=20=20 > -(defun jsonrpc--json-read () > - "Read JSON object in buffer, move point to end of buffer." > - ;; TODO: I guess we can make these macros if/when jsonrpc.el > - ;; goes into Emacs core. > - (cond ((fboundp 'json-parse-buffer) (json-parse-buffer > - :object-type 'plist > - :null-object nil > - :false-object :json-false)) > - (t (let ((json-object-type 'plist)) > - (json-read))))) > +(defalias 'jsonrpc--json-read > + (if (fboundp 'json-parse-buffer) > + (lambda () > + (json-parse-buffer :object-type 'plist > + :null-object nil > + :false-object :json-false)) > + (require 'json) > + (defvar json-object-type) > + (declare-function json-read "json" ()) > + (lambda () > + (let ((json-object-type 'plist)) > + (json-read)))) > + "Read JSON object in buffer, move point to end of buffer.") Thanks, Jo=C3=A3o