bug#42536: 28.0.50; Test vc-test-svn00-create-repo failing if snvadmin program not installed

bug#42536: 28.0.50; Test vc-test-svn00-create-repo failing if snvadmin program not installed

[Philipp]

This is another follow-up to Bug#30700.  In this case, it's probably
unrelated to macOS, and the SVN tests should simply check whether SVN is
actually installed.  However, since the tests are autogenerated by a
macro, this isn't entirely trivial:

Test vc-test-svn00-create-repo backtrace:
  call-process("svnadmin" nil t nil "create" "SVN")
  apply(call-process "svnadmin" nil t nil ("create" "SVN"))
  process-file("svnadmin" nil t nil "create" "SVN")
  apply(process-file "svnadmin" nil t nil ("create" "SVN"))
  vc-do-command("*vc*" 0 "svnadmin" ("create" "SVN"))
  vc-svn-create-repo()
  apply(vc-svn-create-repo nil)
  vc-call-backend(SVN create-repo)
  vc-create-repo(SVN)
  vc-test--create-repo-function(SVN)
  vc-test--create-repo(SVN)
  (lambda nil (vc-test--create-repo 'SVN))()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name vc-test-svn00-create-repo :documentat
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/vc/vc-tests" "--eval
  command-line()
  normal-top-level()
Test vc-test-svn00-create-repo condition:
    (file-missing "Searching for program" "No such file or directory" "svnadmin")
   FAILED   6/10  vc-test-svn00-create-repo (0.001947 sec)



In GNU Emacs 28.0.50 (build 67, x86_64-apple-darwin19.5.0, NS appkit-1894.50 Version 10.15.5 (Build 19F101))
 of 2020-07-25
Repository revision: 3b44829823f43d3736b8ec9db2258eeff7f6c16a
Repository branch: master
Windowing system distributor 'Apple', version 10.3.1894
System Description:  Mac OS X 10.15.5

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --with-modules --without-xml2 --without-pop --with-mailutils
 --enable-gcc-warnings=warn-only --enable-checking=all
 --enable-check-lisp-object-type 'CFLAGS=-ggdb3 -O0''

Configured features:
JPEG TIFF GIF PNG NOTIFY KQUEUE ACL GNUTLS ZLIB TOOLKIT_SCROLL_BARS NS
MODULES THREADS JSON PDUMPER LCMS2

Important settings:
  value of $LANG: de_DE.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc dired dired-loaddefs rfc822
mml easymenu mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs
text-property-search time-date mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived edmacro
kmacro pcase ffap thingatpt url url-proxy url-privacy url-expand
url-methods url-history url-cookie url-domsuf url-util url-parse
auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json map url-vars mailcap subr-x rx gnutls puny seq
byte-opt gv bytecomp byte-compile cconv dbus xml compile comint
ansi-color ring cl-loaddefs cl-lib tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win
ucs-normalize mule-util term/common-win tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
timer select scroll-bar mouse jit-lock font-lock syntax facemenu
font-core term/tty-colors frame minibuffer cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote threads kqueue cocoa ns
lcms2 multi-tty make-network-process emacs)

Memory information:
((conses 16 69742 5122)
 (symbols 48 8650 1)
 (strings 32 23543 1722)
 (string-bytes 1 768649)
 (vectors 16 14147)
 (vector-slots 8 172535 3974)
 (floats 8 26 29)
 (intervals 56 206 0)
 (buffers 992 10))

bug#42536: 28.0.50; Test vc-test-svn00-create-repo failing if snvadmin program not installed

[Lars Ingebrigtsen]

Philipp <p.stephani2@gmail.com> writes:

> This is another follow-up to Bug#30700.  In this case, it's probably
> unrelated to macOS, and the SVN tests should simply check whether SVN is
> actually installed.  However, since the tests are autogenerated by a
> macro, this isn't entirely trivial:
>
> Test vc-test-svn00-create-repo backtrace:
>   call-process("svnadmin" nil t nil "create" "SVN")

Hm...  I don't have svn on my Linux laptop either, and the svn tests are
just not done there.  So why are they performed on an svn-less Macos
laptop?

Aaah!

larsi@space test % svn
svn: error: The subversion command line tools are no longer provided by Xcode.

So

(defun vc-test--svn-enabled ()
  (executable-find vc-svn-program))

evaluates to true, even if there's no useable svn on the system.  Thank
you, Apple!

I've now amended the test to check for svnadmin, too.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#42536: 28.0.50; Test vc-test-svn00-create-repo failing if snvadmin program not installed

[Philipp Stephani]

Am Di., 4. Aug. 2020 um 14:49 Uhr schrieb Lars Ingebrigtsen <larsi@gnus.org>:
>
> Philipp <p.stephani2@gmail.com> writes:
>
> > This is another follow-up to Bug#30700.  In this case, it's probably
> > unrelated to macOS, and the SVN tests should simply check whether SVN is
> > actually installed.  However, since the tests are autogenerated by a
> > macro, this isn't entirely trivial:
> >
> > Test vc-test-svn00-create-repo backtrace:
> >   call-process("svnadmin" nil t nil "create" "SVN")
>
> Hm...  I don't have svn on my Linux laptop either, and the svn tests are
> just not done there.  So why are they performed on an svn-less Macos
> laptop?
>
> Aaah!
>
> larsi@space test % svn
> svn: error: The subversion command line tools are no longer provided by Xcode.
>
> So
>
> (defun vc-test--svn-enabled ()
>   (executable-find vc-svn-program))
>
> evaluates to true, even if there's no useable svn on the system.  Thank
> you, Apple!
>
> I've now amended the test to check for svnadmin, too.
>

Thanks, confirmed.