From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 29541@debbugs.gnu.org, 29541-done@debbugs.gnu.org
Subject: bug#29541: 27.0.50; Use generic function when restoring eieio-persistent, remove validation
Date: Fri, 28 Aug 2020 08:24:10 -0700 [thread overview]
Message-ID: <87zh6eiyjp.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87a6yevopv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 28 Aug 2020 16:18:04 +0200")
On 08/28/20 16:18 PM, Lars Ingebrigtsen wrote:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> This was quite a while ago, and the original patch no longer applies.
>> I've done up the same changes as two separate patches: one removing
>> extra validation, and the other creating a generic function for
>> constructing eieio-persistent objects. All the tests pass.
>
> I've just skimmed the code, but it looks good to me. I'd say just apply
> it and then see whether there is any fallout (but I don't expect there
> to be).
I've also used this with the gnus registry and EBDB, which should
exercise it fairly well. I'll push now.
prev parent reply other threads:[~2020-08-28 15:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-03 0:10 bug#29541: 27.0.50; Use generic function when restoring eieio-persistent, remove validation Eric Abrahamsen
2019-06-24 20:28 ` Lars Ingebrigtsen
2020-08-10 14:05 ` Lars Ingebrigtsen
2020-08-28 1:40 ` Eric Abrahamsen
2020-08-28 1:41 ` Eric Abrahamsen
2020-08-28 14:18 ` Lars Ingebrigtsen
2020-08-28 15:24 ` Eric Abrahamsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh6eiyjp.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=29541-done@debbugs.gnu.org \
--cc=29541@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).