From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Landell Newsgroups: gmane.emacs.bugs Subject: bug#43793: 27.1; Clicking on grep-mode find-abbreviate ellipsis yields user error Date: Sun, 04 Oct 2020 15:39:45 +0200 Message-ID: <87zh52xg7y.fsf@xwing.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35223"; mail-complaints-to="usenet@ciao.gmane.io" To: 43793@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 04 15:40:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kP4FG-00093b-0r for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Oct 2020 15:40:10 +0200 Original-Received: from localhost ([::1]:47792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kP4FE-0000LQ-U3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Oct 2020 09:40:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kP4F8-0000L1-Vp for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 09:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33570) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kP4F8-0001o9-LB for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 09:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kP4F8-0003pZ-I0 for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 09:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: David Landell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Oct 2020 13:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43793 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160181880014711 (code B ref -1); Sun, 04 Oct 2020 13:40:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Oct 2020 13:40:00 +0000 Original-Received: from localhost ([127.0.0.1]:45116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP4F5-0003pC-O1 for submit@debbugs.gnu.org; Sun, 04 Oct 2020 09:40:00 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:36526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP4F3-0003p0-It for submit@debbugs.gnu.org; Sun, 04 Oct 2020 09:39:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kP4F3-0000Jr-Bj for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 09:39:57 -0400 Original-Received: from aibo.runbox.com ([91.220.196.211]:43040) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kP4F0-0001mY-Sp for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 09:39:57 -0400 Original-Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1kP4Ew-0005B0-Jf for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 15:39:50 +0200 Original-Received: by submission02.runbox with esmtpsa [Authenticated alias (666394)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1kP4Er-0006tC-O9 for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 15:39:45 +0200 Received-SPF: none client-ip=91.220.196.211; envelope-from=david.landell@sunnyhill.email; helo=aibo.runbox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/04 09:39:51 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189751 Archived-At: --=-=-= Content-Type: text/plain Hi, Clicking on the find-abbreviate ellipsis in a grep-mode buffer while focus is on another emacs window invokes the grep-find-toggle-abbreviation on the buffer in the focused window instead of in the clicked window. The common manifestation of this problem would be a user error because the abbreviated-command property can not be found. More interesting results can be achieved if the focused window contains another grep-mode buffer in which case the ellipsis will be expanded in the focused window instead of the clicked. Attaching a patch the invokes mouse-select-window before toggling the abbreviation. Best regards, David Landell --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename=0001-Grep-Ensure-window-is-selected-when-clicking-on-find.patch Content-Transfer-Encoding: quoted-printable >From e5d35f544b91a66553e0d86c2f3d9e29978bc700 Mon Sep 17 00:00:00 2001 From: David Landell Date: Sun, 4 Oct 2020 15:04:19 +0200 Subject: [PATCH] Grep: Ensure window is selected when clicking on find-abbreviate ellipsis Without this fix, clicking on the abbreviate ellipsis when focus is on another window invokes grep-find-toggle-abbreviation in the focused window instead of the clicked one. * lisp/progmodes/grep.el (grep-find-abbreviate-properties): Invoke mouse-select-window before toggling abbrevation. --- lisp/progmodes/grep.el | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el index 279eb4d54b..c8c7dfa214 100644 --- a/lisp/progmodes/grep.el +++ b/lisp/progmodes/grep.el @@ -455,7 +455,11 @@ grep-find-abbreviate-properties (let ((ellipsis (if (char-displayable-p ?=E2=80=A6) "[=E2=80=A6]" "[...]= ")) (map (make-sparse-keymap))) (define-key map [down-mouse-2] 'mouse-set-point) - (define-key map [mouse-2] 'grep-find-toggle-abbreviation) + (define-key map [mouse-2] + (lambda (click) + (interactive "e") + (mouse-select-window click) + (grep-find-toggle-abbreviation))) (define-key map "\C-m" 'grep-find-toggle-abbreviation) `(face nil display ,ellipsis mouse-face highlight help-echo "RET, mouse-2: show unabbreviated command" --=20 2.17.1 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable In GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cair= o version 1.15.10) of 2020-09-19 built on lgw01-amd64-054 Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Linux Mint 19 Recent messages: assignment to free variable =E2=80=98grep-find-abbreviate-properties=E2=80= =99 user-error: No further redo information Undo branch point! [2 times] Saving file /home/david/code/emacs/.git/COMMIT_EDITMSG... Wrote /home/david/code/emacs/.git/COMMIT_EDITMSG yascroll: (wrong-number-of-arguments (left-width right-width outside-margin= s) 4) yascroll-bar-mode disabled Saving file /home/david/code/emacs/.git/COMMIT_EDITMSG... Wrote /home/david/code/emacs/.git/COMMIT_EDITMSG Git<4> finished Configured using: 'configure --build=3Dx86_64-linux-gnu --prefix=3D/usr '--includedir=3D${prefix}/include' '--mandir=3D${prefix}/share/man' '--infodir=3D${prefix}/share/info' --sysconfdir=3D/etc --localstatedir=3D/= var --disable-silent-rules '--libdir=3D${prefix}/lib/x86_64-linux-gnu' '--libexecdir=3D${prefix}/lib/x86_64-linux-gnu' --disable-maintainer-mode --disable-dependency-tracking --prefix=3D/usr --sharedstatedir=3D/var/lib --libexecdir=3D/usr/lib --localstatedir=3D/var/lib --infodir=3D/usr/share/info --mandir=3D/usr/share/man --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/27.1/site-lisp:= /usr/local/share/emacs/site-lisp:/usr/share/emacs/27.1/site-lisp:/usr/share= /emacs/site-lisp --program-suffix=3D27 --with-modules --with-file-notification=3Dinotify --with-mailutils --with-harfbuzz --with-json --with-x=3Dyes --with-x-toolkit=3Dgtk3 --with-lcms2 --with-cairo --with-xpm=3Dyes --with-gif=3Dyes --with-gnutls=3Dyes --with-jpeg=3Dyes --with-png=3Dyes --with-tiff=3Dyes --with-xwidgets 'CFLAGS=3D-g -O2 -fdebug-prefix-map=3D/build/emacs27-YwD3ZV/emacs27-27.1~1.git86d8d76aa3=3D= . -fstack-protector-strong -Wformat -Werror=3Dformat-security -no-pie' 'CPPFLAGS=3D-Wdate-time -D_FORTIFY_SOURCE=3D2' 'LDFLAGS=3D-Wl,-Bsymbolic-functions -Wl,-z,relro -no-pie'' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD JSON PDUMPER LCMS2 GMP Important settings: value of $EMACSLOADPATH: /home/david/programming/elisp/rg.el/:/home/david= /programming/elisp/rg.el/.cask/27.1/elpa/wgrep-20200217.1030:/home/david/pr= ogramming/elisp/rg.el/.cask/27.1/elpa/transient-20200819.1133:/home/david/p= rogramming/elisp/rg.el/.cask/27.1/elpa/ox-rst-20190920.949:/home/david/prog= ramming/elisp/rg.el/.cask/27.1/elpa/undercover-20191122.2126:/home/david/pr= ogramming/elisp/rg.el/.cask/27.1/elpa/dash-20200803.1520:/home/david/progra= mming/elisp/rg.el/.cask/27.1/elpa/shut-up-20180628.1830:/home/david/program= ming/elisp/rg.el/.cask/27.1/elpa/s-20180406.808:/home/david/programming/eli= sp/rg.el/.cask/27.1/elpa/package-lint-20200816.24:/home/david/programming/e= lisp/rg.el/.cask/27.1/elpa/flycheck-20200820.1403:/home/david/programming/e= lisp/rg.el/.cask/27.1/elpa/pkg-info-20150517.1143:/home/david/programming/e= lisp/rg.el/.cask/27.1/elpa/epl-20180205.2049:/home/david/programming/elisp/= rg.el/.cask/27.1/elpa/find-file-in-project-20200227.1204:/home/david/progra= mming/elisp/rg.el/.cask/27.1/elpa/ivy-20200826.955:/home/david/programming/= elisp/rg.el/.cask/27.1/elpa/ert-runner-20200704.1048:/home/david/programmin= g/elisp/rg.el/.cask/27.1/elpa/f-20191110.1357:/home/david/programming/elisp= /rg.el/.cask/27.1/elpa/commander-20140120.1852:/home/david/programming/elis= p/rg.el/.cask/27.1/elpa/ansi-20200611.944:/usr/share/emacs/27.1/lisp:/usr/s= hare/emacs/27.1/lisp/vc:/usr/share/emacs/27.1/lisp/url:/usr/share/emacs/27.= 1/lisp/textmodes:/usr/share/emacs/27.1/lisp/progmodes:/usr/share/emacs/27.1= /lisp/play:/usr/share/emacs/27.1/lisp/org:/usr/share/emacs/27.1/lisp/nxml:/= usr/share/emacs/27.1/lisp/net:/usr/share/emacs/27.1/lisp/mh-e:/usr/share/em= acs/27.1/lisp/mail:/usr/share/emacs/27.1/lisp/leim:/usr/share/emacs/27.1/li= sp/language:/usr/share/emacs/27.1/lisp/international:/usr/share/emacs/27.1/= lisp/image:/usr/share/emacs/27.1/lisp/gnus:/usr/share/emacs/27.1/lisp/eshel= l:/usr/share/emacs/27.1/lisp/erc:/usr/share/emacs/27.1/lisp/emulation:/usr/= share/emacs/27.1/lisp/emacs-lisp:/usr/share/emacs/27.1/lisp/cedet:/usr/shar= e/emacs/27.1/lisp/calendar:/usr/share/emacs/27.1/lisp/calc:/usr/share/emacs= /27.1/lisp/obsolete value of $LC_MONETARY: sv_SE.UTF-8 value of $LC_NUMERIC: sv_SE.UTF-8 value of $LC_TIME: sv_SE.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rg pcase vc vc-dispatcher rg-info-hack advice rg-menu transient cl-extra help-mode easymenu format-spec eieio eieio-core eieio-loaddefs rg-ibuffer ibuf-macs rg-result derived wgrep-rg wgrep rg-history cl-seq cl-macs subr-x rg-header ibuf-ext ibuffer ibuffer-loaddefs seq byte-opt gv bytecomp byte-compile cconv grep compile comint ansi-color ring cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting xwidget-internal cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 81436 6914) (symbols 48 9028 1) (strings 32 24666 2335) (string-bytes 1 829109) (vectors 16 15246) (vector-slots 8 190627 11660) (floats 8 28 26) (intervals 56 294 0) (buffers 1000 12)) --=-=-=--