From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#43609: 28.0.50; eldoc-documentation-function [vs new eldoc-display-functions] Date: Wed, 28 Oct 2020 09:54:16 +0000 Message-ID: <87zh46n0af.fsf@gmail.com> References: <2e610c3f-6e5f-c7dd-af2e-aeb5e20d8664@gmx.at> <87r1qjjppu.fsf@gmail.com> <3fa6b315-7fc0-06ee-81e9-b68d164aec1b@gmx.at> <87a6x7jf9a.fsf@gmail.com> <874knbi0jc.fsf_-_@gmail.com> <87362tggvl.fsf@gmail.com> <87d01vem7z.fsf@gmail.com> <17da3e99-d4fc-a603-baa3-4180d612af41@gmx.at> <878scie5ti.fsf@gmail.com> <87tuujr6sd.fsf@gmail.com> <803c87c2-7d60-5997-2247-85d3e62e3d2c@gmx.at> <87a6w7puuz.fsf@gmail.com> <64831acc-996e-51d7-ce6f-b667a6334e3c@gmx.at> <87imavo322.fsf@gmail.com> <878sbqwvyd.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="982"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Yuan Fu , 43609@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 28 10:55:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXiAo-00009b-R0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Oct 2020 10:55:18 +0100 Original-Received: from localhost ([::1]:36528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXiAn-0002GQ-Q6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Oct 2020 05:55:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXiAY-0002GD-IQ for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 05:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXiAY-0003TS-7H for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 05:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kXiAY-0001x0-5T for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 05:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Oct 2020 09:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43609 X-GNU-PR-Package: emacs Original-Received: via spool by 43609-submit@debbugs.gnu.org id=B43609.16038788657452 (code B ref 43609); Wed, 28 Oct 2020 09:55:02 +0000 Original-Received: (at 43609) by debbugs.gnu.org; 28 Oct 2020 09:54:25 +0000 Original-Received: from localhost ([127.0.0.1]:47232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXi9x-0001w8-9h for submit@debbugs.gnu.org; Wed, 28 Oct 2020 05:54:25 -0400 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:41382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXi9w-0001vv-24 for 43609@debbugs.gnu.org; Wed, 28 Oct 2020 05:54:24 -0400 Original-Received: by mail-wr1-f54.google.com with SMTP id s9so4961224wro.8 for <43609@debbugs.gnu.org>; Wed, 28 Oct 2020 02:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=7H9MDNy5AQU9CCH19jsp+24M8KB6zQ1MFFvR4LnOho8=; b=inVAvfBa4U9vO9uDYC128cEh5lYgxXeZxprHpJvv7Zl8QStJ7rcm1Tcgr5UEN2clzE DunajP1oBxd8ZX2xkDDpN2dfVbJBTWqO2+bOWkgUiCMPmOOSDv1eOlpq5uBHkzcp3yW6 dfjKxz4vyk9kkjG99rvoOk4DeUfPRSveaiIBG2Op7jdwLdRTTb8OZQ8R3a8gGyqjbXZ+ l7+MScE5uBk82RhupeL4EFZO4gdpPDeBPPf4aTC4Sf6Q1DuWiQcSB8S8gyO+EUGvV8Xr aNnyU/YXBayB9aWWydPCnE4rYOd3VrtPcHK6zo9g0rdlFLxahpcGj/n0vcYpCSxpw6qc MXig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=7H9MDNy5AQU9CCH19jsp+24M8KB6zQ1MFFvR4LnOho8=; b=dIg2COcTqiQomFGrN8qpsJDrO0yC/qCnTpO20iNQ3xQ671q0qUub0GBqVLHRU7TBTL 7cAMv6dCEmhXbFuRm0NIQR2t+G8LBmIhIxmz/eLKucJHtX+iyZhPRSg91EP5hmG4oXtC d7CyGFBRjzo6KnbbqF6Oh0cMyvleuaPtBfDJltpK5sE/XN2GHGcZmRYyWKB1bEOqsbyC bMrlUCPVZJeLknzAlXhFRug5yW3PYFoVLu4UPDFUrYdFMHDWoH7VGP2dDWttrCl9BXt4 R/yb0w5YkzWnfsRQ8R/iI+T1kaOT0rXHKX78TKyrCz3R4cQ4xEvo/JbxmSnwDCGLOaAq 6B9Q== X-Gm-Message-State: AOAM531JMoRQ1V5fAkujr3DeSQV5DjMphDlT3bYMyZJVatLRtwESXUBi GjkbcFQz3tCRq+6tVR84hvU= X-Google-Smtp-Source: ABdhPJxEwEJnlSgDH5Dk5AeHJ0doqdqMXxRYBpohotoIiOEI/BFEtcGpiB4zPZ+ahPPohmB88eZppg== X-Received: by 2002:a5d:5703:: with SMTP id a3mr1560402wrv.67.1603878858232; Wed, 28 Oct 2020 02:54:18 -0700 (PDT) Original-Received: from krug (89-180-148-164.net.novis.pt. [89.180.148.164]) by smtp.gmail.com with ESMTPSA id c10sm5379357wmb.20.2020.10.28.02.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 02:54:17 -0700 (PDT) In-Reply-To: <878sbqwvyd.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 28 Oct 2020 10:17:46 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191836 Archived-At: Lars Ingebrigtsen writes: > Jo=C3=A3o T=C3=A1vora writes: > >> [Lars, I'm CC'ing you specifcally since there's a patch to review at the >> end.] > > I don't really know much about eldoc, so I don't have much to say here... > > [...] > >> +(defalias 'elisp-eldoc-documentation-function 'elisp--documentation-one= -liner > > [...] > >> +(make-obsolete 'elisp-eldoc-documentation-function >> + "use ElDoc's interfaces instead." "28.1") >> + > > But this seems like the correct approach -- we should never remove > non-internal functions without going through the obsoletion process. > (And "--" functions are the only ones that are clearly marked as > internal; for internalish functions prior to that convention we have to > do this for all of them, whether we consider them internal or not.) OK, I'm pushing that. Jo=C3=A3o