unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "積丹尼 Dan Jacobson" <jidanni@jidanni.org>
Cc: 44375@debbugs.gnu.org, Stefan Kangas <stefankangas@gmail.com>
Subject: bug#44375: Always give a message when flashing the screen
Date: Mon, 02 Nov 2020 17:24:28 +0100	[thread overview]
Message-ID: <87zh3z4thf.fsf@gnus.org> (raw)
In-Reply-To: <874km7693k.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 02 Nov 2020 17:01:51 +0100")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I don't have a recipe to reproduce it, though -- In this Emacs I can do
> `M-x describe-face RET default RET' and then mouse-1 on the "faces.el"
> button, and Emacs will ding me before taking me to the faces.el file.

I still don't have a recipe -- it seems to happen after having done an
unspecified number of actions in the *Help* buffer.  The thing that's
dinging is this, though:

(defun mouse-drag-track (start-event)

[...]

     t (lambda ()
         (setq track-mouse old-track-mouse)
         (setq auto-hscroll-mode auto-hscroll-mode-saved)
         (deactivate-mark)
         (pop-mark)))))

When the pop-mark is called (mark t) is non-nil.  pop-mark is just this:

(defun pop-mark ()
  "Pop off mark ring into the buffer's actual mark.
Does not set point.  Does nothing if mark ring is empty."
  (when mark-ring
    (setq mark-ring (nconc mark-ring (list (copy-marker (mark-marker)))))
    (set-marker (mark-marker) (car mark-ring))
    (set-marker (car mark-ring) nil)
    (unless (mark t) (ding))
    (pop mark-ring))
  (deactivate-mark))

(mark t) is nil here, so it dings.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-11-02 16:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-01 19:32 bug#44375: Always give a message when flashing the screen 積丹尼 Dan Jacobson
2020-11-01 21:26 ` Stefan Kangas
2020-11-01 21:48   ` 積丹尼 Dan Jacobson
2020-11-02 16:01     ` Lars Ingebrigtsen
2020-11-02 16:24       ` Lars Ingebrigtsen [this message]
2020-11-02 16:26         ` Lars Ingebrigtsen
2021-09-08 10:22           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zh3z4thf.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=44375@debbugs.gnu.org \
    --cc=jidanni@jidanni.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).