From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git Date: Mon, 08 Feb 2021 18:35:31 +0200 Message-ID: <87zh0eo6uk.fsf@protesilaos.com> References: <87czxc5cku.fsf@protesilaos.com> <83tuqnnc3s.fsf@gnu.org> <87pn1b4zxp.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11372"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46358@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 08 22:43:46 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9EJt-0002q3-HD for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Feb 2021 22:43:45 +0100 Original-Received: from localhost ([::1]:49058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9EJs-0006fv-JR for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Feb 2021 16:43:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l99W6-0003dh-H2 for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 11:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40233) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l99W5-00033Z-Nb for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 11:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l99W5-0003qy-Hy for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 11:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2021 16:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46358 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 46358-submit@debbugs.gnu.org id=B46358.161280214714792 (code B ref 46358); Mon, 08 Feb 2021 16:36:01 +0000 Original-Received: (at 46358) by debbugs.gnu.org; 8 Feb 2021 16:35:47 +0000 Original-Received: from localhost ([127.0.0.1]:51779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l99Vr-0003qW-Bw for submit@debbugs.gnu.org; Mon, 08 Feb 2021 11:35:47 -0500 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:42275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l99Vl-0003qE-PH for 46358@debbugs.gnu.org; Mon, 08 Feb 2021 11:35:45 -0500 X-Originating-IP: 94.46.225.161 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D852BC0007; Mon, 8 Feb 2021 16:35:33 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Mon, 8 Feb 2021 17:54:17 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199627 Archived-At: On 2021-02-08, 17:54 +0200, Dmitry Gutov wrote: > Thanks, this is better. > > I'm not opposed to changing colors, but this probably should be done > systematically across many faces in the default theme, rather than in > one specific UI element. Shouldn't it? Yes, that would be better. >>>> With regard to point 2, I only use Git and thus cannot test the other >>>> backends with the requisite degree of confidence. Do you think I should >>>> try regardless? Or should we just support the Git backend and hope that >>>> someone else will work on [some of] the other backends? >>> >>> If you can easily try other backends, it will be appreciated. But it >>> is not mandatory, IMO. >> I will inspect their code and try to identify whatever looks the same >> as >> vc-git. Then I will prepare a separate patch. > > FWIW, Git is the only backend that has a complex dir-printer method. > > The rest look pretty much like vc-hg-dir-printer, but > 'font-lock-comment-face' in there should be changed to some new face > too. Thanks! I still have not had the time to check those, though I plan to do so. It would be nice to ensure consistency between all backends. >>> Personally, I think inheriting from the existing faces will be less >>> drastic, so it's probably better. >> Very well! I am doing just that in the revised patch. So there >> should >> be no visual difference between this and the prior state, except for one >> case: the empty Git stash header, which will ultimately inherit from >> 'shadow' (before there was a "FIXME" to disambiguate it from other >> header values). > > Some questions: > > - vc-dir-ignored face doesn't seem to be used the 'ignored' entries in > the list. Wasn't that its main point? Can you please specify which are those? I only applied the 'vc-dir-ignored' face to the empty Git stash and only did so because there was a "FIXME" for it. Otherwise, yes, the new face should be used wherever it makes sense. > - vc-git-dir-printer defaults entries to the 'vc-dir-status-edited' > face, whereas vc-default-dir-printer defaults to vc-dir-header-value' > (statuses that are not 'up-to-date', 'missing', 'conflict' or > 'edited'). Which is the intended behavior? Which one do we want? > There is an omission from my part that I will now prepare a patch for with regard to the "edited" check of 'vc-default-dir-printer'. It needs to specify 'vc-dir-status-edited' instead of 'font-lock-constant-face'. As for its default value, I was not sure what those other states were, so I just used 'vc-dir-header-value', thinking that this is a neutral value. Should the default look like "edited" as well? Or does it have some other meaning? If the latter, then maybe we must have extra face? -- Protesilaos Stavrou protesilaos.com