unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / Atom feed
* bug#11995: vc-compilation-mode name and implementation
@ 2012-07-19 19:38 Dan Nicolaescu
  2021-01-20  4:20 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 3+ messages in thread
From: Dan Nicolaescu @ 2012-07-19 19:38 UTC (permalink / raw)
  To: 11995


The newly added vc-compilation-mode function does not have the best
name, -mode functions stand for modes, this is not one.

Currently the preferred way to define modes is to use `defined-derived-mode'...

Also the implementation seems to be a bit more complicated than needed:
there

Defining a vc-default-compilation-mode function should simplify the
implementation.  vc-make-backend-sym is something that very few things
need to call.

I'm leaving on vacation, so I won't be able to do much about this for a while.











^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#11995: vc-compilation-mode name and implementation
  2012-07-19 19:38 bug#11995: vc-compilation-mode name and implementation Dan Nicolaescu
@ 2021-01-20  4:20 ` Lars Ingebrigtsen
  2021-02-22 15:17   ` Lars Ingebrigtsen
  0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2021-01-20  4:20 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: 11995

Dan Nicolaescu <dann@gnu.org> writes:

> The newly added vc-compilation-mode function does not have the best
> name, -mode functions stand for modes, this is not one.

(I'm going through old bug reports that unfortunately got no response at
the time.)

It is perhaps not an ideal name, but it's probably too late to change
now, though.

> Currently the preferred way to define modes is to use
> `defined-derived-mode'...
>
> Also the implementation seems to be a bit more complicated than needed:
> there
>
> Defining a vc-default-compilation-mode function should simplify the
> implementation.  vc-make-backend-sym is something that very few things
> need to call.

I think it looks like something was left out of this message?  I'm not
sure what this is referring to.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#11995: vc-compilation-mode name and implementation
  2021-01-20  4:20 ` Lars Ingebrigtsen
@ 2021-02-22 15:17   ` Lars Ingebrigtsen
  0 siblings, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2021-02-22 15:17 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: 11995

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> Defining a vc-default-compilation-mode function should simplify the
>> implementation.  vc-make-backend-sym is something that very few things
>> need to call.
>
> I think it looks like something was left out of this message?  I'm not
> sure what this is referring to.

More information was requested, but no response was given within a
month, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-22 15:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-19 19:38 bug#11995: vc-compilation-mode name and implementation Dan Nicolaescu
2021-01-20  4:20 ` Lars Ingebrigtsen
2021-02-22 15:17   ` Lars Ingebrigtsen

unofficial mirror of bug-gnu-emacs@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/emacs-bugs/0 emacs-bugs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 emacs-bugs emacs-bugs/ https://yhetil.org/emacs-bugs \
		bug-gnu-emacs@gnu.org
	public-inbox-index emacs-bugs

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.emacs.bugs
	nntp://news.gmane.io/gmane.emacs.bugs


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git