From: Protesilaos Stavrou <public@protesilaos.com>
To: 46748@debbugs.gnu.org
Subject: bug#46748: 28.0.50; [PATCH] Use named faces in shortdoc
Date: Wed, 24 Feb 2021 11:15:59 +0200 [thread overview]
Message-ID: <87zgztq10w.fsf@protesilaos.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
Dear maintainers,
The shortdoc.el library applies faces in a way that is difficult for
users/themes to customise. The attached patch addresses that issue.
All the best,
Protesilaos
--
Protesilaos Stavrou
protesilaos.com
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Use-named-faces-in-shortdoc.patch --]
[-- Type: text/x-patch, Size: 2535 bytes --]
From 4f6f62a10da39646692ed70eec60ff05726d7c32 Mon Sep 17 00:00:00 2001
Message-Id: <4f6f62a10da39646692ed70eec60ff05726d7c32.1614158067.git.info@protesilaos.com>
From: Protesilaos Stavrou <info@protesilaos.com>
Date: Wed, 24 Feb 2021 11:01:20 +0200
Subject: [PATCH] Use named faces in shortdoc
* shortdoc.el (shortdoc-heading): Define new face for headings.
(shortdoc-display-group): Apply new heading face.
(shortdoc--display-function): Use existing face for section text.
* etc/NEWS: Document new face.
---
etc/NEWS | 4 ++++
lisp/emacs-lisp/shortdoc.el | 9 +++++++--
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/etc/NEWS b/etc/NEWS
index 5df8ee140c..2bad41f5ee 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1734,6 +1734,10 @@ If this is bound to something non-nil, functions like
This is a plain 2D button, but uses the background color instead of
the foreground color.
+---
+*** New face 'shortdoc-heading'.
+Applies to headings of shortdoc sections.
+
+++
*** New predicate functions 'length<', 'length>' and 'length='.
Using these functions may be more efficient than using 'length' (if
diff --git a/lisp/emacs-lisp/shortdoc.el b/lisp/emacs-lisp/shortdoc.el
index 39e69f5aab..789d6325e9 100644
--- a/lisp/emacs-lisp/shortdoc.el
+++ b/lisp/emacs-lisp/shortdoc.el
@@ -40,6 +40,11 @@ shortdoc-separator
(t :height 0.1 :inverse-video t :extend t))
"Face used to separate sections.")
+(defface shortdoc-heading
+ '((t :inherit variable-pitch :height 1.3 :weight bold))
+ "Face used for a heading."
+ :version "28.1")
+
(defface shortdoc-section
'((t :inherit variable-pitch))
"Face used for a section.")
@@ -1107,7 +1112,7 @@ shortdoc-display-group
(insert "\n"))
(insert (propertize
(concat (substitute-command-keys data) "\n\n")
- 'face '(variable-pitch (:height 1.3 :weight bold))
+ 'face 'shortdoc-heading
'shortdoc-section t)))
;; There may be functions not yet defined in the data.
((fboundp (car data))
@@ -1175,7 +1180,7 @@ shortdoc--display-function
(prin1 value (current-buffer)))
(insert "\n " single-arrow " "
(propertize "[it depends]"
- 'face 'variable-pitch)
+ 'face 'shortdoc-section)
"\n"))
(:no-value
(if (stringp value)
--
2.30.1
next reply other threads:[~2021-02-24 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 9:15 Protesilaos Stavrou [this message]
2021-02-24 16:18 ` bug#46748: 28.0.50; [PATCH] Use named faces in shortdoc Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgztq10w.fsf@protesilaos.com \
--to=public@protesilaos.com \
--cc=46748@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).