From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc Date: Sun, 28 Mar 2021 07:23:47 -0400 Message-ID: <87zgynbjy4.fsf@gmail.com> References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> <87y2e894x6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20208"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , Stefan Monnier , 47388@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 28 13:25:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQTXg-0005CB-KI for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 13:25:16 +0200 Original-Received: from localhost ([::1]:46456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQTXe-00053r-TA for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 07:25:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQTWW-0004o6-7X for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 07:24:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33933) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQTWU-0008BW-Hs for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 07:24:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQTWU-0005sG-Cd for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 07:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Mar 2021 11:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47388 X-GNU-PR-Package: emacs Original-Received: via spool by 47388-submit@debbugs.gnu.org id=B47388.161693063722564 (code B ref 47388); Sun, 28 Mar 2021 11:24:02 +0000 Original-Received: (at 47388) by debbugs.gnu.org; 28 Mar 2021 11:23:57 +0000 Original-Received: from localhost ([127.0.0.1]:45479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQTWP-0005rr-1b for submit@debbugs.gnu.org; Sun, 28 Mar 2021 07:23:57 -0400 Original-Received: from mail-qk1-f171.google.com ([209.85.222.171]:35330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQTWN-0005rf-Dc for 47388@debbugs.gnu.org; Sun, 28 Mar 2021 07:23:55 -0400 Original-Received: by mail-qk1-f171.google.com with SMTP id i9so9800663qka.2 for <47388@debbugs.gnu.org>; Sun, 28 Mar 2021 04:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=GTg1SnvwcNpICxu0v9tO6TBrbhKHOstvOF5fj5+bSgA=; b=dZKvknjR2uXg2KLzKMA3L/CCI0kYxcRVttrj/1iGTfHp65GVcVFX/pKDsupuFDs7fW GGxAbh/gNYtF/s8zCxDklFL2sYL0Vez7Xj8sNKfKXzDk+R9UGeXWEx2PphyyRI0zAYU+ keMPV8XWBqmq4/SmYzZmyunrw/zvZTlFft6KqPExBXCeGkuB4JAQFae/2Avpj1eRiHbP fy2fD6Fo5Bc/cHPIPrDZuK2/eHpm8nlon0V1t3NmJMNS0AmooXHF3dnsMXVDUhvvhE6n Jkf/e1bPCtANftbLe/rTclYt2gNNkbcOsYdXoq3WIEdxF5fc1/dtH2Dnq6FrJChrISE8 dqXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=GTg1SnvwcNpICxu0v9tO6TBrbhKHOstvOF5fj5+bSgA=; b=EghJZ4I14kWgHmK/18cGufB4sT0nH/b+mmjKVwiRXln46XRuEu0cMmgyhc1PcJ/+N/ Gqm0gZehJEqpP+m9k16ZlY/MWtSCCYH/kz3yJIfjvIbqcAEaEMa3HJU1uPzazgHelLgO k+3qw2adVWxOT8l8O8+jMxdY65V2j/Qa9PluOE+9gNo/gM7xuLTJMauv1Sp9nBvmv/YE Tswriuu2V4szFNvwxkx7NHaa/ile97xus/xQmsWJDi+j7Nf+ptx4A/SYHZT+uJWizLqp f0Y/NAkm2Hwq1ftdPhDvJ1qZGBFT4Hg8E4k507M59J6Tq8VZi9pekEcsDMR8SSCqFSKt DvuA== X-Gm-Message-State: AOAM5304eTP7JzrKyTXtl+7NvjB4Lq4J2Vk2d8Sb1eMmtZ13GLmQrmon TxFN9AAFleWS7JsexaPn4xr/1J8AYzM= X-Google-Smtp-Source: ABdhPJzVUkdCZL82F7v4DdJWd7u0Z27lKIpUrnKXAM2uajRHOy1dpfQxnepVpM6ndZpILBZY0Knjpw== X-Received: by 2002:a05:620a:22f5:: with SMTP id p21mr20483604qki.225.1616930629601; Sun, 28 Mar 2021 04:23:49 -0700 (PDT) Original-Received: from earth (c-73-163-194-78.hsd1.dc.comcast.net. [73.163.194.78]) by smtp.gmail.com with ESMTPSA id j30sm9121679qtv.90.2021.03.28.04.23.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Mar 2021 04:23:48 -0700 (PDT) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sat, 27 Mar 2021 12:53:13 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203153 Archived-At: On Sat 27 Mar 2021 at 12:53, Jo=C3=A3o T=C3=A1vora w= rote: > I'm not sure you're improving much here. My idea is that, > if you find eldoc-documentation-functions (plural) to be bound you > may need to check that eldoc-documentation-strategy (or > eldoc-documentation-function (singular)) ISN'T #ignore and > buffer-locally adjust it accordingly to something of your preference > or your users' preference. Thanks! It sounds like the below is what you're suggesting modes do in order to support all the possible eldoc+Emacs versions, let me know if I've misunderstood. (if (not (boundp 'eldoc-documentation-functions)) ;; old eldoc (add-function :before-until (local 'eldoc-documentation-function) #'ess-r-eldoc-function) ;; new eldoc (add-hook 'eldoc-documentation-functions #'ess-r-eldoc-function nil t) ;; new eldoc + Emacs 27.1 (when (and (fboundp 'eldoc-documentation-default) (function-equal #'ignore eldoc-documentation-function)) (setq-local eldoc-documentation-function #'eldoc-documentation-default)= )) If that's right, it seems like a step backwards, ease-of-setup-wise at least, from the simple (add-function :before-until (local 'eldoc-documentation-function) #'ess-r-e= ldoc-function) that we did before new eldoc. But maybe it's necessary, I haven't really played around with the new eldoc features at all. Thanks again!