From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#38164: quit-restore-window doesn't restore point in man Date: Sun, 04 Apr 2021 19:13:01 +0100 Message-ID: <87zgyd536a.fsf@tcd.ie> References: <8ea0a3fa-5169-4493-bd54-3ebe47836a35@default> <87r3i9nped.fsf@gnus.org> <87wps1m7co.fsf@web.de> <87r22gbquk.fsf@mail.linkov.net> <875zjrzgoz.fsf_-_@mail.linkov.net> <02f0564a-baf3-b15c-bcc5-98d37f510d7a@gmx.at> <877e45ksaz.fsf@mail.linkov.net> <874knrp9ad.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26040"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 38164@debbugs.gnu.org, Juri Linkov To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 04 20:14:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lT7GE-0006cz-7z for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Apr 2021 20:14:10 +0200 Original-Received: from localhost ([::1]:35362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT7GC-0000bL-Rf for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Apr 2021 14:14:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lT7G6-0000ay-9W for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 14:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53104) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lT7G6-0001LD-1K for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 14:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lT7G5-00051a-Rq for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 14:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Apr 2021 18:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38164 X-GNU-PR-Package: emacs Original-Received: via spool by 38164-submit@debbugs.gnu.org id=B38164.161755999119244 (code B ref 38164); Sun, 04 Apr 2021 18:14:01 +0000 Original-Received: (at 38164) by debbugs.gnu.org; 4 Apr 2021 18:13:11 +0000 Original-Received: from localhost ([127.0.0.1]:36417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT7FH-00050K-7E for submit@debbugs.gnu.org; Sun, 04 Apr 2021 14:13:11 -0400 Original-Received: from mail-wm1-f43.google.com ([209.85.128.43]:52797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT7FF-000508-DP for 38164@debbugs.gnu.org; Sun, 04 Apr 2021 14:13:10 -0400 Original-Received: by mail-wm1-f43.google.com with SMTP id d191so4762148wmd.2 for <38164@debbugs.gnu.org>; Sun, 04 Apr 2021 11:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=16ivI5omiaVwDOgnormNxVstGEE6b4jIKHFa8cvdVcA=; b=b/O+NbqXwJEFDO7IpbXr+gcdQBOmuBCcN+Kg1pv4oPHRtFPXaogNQvPyutv9M6fiz/ pF79HyXoXA3GUSRKpM6WsHpNdd1IXWGMXvo+nPWYMmUiZgpwPZt4Jh58FQix4EJZHe8B c34/2DZLQNSznqsaxZh6o2WB/BDsyG8N7WvYMi9wzCay2n+NSlxU0Kwl9ZBl3Z49PmGk JIY8TfKi6pKdBYg+JwGEgQ4Dax57AwihlPKjG2LZNxWIbzRkkxdDR3A7EttP+YmYUm1K xSAWanYtyurwF8tlnyXeBjTLekASdDwn/feC2K5NLcK8xBnpLpGOQCOvoBpSwioaMCRj PnFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=16ivI5omiaVwDOgnormNxVstGEE6b4jIKHFa8cvdVcA=; b=aI/ccictwrCgfWPbnJVbIQu+mI9k9bSdFHRfvpRqRQvL6OO8Y64Itx084XI3Pxt4fB VFrwVe13Rf91qoHNODs4KUVIeO2cmtTLEvpRTRRVBHT6OpNL5HEOFXKlhBtAwxrMaxV4 BQmniBKxbpqyL+3yjprJTaxk5D6OkP3bM+BOqB6dBmU/7OE5jw8yr1g3ZFwSV/rI8pgR UHO8T9JJwTicPmkc9Y9Rj9FgzNbOWKXyBBaSSFJ4qsvgZLprosaWh94orkvCnUeQPuHC paSy1LVd7e13GFf45cbxYj5nwuGcl8/wZEbXeryxE8tYEP7/fj+bTIvmsIL2P5dsNskN v0Mw== X-Gm-Message-State: AOAM530mRmo8vqyqJ1GYuuxXJ/FvTipx//rrI8UIUwoBd80QSTOnUXbl bCyUJVathm9mVcD1+YP3C0lqGA== X-Google-Smtp-Source: ABdhPJxdI/vOhUTAw+QTI/+1lTU5+RQOHcQJid/EsLC4kikFK5INiyNFsKplrRZVAJSxIr7Lnl75qQ== X-Received: by 2002:a05:600c:1405:: with SMTP id g5mr21504714wmi.140.1617559983648; Sun, 04 Apr 2021 11:13:03 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id p10sm24841268wrw.33.2021.04.04.11.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Apr 2021 11:13:02 -0700 (PDT) In-Reply-To: <874knrp9ad.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 21 Sep 2020 15:08:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203551 Archived-At: Lars Ingebrigtsen writes: > Juri Linkov writes: > >> - (quit-restore-window >> - (get-buffer-window Man-buffer t) 'kill) >> + (progn >> + (quit-restore-window >> + (get-buffer-window Man-buffer t) 'kill) >> + (select-window (old-selected-window))) > > The discussion then dealt mostly with general quit-restore-windows > issues, but I think this patch should be applied, since it fixes an > annoying problem in Man. So I've now pushed it to Emacs 28. This gives rise to the following regression: 0. emacs -Q 1. (setq Man-notify-method 'aggressive) C-x C-e 2. M-x man RET mythical RET This used to pop up and very quickly hide a window (but that's a separate issue), and then the echo area displayed: Can't find the mythical manpage Whereas now the phantom window remains displayed much longer, the echo area displays: error in process sentinel: Wrong type argument: window-live-p, # and the *Messages* buffer also contains: error in process sentinel: Man-bgproc-sentinel: Wrong type argument: window-live-p, # Ideally a non-existent manpage would result only in the "can't find" message, without any inadvertent Lisp errors or window dances. Thanks, -- Basil