From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#45412: File ... is large (... MiB), really open? (y)es or (n)o or (l)iterally Date: Fri, 23 Apr 2021 01:09:04 +0300 Organization: LINKOV.NET Message-ID: <87zgxqj7r3.fsf@mail.linkov.net> References: <87k0t72rhd.5.fsf@jidanni.org> <8735zuig9m.fsf@gnus.org> <87wnx62rpe.fsf@mail.linkov.net> <877dl80vwk.fsf@gnus.org> <87mttxqgnv.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9217"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 45412@debbugs.gnu.org, Lars Ingebrigtsen , =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 23 00:11:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZhXZ-000272-VQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Apr 2021 00:11:17 +0200 Original-Received: from localhost ([::1]:57040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZhXZ-0000HL-0b for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Apr 2021 18:11:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZhXK-0000H6-9z for bug-gnu-emacs@gnu.org; Thu, 22 Apr 2021 18:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52436) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZhXK-00031H-2p for bug-gnu-emacs@gnu.org; Thu, 22 Apr 2021 18:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lZhXJ-0001YV-Uy for bug-gnu-emacs@gnu.org; Thu, 22 Apr 2021 18:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Apr 2021 22:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45412 X-GNU-PR-Package: emacs Original-Received: via spool by 45412-submit@debbugs.gnu.org id=B45412.16191294065907 (code B ref 45412); Thu, 22 Apr 2021 22:11:01 +0000 Original-Received: (at 45412) by debbugs.gnu.org; 22 Apr 2021 22:10:06 +0000 Original-Received: from localhost ([127.0.0.1]:35749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZhWQ-0001XD-Cs for submit@debbugs.gnu.org; Thu, 22 Apr 2021 18:10:06 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:42431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZhWL-0001W6-9r for 45412@debbugs.gnu.org; Thu, 22 Apr 2021 18:10:01 -0400 X-Originating-IP: 91.129.102.166 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id CAFD71C0002; Thu, 22 Apr 2021 22:09:53 +0000 (UTC) In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?="'s message of "Thu, 22 Apr 2021 00:12:54 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204721 Archived-At: > The idea to show the help text also for graphical prompts is a good > idea, but as there's no command already in Emacs that supports it, > AFAIK, it could be a separate feature request. What do you think? Thanks. While testing your patches, I noticed a compilation warning: emacs-lisp/rmc.el:29:1: Warning: Variable `buf' left uninitialized Also these let-bindings are duplicated: (prompt (format "File %s is large (%s), really %s?" (file-name-nondirectory filename) (funcall byte-count-to-string-function size) op-type)) Otherwise, it looks nice, except of Eli's comment about the need to keep graphical dialogs.