From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#48179: bookmark-fontify [PATCH] Date: Mon, 03 May 2021 09:54:16 +0200 Message-ID: <87zgxcdzh3.fsf@gnus.org> References: <20210503001358.mjafsjlumdamrlvh@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25806"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48179@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 03 09:55:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldTQ5-0006aq-Hu for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 09:55:09 +0200 Original-Received: from localhost ([::1]:37102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldTQ4-0004zP-KH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 03:55:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldTPx-0004zJ-S2 for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 03:55:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34559) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldTPx-0000FO-LB for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 03:55:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldTPx-0002m7-KM for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 03:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 May 2021 07:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48179-submit@debbugs.gnu.org id=B48179.162002846710654 (code B ref 48179); Mon, 03 May 2021 07:55:01 +0000 Original-Received: (at 48179) by debbugs.gnu.org; 3 May 2021 07:54:27 +0000 Original-Received: from localhost ([127.0.0.1]:46105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldTPP-0002lm-HD for submit@debbugs.gnu.org; Mon, 03 May 2021 03:54:27 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:38780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldTPN-0002ld-Ee for 48179@debbugs.gnu.org; Mon, 03 May 2021 03:54:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1R51lz0htoQSg1imy/L7toXuAsGU9mp9eRLedyDEATI=; b=Wb3QRyZXvYYAw8j7jptoifcksM l/skeI49ZiIksdT7qpliG3HDOs+ingzxMhxtqBR4BrpuKc81t8jFDKKDoV9bAjiL0+sPrKwJJQZHs gZmN/td1+EqudUR5TAVFHxh5tBtQ7jTiwD732eZRef+xiu2rNUOkHR89UhdeU6k28cZ0=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldTPE-0001tH-QT; Mon, 03 May 2021 09:54:19 +0200 X-Now-Playing: Tied + Tickled Trio's _Constant RMX_: "Constant (von Blond)" In-Reply-To: <20210503001358.mjafsjlumdamrlvh@E15-2016.optimum.net> (Boruch Baum's message of "Sun, 2 May 2021 20:13:58 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205475 Archived-At: Boruch Baum writes: > The attached patch adds a feature to bookmark.el to colorize a > bookmark's line, making it easily observable. The idea was adopted from > package bm.el, available on MELPA. I was able to test this on Emacs 27, > but there seem to have been some changes in snapshot to make it > difficult to use that version of bookmark.el on my Emacs 27, so please > verify that I performed the migration properly. The patch is against Emacs 27, I guess? (Because it didn't apply cleanly on Emacs 28.) We're not accepting new features for Emacs 27, though, so can you respin it for Emacs 28? Also -- it's slightly obscure what it's doing, but testing seems to indicate that it just puts a face over the current line when you're doing a `C-x r m' command? That's nice, but I think it would also make sense to restore these faces when jumping to a buffer from the bookmark buffer -- otherwise it's just a bit confusing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no