unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Daniel Mendler <mail@daniel-mendler.de>
Cc: 47771@debbugs.gnu.org
Subject: bug#47771: 27.1; `Info-read-node-name` throws error during completion
Date: Wed, 05 May 2021 16:59:07 +0200	[thread overview]
Message-ID: <87zgx94478.fsf@gnus.org> (raw)
In-Reply-To: <4d2568fb-adad-6f3e-2684-13ec2cc70457@daniel-mendler.de> (Daniel Mendler's message of "Wed, 14 Apr 2021 14:53:46 +0200")

Daniel Mendler <mail@daniel-mendler.de> writes:

> 1. M-x icomplete-mode
> 2. Press "C-h i"
> 3. Press "g" to run `Info-goto-node`
> 4. Enter "(boom)"
> 5. Move around with the cursor left to right or wait until the
> `icomplete-post-command-hook` fails.
>
> In order to fix the issue, the following patch can be applied:
>
> diff --git a/info.el b/info-patched.el
> index 3bed743..42a7fce 100644
> --- a/info.el
> +++ b/info-patched.el
> @@ -1881,7 +1881,8 @@ See `completing-read' for a description of
> arguments and usage."
>           (lambda (string pred action)
>             (complete-with-action
>              action
> -            (Info-build-node-completions (Info-find-file file1 nil t))
> +            (let ((file2 (Info-find-file file1 'noerror t)))
> +              (and file2 (Info-build-node-completions file2)))

Thanks; applied to Emacs 28 (with some minor changes).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-05-05 14:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-14 12:53 bug#47771: 27.1; `Info-read-node-name` throws error during completion Daniel Mendler
2021-05-05 14:59 ` Lars Ingebrigtsen [this message]
2021-05-05 15:48   ` Daniel Mendler
2021-05-06  9:26     ` Lars Ingebrigtsen
2021-05-06  9:42       ` Daniel Mendler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgx94478.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=47771@debbugs.gnu.org \
    --cc=mail@daniel-mendler.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).