From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#17757: 24.4.50; Whitespace changes break signature mark Date: Wed, 14 Jul 2021 16:21:35 +0200 Message-ID: <87zgupht74.fsf@gnus.org> References: <87mvr77fb2.fsf@mbork.pl> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21784"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 17757@debbugs.gnu.org, Stefan Monnier , James Cloos To: Marcin Borkowski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 14 16:30:42 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3fuL-0005SZ-Pz for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Jul 2021 16:30:41 +0200 Original-Received: from localhost ([::1]:35422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3fuK-00053l-Ni for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Jul 2021 10:30:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3fly-0004cA-KN for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2021 10:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34054) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3fly-0006PY-A5 for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2021 10:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m3fly-0005Kw-19 for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2021 10:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Jul 2021 14:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17757 X-GNU-PR-Package: emacs Original-Received: via spool by 17757-submit@debbugs.gnu.org id=B17757.162627251320501 (code B ref 17757); Wed, 14 Jul 2021 14:22:01 +0000 Original-Received: (at 17757) by debbugs.gnu.org; 14 Jul 2021 14:21:53 +0000 Original-Received: from localhost ([127.0.0.1]:45600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3flp-0005Ka-Jn for submit@debbugs.gnu.org; Wed, 14 Jul 2021 10:21:53 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:44046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3flm-0005KJ-VI for 17757@debbugs.gnu.org; Wed, 14 Jul 2021 10:21:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bo29KNuRG7isVQ23Xf6Zi130tAG944F0mbNUcNEr/g4=; b=V9qWbyHOC3wT3TmEb2hB4K6BtJ vb6TvzE6nD5lnLgpxkSrMIW8XSK+GLdjeBEG4Bo1+9nLscfb5j2jka72mAkuaRQSMpJo+l9qx3JrO Q0ugLHqLukhDeRx+kPGoGQKtffHSQhf8iVwiY4B3MW0ut164r620cqIHIMQLR9cajkMc=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3flX-0004Rk-Uu; Wed, 14 Jul 2021 16:21:39 +0200 X-Now-Playing: Fad Gadget's _Incontinent_: "Incontinent" In-Reply-To: <87mvr77fb2.fsf@mbork.pl> (Marcin Borkowski's message of "Thu, 11 Feb 2016 10:43:29 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209939 Archived-At: Marcin Borkowski writes: > I confirm that this is still a problem in GNU Emacs 25.1.50.2 (Git > commit 4ccd2688). > > Steps to reproduce in emacs -Q: > > C-x m (compose-mail) > M-> (end-of-buffer) > "-- " (i.e., dash - dash - space) > RET > > Now the space after the sigdashes disappears. Tracing this a bit more, it seems that this is what's deleting the space after the two dashes: (defun electric-indent-post-self-insert-function () ... (unless (eq electric-indent-inhibit 'electric-layout-mode) ;; Unless we're operating under ;; `electric-layout-mode' (Bug#35254), the goal here ;; will be to remove the trailing whitespace after ;; reindentation of the previous line because that ;; may have (re)introduced it. (goto-char before) ;; We were at EOL in marker `before' before the call ;; to `indent-according-to-mode' but after we may ;; not be (Bug#15767). (when (and (eolp)) (delete-horizontal-space t)))))) In Message mode, we want this to happen everywhere else, but not on that particular line. Does anybody have any idea how? I briefly wondered whether we could do something with fields (since `delete-horizontal-space' respects fields), but... Message mode fontises the signature delimiter, so we could use that to put some other text property on the trailing space character, but I'm not sure that's very appealing either. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no