From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#30056: 25.3; battery-mode-line-string missing leading space Date: Thu, 22 Jul 2021 16:15:42 +0200 Message-ID: <87zgueigdt.fsf@gnus.org> References: <83fu7d68bf.fsf@gnu.org> <834lnt5ybx.fsf@gnu.org> <83mv1k4cd1.fsf@gnu.org> <87tuxa39c7.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29343"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Glenn Morris , 30056@debbugs.gnu.org To: Allen Li Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 22 16:16:34 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6ZV4-0007Ni-FM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Jul 2021 16:16:34 +0200 Original-Received: from localhost ([::1]:40172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6ZV3-0002y6-GI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Jul 2021 10:16:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6ZUY-0002tC-NP for bug-gnu-emacs@gnu.org; Thu, 22 Jul 2021 10:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58095) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6ZUY-0008Dw-6R for bug-gnu-emacs@gnu.org; Thu, 22 Jul 2021 10:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6ZUX-0004MO-TE for bug-gnu-emacs@gnu.org; Thu, 22 Jul 2021 10:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Jul 2021 14:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30056 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30056-submit@debbugs.gnu.org id=B30056.162696336016754 (code B ref 30056); Thu, 22 Jul 2021 14:16:01 +0000 Original-Received: (at 30056) by debbugs.gnu.org; 22 Jul 2021 14:16:00 +0000 Original-Received: from localhost ([127.0.0.1]:41408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6ZUW-0004M9-Km for submit@debbugs.gnu.org; Thu, 22 Jul 2021 10:16:00 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6ZUR-0004Lt-Nj for 30056@debbugs.gnu.org; Thu, 22 Jul 2021 10:15:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bhAzMvhqtXXFXwgEBard7e/wHHAW9rjmmbBy0c0Konw=; b=ZSvXKTws0wXOWJFm0kQdjKohRK 223Yq1I3/6auXoZrJ+erQRBmtvSjKVKqTWINGzfNwaviSoUkjMqGQlxDdbCWAvL478VCaNbnBwPn/ A9leoDnXT9W1x26KSmjMTpvlvZUh0JGDlQXCBHCD4pleGoTFr4uILcNwQMoSUd6mOTcQ=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6ZUI-0003N9-GN; Thu, 22 Jul 2021 16:15:49 +0200 X-Now-Playing: Mr. Jones's _Sounds For The Mute_: "Continuous Sounds" In-Reply-To: <87tuxa39c7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 10 Aug 2020 15:43:20 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210525 Archived-At: Lars Ingebrigtsen writes: > Indeed. Just a random idea: Would it make sense to add a mode line > construct like "%S" to mode-line-format that means "put a space here if > there isn't one already"? Then battery could put "%S into the list? I had a peek at how to implement this, and it's surprisingly hard. The mode line stuff is constructed in three different paths (noprop/string/display), and getting at the "previous character" is different in every case. And I'm not really super enthusiastic about the idea in general, because it means that simple strings (like battery-mode-line-string) will have to be replaced by ("%S" battery-mode-line-string) lists... So perhaps we just have to bite the bullet and introduce a new convention: All `global-mode-string' bits have to start with a space character (and we'll remove the trailing character from `mode-line-modes'). This'll make some of these modes look awkward until they're all fixed. A less breakey change is to institute a different rule: All `global-mode-string' elements have to have a trailing space. That'll be less breakey, but may add spaces before the "----" in terminals. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no