From: "J.P." <jp@neverwas.me>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 49704@debbugs.gnu.org, emacs-erc@gnu.org
Subject: bug#49704: 28.0.50; erc-response object retained in text-props via erc-button
Date: Fri, 23 Jul 2021 06:14:20 -0700 [thread overview]
Message-ID: <87zgud895f.fsf__35407.9872997076$1627046124$gmane$org@neverwas.me> (raw)
In-Reply-To: <87mtqddzgt.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 23 Jul 2021 13:46:58 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I'm not quite sure I understand what problem the current text properties
> lead to? Is it saving memory-hungry closures in the text properties or
> something?
No, no closures, just strings containing the raw message and the various
message parts. So on average, not a huge deal, I guess, even for
channels with lots of links (for example, from a GitHub bot yapping
about every commit)?
> I had a look at the data in some buttons in an erc buffer, and nothing
> there really seems excessive?
Here's a recent example from #emacs.
Original message:
<Redacted> alice: check out the example in this page:
https://www.gnu.org/software/groff/manual/html_node/Line-Layout.html#Line-Layout
`erc-data' prop (edited):
(#("https://www.gnu.org/software/groff/manual/html_node/Line-Layout.html#Line-Layout" 0 80
(tags
((batch . "767fece2e664ff56f97eb768f7ddb5c7")
(time . "2021-07-21T09:04:51.884Z"))
rear-sticky t erc-parsed
#s(erc-response
"@batch=767fece2e664ff56f97eb768f7ddb5c7;time=2021-07-21T09:04:51.884Z "
":Redacted!viking@124.197.53.238 PRIVMSG #emacs :alice: check out the "
"example in this page: https://www.gnu.org/software/groff/manual/html_"
"node/Line-Layout.html#Line-Layout" "Redacted!viking@124.197.53.238" "PRIVMSG"
("#emacs" "alice: check out the example in this page: https://www.gnu.org"
"/software/groff/manual/html_node/Line-Layout.html#Line-Layout")
"alice: check out the example in this page: https://www.gnu.org/software"
"/groff/manual/html_node/Line-Layout.html#Line-Layout"
((batch . "767fece2e664ff56f97eb768f7ddb5c7")
(time . "2021-07-21T09:04:51.884Z")))
font-lock-face erc-default-face)))
So just the message text in a different form. If these aren't worth the
bean counting, that's good news. ERC will need to store increasingly
more data for *all* messages as it adapts to the evolving standard. It
already relies on text properties in part to do that, so it's good to
know that'll continue to be an option.
I suppose I got all worked up over nothing then. As usual, many thanks
and many more apologies. I leave you in peace (for now).
next prev parent reply other threads:[~2021-07-23 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 7:45 bug#49704: 28.0.50; erc-response object retained in text-props via erc-button J.P.
2021-07-23 11:46 ` Lars Ingebrigtsen
2021-07-23 13:14 ` J.P. [this message]
[not found] ` <87zgud895f.fsf@neverwas.me>
2021-07-23 13:16 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87zgud895f.fsf__35407.9872997076$1627046124$gmane$org@neverwas.me' \
--to=jp@neverwas.me \
--cc=49704@debbugs.gnu.org \
--cc=emacs-erc@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).