From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Newsgroups: gmane.emacs.bugs Subject: bug#30204: 27.0.50; Changing major mode resets non-default invisibility spec Date: Mon, 06 Sep 2021 12:22:17 +0200 Message-ID: <87zgsqknqe.fsf@miha-pc> References: <87lf55cxvj.fsf@gnus.org> <97574057-8212-4812-93CF-0C2EC7EA8B39@gmail.com> <87ilzfo13i.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30334"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 30204@debbugs.gnu.org To: Lars Ingebrigtsen , Philipp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 06 12:20:58 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNBkI-0007he-B7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Sep 2021 12:20:58 +0200 Original-Received: from localhost ([::1]:54636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNBkG-0001Er-Rb for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Sep 2021 06:20:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNBjO-0001Ef-Sj for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 06:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40471) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNBjO-0002PL-L8 for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 06:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNBjO-0008ND-BG for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 06:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Sep 2021 10:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30204 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 30204-submit@debbugs.gnu.org id=B30204.163092355832124 (code B ref 30204); Mon, 06 Sep 2021 10:20:02 +0000 Original-Received: (at 30204) by debbugs.gnu.org; 6 Sep 2021 10:19:18 +0000 Original-Received: from localhost ([127.0.0.1]:52017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNBig-0008M3-2v for submit@debbugs.gnu.org; Mon, 06 Sep 2021 06:19:18 -0400 Original-Received: from kamnitnik.top ([209.250.245.214]:60490 helo=mail.kamnitnik.top) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNBie-0008Lu-7S for 30204@debbugs.gnu.org; Mon, 06 Sep 2021 06:19:16 -0400 Original-Received: from localhost (unknown [IPv6:2a00:ee2:e04:9300:225:d3ff:fef9:f08a]) by mail.kamnitnik.top (Postfix) with ESMTPSA id 8B880BBB71; Mon, 6 Sep 2021 10:19:14 +0000 (UTC) In-Reply-To: <87ilzfo13i.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213579 Archived-At: Lars Ingebrigtsen writes: > Philipp writes: > >>> And I think this is correct behaviour -- if you've switched to >>> fundamental-mode, then you don't want these remnants from markdown-mode >>> to survive, I think? >> >> Yes, but they do survive, i.e. once markdown-mode has made some text >> conditionally-visible (which it does for URLs etc.), I'd expect it to >> become unconditionally-visible instead of unconditionally-invisible >> when changing the major mode. > > That's true. Hm... Should major modes remove `invisible' text > properties (where the value isn't t)? No, that wouldn't be right, > either. > > Uhm. OK, if `buffer-invisibility-spec' isn't t, > `kill-all-local-variables' could remove the `invisible' text property > from all text that has a non-t value? > > That sounds like it would potentially be expensive, but a non-nil > invisibility spec is quite unusual (and switching major modes, in > general, is unusual (well, switching from anything but fundamental-mode > is unusual)). > > I dunno. Anybody have an opinion here? markdown-mode should simply add `invisible' to font-lock-extra-managed-props. Font-lock will then automatically remove this property as well from the buffer in change-major-mode-hook. > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no