unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Manuel Giraud <manuel@ledu-giraud.fr>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 50572@debbugs.gnu.org, larsi@gnus.org, andrewjmoreton@gmail.com,
	dgutov@yandex.ru
Subject: bug#50572: 28.0.50; [PATCH] fix VC to find the responsible backend with the most specific path.
Date: Fri, 12 Nov 2021 20:21:33 +0100	[thread overview]
Message-ID: <87zgq9uqma.fsf@elite.giraud> (raw)
In-Reply-To: <83y25txuww.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Nov 2021 17:20:31 +0200")

[-- Attachment #1: Type: text/plain, Size: 23 bytes --]

Here is a new version.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Find-most-specific-backend-for-vc-backend-for-regist.patch --]
[-- Type: text/x-patch, Size: 1025 bytes --]

From 76e164e96552bbd8f1821dec03f0e0d35af457d7 Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Fri, 12 Nov 2021 17:13:51 +0100
Subject: [PATCH] Find most specific backend for `vc-backend-for-registration'.

---
 lisp/vc/vc.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
index 4b56f1b795..6f5839736a 100644
--- a/lisp/vc/vc.el
+++ b/lisp/vc/vc.el
@@ -944,8 +944,9 @@ vc-backend-for-registration
           bk)
       (dolist (backend vc-handled-backends)
         (when (not (vc-call-backend backend 'registered file))
-          (let* ((path (vc-call-backend backend 'responsible-p file))
-                 (len (length path)))
+          (let* ((dir-name (vc-call-backend backend 'responsible-p file))
+                 (len (and dir-name
+                           (length (file-name-split (expand-file-name dir-name))))))
             (when (and len (> len max))
               (setq max len bk backend)))))
       (when bk
-- 
2.33.1


[-- Attachment #3: Type: text/plain, Size: 18 bytes --]

-- 
Manuel Giraud

  parent reply	other threads:[~2021-11-12 19:21 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 15:47 bug#50572: 28.0.50; [PATCH] fix VC to find the responsible backend with the most specific path Manuel Giraud
2021-09-13 16:10 ` Eli Zaretskii
2021-09-13 23:48   ` Dmitry Gutov
2021-09-14  2:28     ` Eli Zaretskii
2021-09-14  7:57     ` Manuel Giraud
2021-09-14  7:50   ` Manuel Giraud
2021-09-14 11:38     ` Eli Zaretskii
2021-09-14 12:08       ` Manuel Giraud
2021-09-14 12:57         ` Eli Zaretskii
2021-09-14 15:15       ` Manuel Giraud
2021-09-14 16:03         ` Eli Zaretskii
2021-09-15  9:17           ` Manuel Giraud
2021-09-15 10:35           ` Dmitry Gutov
2021-09-15 11:20             ` Eli Zaretskii
2021-09-15 11:36               ` Dmitry Gutov
2021-09-15 10:41       ` Dmitry Gutov
2021-09-15 11:22         ` Eli Zaretskii
2021-09-15 11:37           ` Dmitry Gutov
2021-09-15 11:44             ` Eli Zaretskii
2021-09-15 11:47               ` Dmitry Gutov
2021-09-16 12:55                 ` Lars Ingebrigtsen
2021-11-06  0:16 ` Lars Ingebrigtsen
2021-11-06 15:01   ` Andy Moreton
2021-11-06 18:19     ` Lars Ingebrigtsen
2021-11-06 22:30       ` Andy Moreton
2021-11-06 22:35         ` Dmitry Gutov
2021-11-07 13:17           ` Lars Ingebrigtsen
2021-11-08  9:28             ` Manuel Giraud
2021-11-08  9:31               ` Lars Ingebrigtsen
2021-11-08 10:37                 ` Manuel Giraud
2021-11-09  3:29                   ` Lars Ingebrigtsen
2021-11-09  8:09                     ` Juri Linkov
2021-11-09 22:55                       ` Lars Ingebrigtsen
2021-11-09  8:51                     ` Manuel Giraud
2021-11-09 23:30                       ` Lars Ingebrigtsen
2021-11-10  0:06                         ` Dmitry Gutov
2021-11-10  0:20                           ` Lars Ingebrigtsen
2021-11-10  0:29                             ` Dmitry Gutov
2021-11-10  0:39                               ` Lars Ingebrigtsen
2021-11-10 12:54                                 ` Eli Zaretskii
2021-11-10 12:59                                   ` Lars Ingebrigtsen
2021-11-10 14:23                                     ` Eli Zaretskii
2021-11-11  2:56                                       ` Lars Ingebrigtsen
2021-11-11  7:06                                         ` Eli Zaretskii
2021-11-11  7:46                                           ` Michael Albinus
2021-11-11  8:04                                             ` Eli Zaretskii
2021-11-11 10:46                                               ` Michael Albinus
2021-11-11 12:21                                           ` Lars Ingebrigtsen
2021-11-11 15:09                                             ` Eli Zaretskii
2021-11-12  3:01                                               ` Lars Ingebrigtsen
2021-11-12  9:51                         ` Manuel Giraud
2021-11-12 12:05                           ` Eli Zaretskii
2021-11-12 15:09                             ` Manuel Giraud
2021-11-12 15:20                               ` Eli Zaretskii
2021-11-12 15:41                                 ` Manuel Giraud
2021-11-12 19:21                                 ` Manuel Giraud [this message]
2021-11-12 19:40                                   ` Eli Zaretskii
2021-11-14  0:51                                   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgq9uqma.fsf@elite.giraud \
    --to=manuel@ledu-giraud.fr \
    --cc=50572@debbugs.gnu.org \
    --cc=andrewjmoreton@gmail.com \
    --cc=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).