From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.bugs Subject: bug#52148: 29.0.50; [PATCH] Make `project-kill-buffers' display list of buffers to kill Date: Sat, 27 Nov 2021 22:46:31 +0100 Message-ID: <87zgppl1ag.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37054"; mail-complaints-to="usenet@ciao.gmane.io" To: 52148@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 27 22:47:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mr5XK-0009R1-Fy for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Nov 2021 22:47:10 +0100 Original-Received: from localhost ([::1]:40616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mr5XJ-0007TT-3T for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Nov 2021 16:47:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mr5XD-0007Si-7M for bug-gnu-emacs@gnu.org; Sat, 27 Nov 2021 16:47:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51300) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mr5XC-0006xp-Pc for bug-gnu-emacs@gnu.org; Sat, 27 Nov 2021 16:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mr5XC-0000d9-LG for bug-gnu-emacs@gnu.org; Sat, 27 Nov 2021 16:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Nov 2021 21:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52148 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16380496132406 (code B ref -1); Sat, 27 Nov 2021 21:47:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Nov 2021 21:46:53 +0000 Original-Received: from localhost ([127.0.0.1]:34613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mr5X2-0000cj-Mu for submit@debbugs.gnu.org; Sat, 27 Nov 2021 16:46:53 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:42274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mr5Wm-0000cJ-O7 for submit@debbugs.gnu.org; Sat, 27 Nov 2021 16:46:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mr5Wm-0007Qm-Gl for bug-gnu-emacs@gnu.org; Sat, 27 Nov 2021 16:46:36 -0500 Original-Received: from [2a00:1450:4864:20::332] (port=51952 helo=mail-wm1-x332.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mr5Wk-0006vE-5v for bug-gnu-emacs@gnu.org; Sat, 27 Nov 2021 16:46:36 -0500 Original-Received: by mail-wm1-x332.google.com with SMTP id 137so11236585wma.1 for ; Sat, 27 Nov 2021 13:46:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=Ik3EaavngfmOfL4eQd1ARCCLzBeQ1Rn5CTMgXoTxQoU=; b=WDMUjXz5meE7FEELLz5nwqEi6ZHz8g6j6qEEjtC48gk/sZGyM+RhE4CuEvPZNqCDgs Lm7dmZh7t6O7TELGHgPS30dNHfYjHQaXcBs/kG9n+SH/jfuzBw/Devwn9GI21tyybimJ Zde7WPXpherSqUbePsI6qjgqSMaQeRvYC2lek4xScmBOVaebxO3pll+Jbs40hmKiapK0 1DNNQWB2r5FRpnbpkVLso9v/7zgiu6KGWD7liWDF9brbTdeXGdj3LpPfI5tRrv4g5W+z xPr8y2GbbTCtPFJtajCw7PG0EpiODbduh4UKiZZARGzXzTium4me8/QqYZAumbrKlpn0 ns9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=Ik3EaavngfmOfL4eQd1ARCCLzBeQ1Rn5CTMgXoTxQoU=; b=5z6BugLA1GAQ9kQpd+1fzff2zOop80zn1Ec8DmLQ7NtrpIW+t9YOwfYf6Uz+l1juIt 6/ooQ6/7RP+GLcaJkil1CJLKPz7t5M7jOgvsWw6gZs+m6r3B7bmXs6kA7AI1lQrxYqQU +lVSBL4Yh820cDLbJTQwTENkPW9CpmDdWVG0vI/y5gw0lsGjAO9iEMvA2uXxD0vBQYgB 7DyVuTKLEu5w+FK8/fnGu3IzP41wAjZonPX6xMIdhk2JHKJ40+82ykV6FuNwGcwBeeBr 3rB6pZhbcp23d7oGGKZInW8rg1h7enbkwUttZ6R2r0+HJmFksOTUbrA5ne6NMEJX8kbe 3Otg== X-Gm-Message-State: AOAM531Ckc1dQKXXtKNuoshTgfdzAz5qv7Q94k5KdNmozej1GguTM5Cw lx8XbbcG+6q+80w1AzuHoxxMgzkcfio= X-Google-Smtp-Source: ABdhPJzE9yIjtM0lf6N2m8ok7axamIlLGtuWWMKjdzFkpogErKgJmBg2wJ6RS5nJZZ+OFTNlO3BWnw== X-Received: by 2002:a05:600c:190e:: with SMTP id j14mr24676697wmq.75.1638049592253; Sat, 27 Nov 2021 13:46:32 -0800 (PST) Original-Received: from carbon.localdomain ([2a01:e0a:245:c850:a5c0:9416:5835:2b57]) by smtp.gmail.com with ESMTPSA id w4sm10000855wrs.88.2021.11.27.13.46.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Nov 2021 13:46:31 -0800 (PST) X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::332 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=orontee@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220946 Archived-At: --=-=-= Content-Type: text/plain This is a feature request. I would find convenient and safer to list buffers to kill when `project-kill-buffers' is called. The attached patch is an attempt to implement this feature, inspired by what I read in `save-buffers-kill-emacs' implementation. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-project-kill-buffers-displays-list-of-buffers-to-kil.patch >From 2041a621ba5be0c4b2f563a554263b37d4192ce2 Mon Sep 17 00:00:00 2001 From: Matthias Meulen Date: Sat, 27 Nov 2021 22:43:20 +0100 Subject: [PATCH] `project-kill-buffers` displays list of buffers to kill * lisp/progmodes/project.el (project-kill-buffers): Temporarily display list of buffers to kill --- lisp/progmodes/project.el | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index ed076a683d..0d8ed3646a 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1281,9 +1281,26 @@ project-kill-buffers (mapc #'kill-buffer bufs)) ((null bufs) (message "No buffers to kill")) - ((yes-or-no-p (format "Kill %d buffers in %s? " - (length bufs) - (project-root pr))) + ((with-current-buffer-window + (get-buffer-create "*Buffer List*") + `(display-buffer--maybe-at-bottom + (dedicated . t) + (window-height . (fit-window-to-buffer)) + (preserve-size . (nil . t)) + (body-function + . ,#'(lambda (_window) + (list-buffers-noselect nil bufs)))) + #'(lambda (window _value) + (with-selected-window window + (unwind-protect + (progn + (setq confirm nil) + (yes-or-no-p + (format "Kill %d buffers in %s? " + (length bufs) + (project-root pr)))) + (when (window-live-p window) + (quit-restore-window window 'kill)))))) (mapc #'kill-buffer bufs))))) -- 2.30.2 --=-=-= Content-Type: text/plain In GNU Emacs 29.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2021-11-27 built on carbon Repository revision: 338f7802373f1cfcc1b3749bbd46091fdef727f4 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure --with-native-compilation' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LANG: fr_FR.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Shell Minor modes in effect: highlight-changes-visible-mode: t goto-address-mode: t shell-dirtrack-mode: t minions-mode: t global-company-mode: t company-mode: t desktop-save-mode: t save-place-mode: t electric-pair-mode: t icomplete-mode: t global-so-long-mode: t global-auto-revert-mode: t auto-insert-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-layout-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t context-menu-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t window-divider-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: /home/matthias/.config/emacs/elpa/transient-20211105.100/transient hides /usr/local/share/emacs/29.0.50/lisp/transient /home/matthias/.config/emacs/elpa/dictionary-20201001.1727/dictionary hides /usr/local/share/emacs/29.0.50/lisp/net/dictionary Features: (shadow sort mail-extr gnus-msg emacsbug sendmail log-edit pcvs-util smerge-mode diff whitespace cl-print mule-diag hl-line dabbrev misearch multi-isearch pulse reftex-dcr reftex reftex-loaddefs reftex-vars tex-mode mule-util shortdoc help-fns radix-tree add-log checkdoc lisp-mnt url-http url-auth url-gw nsm mhtml-mode css-mode smie sgml-mode typescript-mode yaml-mode hideshow cap-words superword subword js python tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat ls-lisp follow view enriched disp-table facemenu dired-aux bug-reference display-line-numbers hilit-chg vc-dir reveal flyspell ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar org-agenda ox-html table ox-ascii ox-publish ox goto-addr org-element avl-tree ol-eww eww xdg url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-search eieio-opt speedbar ezimage dframe gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr kinsoku svg dom ol-docview doc-view jka-compr image-mode exif ol-bibtex ol-bbdb ol-w3m ol-doi org-link-doi vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc bash-completion shell eglot array jsonrpc ert ewoc debug backtrace flymake-proc flymake compile imenu company-oddmuse company-keywords company-etags etags fileloop generator xref project company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb avoid minions company pcase carbon-custom cus-edit cus-load gnus-demon nntp gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 netrc parse-time gnus-spec gnus-win nnoo gnus-int gnus-range message yank-media rmc puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mail-utils mm-util mail-prsvr wid-edit gnus-dired dired-x dired dired-loaddefs org-capture org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-color ring org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex iso8601 time-date ol org-keys oc org-compat org-macs org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs dictionary link connection advice markdown-mode edit-indirect color thingatpt noutline outline skeleton find-file vc-git diff-mode easy-mmode vc-dispatcher ispell comp comp-cstr warnings rx cl-extra help-mode desktop frameset server bookmark text-property-search pp saveplace elec-pair icomplete so-long autorevert filenotify autoinsert cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs generic-x face-remap proof-site proof-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars seq gv subr-x byte-opt bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 685836 76682) (symbols 48 40552 1) (strings 32 162716 13581) (string-bytes 1 5304884) (vectors 16 76386) (vector-slots 8 1642333 90680) (floats 8 721 1258) (intervals 56 23699 2008) (buffers 992 143)) --=-=-=--