From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc. Date: Sat, 08 Jan 2022 20:35:36 +0100 Message-ID: <87zgo6owaf.fsf@gmail.com> References: <87sftyweb2.fsf@gmail.com> <861r1iyrvw.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27100"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.90 (gnu/linux) Cc: 53126@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 08 20:37:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n6HWg-0006rM-TC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Jan 2022 20:37:18 +0100 Original-Received: from localhost ([::1]:45306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6HWe-000781-S1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Jan 2022 14:37:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6HVT-0006Qq-Ii for bug-gnu-emacs@gnu.org; Sat, 08 Jan 2022 14:36:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55835) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n6HVS-0007Tg-GO for bug-gnu-emacs@gnu.org; Sat, 08 Jan 2022 14:36:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n6HVS-0003Qo-9R for bug-gnu-emacs@gnu.org; Sat, 08 Jan 2022 14:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jan 2022 19:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53126-submit@debbugs.gnu.org id=B53126.164167054813164 (code B ref 53126); Sat, 08 Jan 2022 19:36:02 +0000 Original-Received: (at 53126) by debbugs.gnu.org; 8 Jan 2022 19:35:48 +0000 Original-Received: from localhost ([127.0.0.1]:48738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6HVD-0003QG-K9 for submit@debbugs.gnu.org; Sat, 08 Jan 2022 14:35:47 -0500 Original-Received: from mail-wm1-f41.google.com ([209.85.128.41]:54937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6HVB-0003Q2-4f for 53126@debbugs.gnu.org; Sat, 08 Jan 2022 14:35:46 -0500 Original-Received: by mail-wm1-f41.google.com with SMTP id o30so6159363wms.4 for <53126@debbugs.gnu.org>; Sat, 08 Jan 2022 11:35:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uaFdM9GK9mFThXF458EmwUwxMBv5A1iBXXFs/RMmQGI=; b=JjEV2dJsDq9LCRftjphE2m1bwrOpzB4f+n7Z14f35n4xgDIHH4gSMSfJq/KoT6WyjL Rdgwe0k1mFZX8h04v+S1ndQxDSyQoyiTRcoTfUgHTByQWpoZPHFfeRMBOlrET0r2QjTV ju/pN4/5P8jVAPHfi5Eajgsnuh8ndnULHG0uXSI6k7ziZGOawj3rzbGTpxWyTcMeS/AS siLUhS9Sq/GAxCNOpK8i/FXIgVj7UPuihzPncgR70xdup/tujvFD3r+qBlJcGLavOZ53 OqSdKKG5fJArat/N0N5jTsCBlewgGgcTsbNE/OnJcnKpXRdcpSB0MNBHanINAQ+aJyEU yJwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uaFdM9GK9mFThXF458EmwUwxMBv5A1iBXXFs/RMmQGI=; b=Y5LXePkCz/W7nGd3WuL05wS5cmFQ+mS/wrcG5AEi9LSmXQUxTT/5GTtp7X5tMRL/3Q oQz3UXcEkhavP/pMFoqHKNMl9GX+/uG350ZWu/9uSLFP8Ir2Ty/qL3u4A9AXy0r94Hjn xLvH7dsrXH+2mRt4slwYfyGVP2ZB+8BM7PselCfegt4lx7mOtoJnfVW9jmvE1OlBkEuq TDXB5Ws9xPYmcLhqVgQ7urDSLTsuT1pH8A9E8jIckb7YjG4/GwJTDjly1dUTdzg9565g IFjOTrB/FkA0tGWvpWxJ6K3QYuuNRXh+3e4CqBl8ZNI9gSd+F58Mg3k6ilD9KoRHEO+O aQUw== X-Gm-Message-State: AOAM533gscDtbMf+5ZDlpdaA+3UfVI8uFMRHKQ9JTfWVTxekzSMzw4pk OXdoVe3SfjrjyfQrwz9etAn2vL6rN+o= X-Google-Smtp-Source: ABdhPJwSp0nqUfLyX1/18IEtB5/hB0Nmz+AbulT0dk4wEo1PL0b7zruH0D71BaIElfpU2uKHXCh+XA== X-Received: by 2002:a1c:e909:: with SMTP id q9mr15344151wmc.184.1641670538936; Sat, 08 Jan 2022 11:35:38 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::b4b9]) by smtp.gmail.com with ESMTPSA id m39sm2021535wms.33.2022.01.08.11.35.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jan 2022 11:35:38 -0800 (PST) In-Reply-To: <861r1iyrvw.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 08 Jan 2022 20:59:45 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223824 Archived-At: On Sat, 8 Jan 2022 at 20:59, Juri Linkov wrote: > Strange, I expected that the lazy-count feature applied to query-replace > should do a different thing - when querying about replacing the current match, > it should show the number of current match and the number of total matches. > The latter number should be updated after every replacement. > That would be handy too. I haven't checked how the `perform-replace' loop works, but wouldn't this require a hook into the lazy count procedure --- precisely what my patch introduces through the new variable `isearch-lazy-count-display-function'? > But your patches are intended for a different feature - highlighting > of matches in the buffer while entering an input string in the minibuffer. > > I wonder how many users need this feature, when it's easy to construct > a query-replace string using highlighting/counting in isearch-mode, > then type M-% > (isearch-query-replace) that invokes query-replace with the > query-replace string. > Sure, this alternative method works. But somehow it's not the way I usually start a replace, and I think there's nothing wrong with that preference :-) > Perhaps better to ask on emacs-devel if anyone needs this feature. We can ask. But note that the bulk of the patch has a fairly general purpose, namely to read a regexp with live preview of the matches. There's probably a couple extra uses for this.