From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#53255: highlight-regexp should show faces with their properties applied when selecting a face Date: Sat, 15 Jan 2022 11:05:20 +0100 Message-ID: <87zgnxnwkf.fsf@gmail.com> References: <87y23hl729.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20192"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: ndame , 53255@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 15 11:06:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8fx9-00051Q-SS for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jan 2022 11:06:31 +0100 Original-Received: from localhost ([::1]:39730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8fx8-0007FD-PM for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jan 2022 05:06:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8fws-00076l-CI for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 05:06:15 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8fwg-0000dG-4j for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 05:06:13 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8fwg-000511-0v for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 05:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jan 2022 10:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53255 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 53255-submit@debbugs.gnu.org id=B53255.164224112919234 (code B ref 53255); Sat, 15 Jan 2022 10:06:01 +0000 Original-Received: (at 53255) by debbugs.gnu.org; 15 Jan 2022 10:05:29 +0000 Original-Received: from localhost ([127.0.0.1]:39111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8fw9-00050A-EJ for submit@debbugs.gnu.org; Sat, 15 Jan 2022 05:05:29 -0500 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:37588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8fw7-0004zu-Fr for 53255@debbugs.gnu.org; Sat, 15 Jan 2022 05:05:28 -0500 Original-Received: by mail-wm1-f53.google.com with SMTP id l12-20020a7bc34c000000b003467c58cbdfso12069815wmj.2 for <53255@debbugs.gnu.org>; Sat, 15 Jan 2022 02:05:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qQFWUbmXCfrOQskqKEG/4CmeA9hzrId6sc+xMe3ugfo=; b=gYmFQ2Gn9Nu3iYyCGt8Gk165aE6YRxjjeuFmAWzGshVkeWhI3eSLKHb1IPiBlUAOFv VqPiRnMmwRnYF6AAZnIhmcMqdqYusL2eWzRQB17vdbvwToVBqqtZES0K4akmIQ5xUF2K 50ztvf33JJwep71UEoIl1GVDAuQSw2c2g1JKI+SIN76OKK+sule4d4DnSJCjSSMespGB VXPzup7/eVIpm69O1apKcszkK3aaME4YGbwrpqX7byzdn9k7UyY4kwYRD5ptEHFYDV7Z NsWHsOLnbBjPCokvST/39EdQybNb6JoNS0H4dxjZewDlY5mFCMcYL3p1xfReijrvmRue ejaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qQFWUbmXCfrOQskqKEG/4CmeA9hzrId6sc+xMe3ugfo=; b=VG0vvXWN5/Clp2Xoz8s/aF0ZCKSbjHz/aTMdu+Gvudq7Z7a46klNQCISJigR4Fod+P IQihnr1uKH7yRIomOkc9K1i0lEDSRZAOeysoBI6GqUdtNMDkvMocu3GL7kklo8WsMgC/ F2ZLTeGTACdjGJHVrMeR5AAP3WV3kUs+sD2kuhYG2IIdvKRy7IYrRVQ8nbIxo8si0B+L Ax370XuJnLMZ+QDG5qd9S+6Ru6gkW0/7qU9VdpXxfd0ngBhQae6EOfEh4iqNJmHdwvnP 10ZYdwPsZVlC2UrHZGMmdFu4gyoOaFNGRULjjaw4BBx5VBNki9S6KCzGY3896mVVNUTR ZHuw== X-Gm-Message-State: AOAM5331GFQuh4a3bFSY1eYFde8KfWATFOmBm2GftlOTsndiRCGMw0Pm FoQu8YqPbCQod1QilSLiWmierznMAdo= X-Google-Smtp-Source: ABdhPJxv/Lwd/nTT11IRSR3FboPcPcKFPEA4i6BrO9VEBpCSGLbPsBzaABMlifCdMttABnK8swbl+Q== X-Received: by 2002:a05:600c:2481:: with SMTP id 1mr1912744wms.3.1642241121473; Sat, 15 Jan 2022 02:05:21 -0800 (PST) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id b15sm4535174wrr.50.2022.01.15.02.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jan 2022 02:05:21 -0800 (PST) In-Reply-To: <87y23hl729.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 15 Jan 2022 09:46:54 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224274 Archived-At: Lars Ingebrigtsen writes: > The patch below implements this, but it does lead to some strange > effects: > > That is, some faces have odd sizes, so the completion display may look a > bit odd. In addition to the odd sizes, some face names become completely unreadable (e.g. the ansi-color-* ones). > But it does accurately tell you what the result is doing to be, so > perhaps it's OK? Anybody have any opinions? Maybe using an affixation function (like read-char-by-name) would make things less jarring? E.g. fontifying the same string for every face (say "x" or "example") and using that as suffix (rather than prefix, to keep the face names aligned)? At any rate, I do think that showing the actual sizes (and colors, however unreadable) is a good feature to keep.