unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: ndame <laszlomail@protonmail.com>, 53255@debbugs.gnu.org
Subject: bug#53255: highlight-regexp should show faces with their properties applied when selecting a face
Date: Sat, 15 Jan 2022 11:05:20 +0100	[thread overview]
Message-ID: <87zgnxnwkf.fsf@gmail.com> (raw)
In-Reply-To: <87y23hl729.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 15 Jan 2022 09:46:54 +0100")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> The patch below implements this, but it does lead to some strange
> effects:
>
> That is, some faces have odd sizes, so the completion display may look a
> bit odd.

In addition to the odd sizes, some face names become completely
unreadable (e.g. the ansi-color-* ones).

> But it does accurately tell you what the result is doing to be, so
> perhaps it's OK?  Anybody have any opinions?

Maybe using an affixation function (like read-char-by-name) would make
things less jarring?  E.g. fontifying the same string for every face
(say "x" or "example") and using that as suffix (rather than prefix, to
keep the face names aligned)?

At any rate, I do think that showing the actual sizes (and colors,
however unreadable) is a good feature to keep.





  reply	other threads:[~2022-01-15 10:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14 13:37 bug#53255: highlight-regexp should show faces with their properties applied when selecting a face ndame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-15  8:46 ` Lars Ingebrigtsen
2022-01-15 10:05   ` Kévin Le Gouguec [this message]
2022-01-15 10:11     ` Lars Ingebrigtsen
2022-01-15 11:36       ` Kévin Le Gouguec
2022-01-15 19:14         ` Juri Linkov
2022-01-15 22:48         ` bug#53255: [External] : " Drew Adams
2022-01-20 13:23         ` Lars Ingebrigtsen
2022-01-20 22:58           ` Kévin Le Gouguec
2022-01-21  6:32             ` Kévin Le Gouguec
2022-01-21  9:30             ` Lars Ingebrigtsen
2022-01-21 13:39               ` Kévin Le Gouguec
2022-01-22 11:36                 ` Lars Ingebrigtsen
2022-01-21 17:06               ` bug#53255: [External] : " Drew Adams
2022-01-22 18:51           ` Juri Linkov
2022-01-23 12:38             ` Lars Ingebrigtsen
2022-01-23 18:45               ` Juri Linkov
2022-01-24  9:22                 ` Lars Ingebrigtsen
2022-01-15 22:40       ` bug#53255: [External] : " Drew Adams
2022-01-15 22:31     ` Drew Adams
2022-01-15 19:12   ` Juri Linkov
2022-01-16 18:20     ` Juri Linkov
2022-01-15 21:46   ` bug#53255: [External] : " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgnxnwkf.fsf@gmail.com \
    --to=kevin.legouguec@gmail.com \
    --cc=53255@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=laszlomail@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).