From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#53276: The blink-cursor-mode not work after startup on macOS Date: Sat, 15 Jan 2022 21:11:30 +0800 Message-ID: <87zgnx9m9p.fsf@yahoo.com> References: <871r19eayk.fsf@yahoo.com> <877db1b13x.fsf@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6812"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: Eason Huang , 53276@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 15 14:13:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8iru-0001du-PN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jan 2022 14:13:18 +0100 Original-Received: from localhost ([::1]:54268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8irt-00013J-Q1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jan 2022 08:13:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8iqh-000106-C6 for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 08:12:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8iqh-0000ky-2X for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 08:12:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8iqg-0004hM-Uh for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 08:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jan 2022 13:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53276 X-GNU-PR-Package: emacs Original-Received: via spool by 53276-submit@debbugs.gnu.org id=B53276.164225231018031 (code B ref 53276); Sat, 15 Jan 2022 13:12:02 +0000 Original-Received: (at 53276) by debbugs.gnu.org; 15 Jan 2022 13:11:50 +0000 Original-Received: from localhost ([127.0.0.1]:39413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8iqU-0004gl-Ff for submit@debbugs.gnu.org; Sat, 15 Jan 2022 08:11:50 -0500 Original-Received: from sonic303-21.consmr.mail.ne1.yahoo.com ([66.163.188.147]:35192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8iqR-0004gV-SH for 53276@debbugs.gnu.org; Sat, 15 Jan 2022 08:11:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1642252301; bh=QO6QAT2CayMx8fhZj0eI+/WXqZvMnWQfSDckcvVcekY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=op++DbONidM0eykW8IOocUEXd6shiAWYnkpL3WAzqga8DZBdlH8XrO1nufv+PthNVKRSxwTBLbNOyTNcBi+sbCuTISCCxGGDc7luaYypH5jYby1koPAiyl36nk4E559TYESV8gQNA+8BjFiCNNmjNJyDAc9rKf4yL4GypQlfcIz433gf0eebA3TR/3/5JhKH0rSHxDFomtU5c5gvXZgRrO/PHLLZLNYv+jVutsl9Ud+sAj2RUEv3mQ5Twn+thj+lqRMxw3LUB7xbyPjIFfolg1+9RbqTv1esUkMyWPbR8aYVjCepmIiBzcxGOmobMp3SkvGnFY95qr9mw9ENfait5Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1642252301; bh=vIZzRBV/s/bnINx3lVM+z5tYIcIrGd0VefvMPTqnCqe=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=V5ThCwh4+9jlJDUjtmKy2yUNobDXlOv/CgzOZRK/cVgq4TMAC8ayue0dWbbuVeZaY8r5GIuCUz8+a43RU4LlyoOaOwgkFpKOk33kwD11FtgIat5O8ZgB+BM8vxT8dnaF8llEojenxShwP2YZdItkd3FZS9PdSsEhLAv+AYrioJ9fG+JBlnLLr12Jm1QUrL9NpLYyPZbAzxynCBskllory7EYTUriahNnWHCC0bAywHHi8lLf008MRXDbU846HAtD9Bwe6sbkSpqJ4xmwpE9ejMs6iMsjwoZLWmF3D1ODnYq5Pi9yD2icggarpEDCG46Oc934dC5WOrjrrKaJJI9g3Q== X-YMail-OSG: 6iJzfp0VM1noCpfeePeM4PT0uTZkaBWMrHkafebQMsqJ.c6uEUyXvPtQ2TonHDN xVfCtXlk7r_I0BCJu_yWUTOH0K9Fu0n1qZIfDmxRZlGl67sTttwDZckU_0vLkRReE97zmfIleIMj jEiobP8muxmgCdKiYEEYbkV57huL6kOrNAQcdw5AuLmnomSr6WsoRxCZnq9Qg0js.5.BhMzZy7ON EyFtXfokfHDS4_20vHwPlHt7mVjCGB2RMz9GD7LkSp0rlfDEHz54Y1uiULVmqh2CMD7K3VKcRqxi RsHKm5XozHSxn46M5EeByNkAYsWC2tAjyxTHxvUaRjMlROflB9PVj19ileeu76cbl7iiT5GJXKQV ZULxA.IjMkG7XW7SAQRqZa.VaZnGOZP48K31XM.jOKfpN3wucIp9AezLjPEk07MAZpq1o4Gs7X2S s76JbLO8jgtzyuvdq5l_R_oVA6vasrFZZSrcSxJInNhaaope20hbqXfx4BxbbEcNj07uLgiFRz5l G67GqxE_7yYG9U4xuhUIvtXzeNYbJEsf584L_rHmMCRAsJBTQnbLB8TgVLhrfqZkXrLbsA1uxAkk jSoQk2xwATBfSLCw9MZoxGFld_tl4LKloql3SeQzrpZl1rpSpl1bSAR9LZxa68r5THIWyZ27YERQ ZfNqV96pSs.vh5b2.KWaEcprtht8bCf3TBWLZ_1ebmYJTv.cixSz5gZXnGPg_IbqJu.0b.hAc2Xm SZxlXEuuzw85QGkx6ZZbwvm1bdVueLrjbQywt2P0twX.qEvW0oN4adn1hVa9797laZCBn9pXg3tS Y3ZlbEu6e_FOfxqX87Lb7qLFTcTj_fGu.RjqUEfy6f X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Sat, 15 Jan 2022 13:11:41 +0000 Original-Received: by kubenode514.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 53e9b438a9ec3ad6e466d3448f15d89f; Sat, 15 Jan 2022 13:11:36 +0000 (UTC) In-Reply-To: <877db1b13x.fsf@yahoo.com> (Po Lu's message of "Sat, 15 Jan 2022 21:05:38 +0800") X-Mailer: WebService/1.1.19594 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224306 Archived-At: Po Lu writes: > I think the right solution is to store events directly into the keyboard > buffer instead of using emacs_event, but I don't know if there's a > reason the NS port was not developed that way. If you don't know the answer, I think we should install the following version of `windowDidBecomeKey' in master and see if anyone complains: - (void)windowDidBecomeKey /* for direct calls */ { struct ns_display_info *dpyinfo = FRAME_DISPLAY_INFO (emacsframe); struct frame *old_focus = dpyinfo->ns_focus_frame; struct input_event event; EVENT_INIT (event); NSTRACE ("[EmacsView windowDidBecomeKey]"); if (emacsframe != old_focus) dpyinfo->ns_focus_frame = emacsframe; ns_frame_rehighlight (emacsframe); event.kind = FOCUS_IN_EVENT; XSETFRAME (event.frame_or_window, emacsframe); kbd_buffer_store_event (&event); } And if nobody complains in a year, convert the rest of the places where emacs_event is used to do this as well. WDYT?