From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: Eason Huang <aqua0210@foxmail.com>, 53276@debbugs.gnu.org
Subject: bug#53276: The blink-cursor-mode not work after startup on macOS
Date: Sat, 15 Jan 2022 21:11:30 +0800 [thread overview]
Message-ID: <87zgnx9m9p.fsf@yahoo.com> (raw)
In-Reply-To: <877db1b13x.fsf@yahoo.com> (Po Lu's message of "Sat, 15 Jan 2022 21:05:38 +0800")
Po Lu <luangruo@yahoo.com> writes:
> I think the right solution is to store events directly into the keyboard
> buffer instead of using emacs_event, but I don't know if there's a
> reason the NS port was not developed that way.
If you don't know the answer, I think we should install the following
version of `windowDidBecomeKey' in master and see if anyone complains:
- (void)windowDidBecomeKey /* for direct calls */
{
struct ns_display_info *dpyinfo = FRAME_DISPLAY_INFO (emacsframe);
struct frame *old_focus = dpyinfo->ns_focus_frame;
struct input_event event;
EVENT_INIT (event);
NSTRACE ("[EmacsView windowDidBecomeKey]");
if (emacsframe != old_focus)
dpyinfo->ns_focus_frame = emacsframe;
ns_frame_rehighlight (emacsframe);
event.kind = FOCUS_IN_EVENT;
XSETFRAME (event.frame_or_window, emacsframe);
kbd_buffer_store_event (&event);
}
And if nobody complains in a year, convert the rest of the places where
emacs_event is used to do this as well.
WDYT?
next prev parent reply other threads:[~2022-01-15 13:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-15 4:41 bug#53276: The blink-cursor-mode not work after startup on macOS Eason Huang
2022-01-15 7:04 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-15 12:34 ` Alan Third
2022-01-15 13:05 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-15 13:11 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-01-21 1:19 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-21 11:38 ` Eason Huang
2022-01-21 11:41 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-27 15:06 ` Robert Pluim
2022-01-27 16:43 ` Eli Zaretskii
2022-01-27 17:02 ` Robert Pluim
2022-01-27 17:07 ` Eli Zaretskii
2022-01-27 17:15 ` Robert Pluim
2022-01-28 0:38 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgnx9m9p.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=53276@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=aqua0210@foxmail.com \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).