From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#53255: highlight-regexp should show faces with their properties applied when selecting a face Date: Fri, 21 Jan 2022 10:30:50 +0100 Message-ID: <87zgnpv3jp.fsf@gnus.org> References: <87y23hl729.fsf@gnus.org> <87zgnxnwkf.fsf@gmail.com> <877db1wboq.fsf@gnus.org> <87v8ylnsc1.fsf@gmail.com> <875yqe1qxl.fsf@gnus.org> <87lezadnfg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11291"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: ndame , 53255@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 21 10:49:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAqXx-0002jb-FI for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jan 2022 10:49:29 +0100 Original-Received: from localhost ([::1]:34194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAqXw-0001t7-Ej for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jan 2022 04:49:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAqH6-0007Yh-7U for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 04:32:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39045) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAqH4-0003qf-A2 for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 04:32:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nAqH4-0001eA-68 for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 04:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jan 2022 09:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53255 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 53255-submit@debbugs.gnu.org id=B53255.16427574626244 (code B ref 53255); Fri, 21 Jan 2022 09:32:02 +0000 Original-Received: (at 53255) by debbugs.gnu.org; 21 Jan 2022 09:31:02 +0000 Original-Received: from localhost ([127.0.0.1]:60181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAqG5-0001cZ-9M for submit@debbugs.gnu.org; Fri, 21 Jan 2022 04:31:01 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:60286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAqG3-0001cK-IX for 53255@debbugs.gnu.org; Fri, 21 Jan 2022 04:31:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PZGHvTlhic5IhPTgncOc0Ixg2SrDHecNdbV11e4BA8Y=; b=bm9QxsvK4ivGgchbN1f6wiPzMl 7nqUhU4o8MyU8nxkRSn/onr/fryhcGrcmCzGHz8wUbL5AQUbeDdUOZd8Ruoqp3EEXbAt4wlaA96bA ZfkoP2VFypDaGIEHnvK53mdIBb9WbLwKGVfbfUiMB4wBnTfkaf9O85UwGu+2SO2Eu22A=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAqFu-0008JF-Rw; Fri, 21 Jan 2022 10:30:53 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEU8WyYdI11fMxOU aUK4r7QZEQ6UWRHjpiX///93nAk3AAAAAWJLR0QIht6VegAAAAd0SU1FB+YBFQkLOnxH59QAAAGC SURBVDjLdZPBboMwDIZRpd3LpD5AjWLuhG4PUJ4gUsp5mUjuSCWvP9tQkYTuPwDKx287sVNV/6p+ pw0ASWvd3+/NqTPmqvVZwCeDnoAetO4sNHW9g4YdAwHdwfUFLhsYhk4zuSYO/NW6uvcnQO8gAeiD 1h99BT7EJQfeKWuV8b4AMTCwFjPHhUBcrKh0LF6t4FGA2W4yBVAvYEMOZA2AHmMCalmxY4xkNBmQ SFN4Sl0pmHhFtWsJaQ4n9ZCmN+BxBDX43UEt2B0YODsDZbMNeqlnBaPLAAf/JmANdinASJW2csTZ kVB7ZslOEdsMYJilSyWAFdhwI5oClBy0xakA1Fr6l7If+yFg5IcvAI3s2vOvAiwKGj4XUzpmmlLu H2bAUShAHjnj8ACAGwze+PysbjIQNPYTZo5F/reAoBCT5O1iNqDSKSEQrYyOQvfIkrdRuXV/rs2r ogsGRlkKmF81T1fKO0THH6nDs6hWYP4GAMgr7XkicD9pDieRVu0jetS5+gOKr92CeTbTtgAAACV0 RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wMS0yMVQwOToxMTo1OCswMDowMF2s0GkAAAAldEVYdGRhdGU6 bW9kaWZ5ADIwMjItMDEtMjFUMDk6MTE6NTgrMDA6MDAs8WjVAAAAAElFTkSuQmCC X-Now-Playing: Brian Auger & Julie Driscoll's _Open_: "Goodbye Jungle Telegraph" In-Reply-To: <87lezadnfg.fsf@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Thu, 20 Jan 2022 23:58:43 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224731 Archived-At: K=C3=A9vin Le Gouguec writes: > Great! A couple of nits: > > 1. Is there a reason why you went with (list "SAMPLE\t" "" face) instead > of (list face "" \tSAMPLE)? "(elisp) Completion Variables" says that > the completion goes first, then the prefix, then the suffix; I don't > know how hard a rule that is, however I do think the latter option > fares better when faced with variable heights. It looked really bad with the face names first, since they have wildly differing lengths. > 2. As you can see on the screenshots, the prompt shows the default face > twice. I think fixing this is as simple as removing format-prompt > (patch also attached), but then again, I'm not thinking straight this > evening it seems. (hi-lock-read-face-name) doesn't seem to display the default twice in an emacs -Q? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no