From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: ndame <laszlomail@protonmail.com>, 53255@debbugs.gnu.org
Subject: bug#53255: highlight-regexp should show faces with their properties applied when selecting a face
Date: Fri, 21 Jan 2022 10:30:50 +0100 [thread overview]
Message-ID: <87zgnpv3jp.fsf@gnus.org> (raw)
In-Reply-To: <87lezadnfg.fsf@gmail.com> ("Kévin Le Gouguec"'s message of "Thu, 20 Jan 2022 23:58:43 +0100")
Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
> Great! A couple of nits:
>
> 1. Is there a reason why you went with (list "SAMPLE\t" "" face) instead
> of (list face "" \tSAMPLE)? "(elisp) Completion Variables" says that
> the completion goes first, then the prefix, then the suffix; I don't
> know how hard a rule that is, however I do think the latter option
> fares better when faced with variable heights.
It looked really bad with the face names first, since they have wildly
differing lengths.
> 2. As you can see on the screenshots, the prompt shows the default face
> twice. I think fixing this is as simple as removing format-prompt
> (patch also attached), but then again, I'm not thinking straight this
> evening it seems.
(hi-lock-read-face-name) doesn't seem to display the default twice in an
emacs -Q?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-01-21 9:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 13:37 bug#53255: highlight-regexp should show faces with their properties applied when selecting a face ndame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-15 8:46 ` Lars Ingebrigtsen
2022-01-15 10:05 ` Kévin Le Gouguec
2022-01-15 10:11 ` Lars Ingebrigtsen
2022-01-15 11:36 ` Kévin Le Gouguec
2022-01-15 19:14 ` Juri Linkov
2022-01-15 22:48 ` bug#53255: [External] : " Drew Adams
2022-01-20 13:23 ` Lars Ingebrigtsen
2022-01-20 22:58 ` Kévin Le Gouguec
2022-01-21 6:32 ` Kévin Le Gouguec
2022-01-21 9:30 ` Lars Ingebrigtsen [this message]
2022-01-21 13:39 ` Kévin Le Gouguec
2022-01-22 11:36 ` Lars Ingebrigtsen
2022-01-21 17:06 ` bug#53255: [External] : " Drew Adams
2022-01-22 18:51 ` Juri Linkov
2022-01-23 12:38 ` Lars Ingebrigtsen
2022-01-23 18:45 ` Juri Linkov
2022-01-24 9:22 ` Lars Ingebrigtsen
2022-01-15 22:40 ` bug#53255: [External] : " Drew Adams
2022-01-15 22:31 ` Drew Adams
2022-01-15 19:12 ` Juri Linkov
2022-01-16 18:20 ` Juri Linkov
2022-01-15 21:46 ` bug#53255: [External] : " Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgnpv3jp.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=53255@debbugs.gnu.org \
--cc=kevin.legouguec@gmail.com \
--cc=laszlomail@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).