From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Francesco =?UTF-8?Q?Potort=C3=AC?= Newsgroups: gmane.emacs.bugs Subject: bug#53764: 27.1; shouldn't ~/diary be in diary-mode? Date: Wed, 09 Feb 2022 19:21:03 +0100 Organization: The GNU project Message-ID: <87zgmzaokw.fsf@tucano.isti.cnr.it> References: <87h79f8urg.fsf@tucano.isti.cnr.it> <87v8xtdcr4.fsf@gnus.org> <878rupbbll.fsf@tucano.isti.cnr.it> <87k0e9asjk.fsf@gnus.org> <877da8c3jn.fsf@tucano.isti.cnr.it> <8735kv61c1.fsf@gnus.org> <875ypravpv.fsf@tucano.isti.cnr.it> <87mtj3vxeg.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4498"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53764@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 09 19:52:00 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHs4M-0000o7-7B for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Feb 2022 19:51:58 +0100 Original-Received: from localhost ([::1]:33934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHs4L-0007zV-8J for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Feb 2022 13:51:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHrbO-0000hi-Fm for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 13:22:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58703) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHrbO-0000Cs-4h for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 13:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHrbO-0003a8-2A for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 13:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Francesco =?UTF-8?Q?Potort=C3=AC?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Feb 2022 18:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 53764-submit@debbugs.gnu.org id=B53764.164443087013674 (code B ref 53764); Wed, 09 Feb 2022 18:22:02 +0000 Original-Received: (at 53764) by debbugs.gnu.org; 9 Feb 2022 18:21:10 +0000 Original-Received: from localhost ([127.0.0.1]:52596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHraY-0003YU-8D for submit@debbugs.gnu.org; Wed, 09 Feb 2022 13:21:10 -0500 Original-Received: from plesklin7.if1.ehiweb.it ([79.98.45.16]:40912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHraV-0003YI-Sz for 53764@debbugs.gnu.org; Wed, 09 Feb 2022 13:21:08 -0500 Original-Received: from tucano.isti.cnr.it (tucano.isti.cnr.it [146.48.81.102]) by plesklin7.if1.ehiweb.it (Postfix) with ESMTPSA id 97563FF112; Wed, 9 Feb 2022 19:21:03 +0100 (CET) In-Reply-To: <87mtj3vxeg.fsf@gnus.org> (larsi@gnus.org) X-fingerprint: 4B02 6187 5C03 D6B1 2E31 7666 09DF 2DC9 BE21 6115 X-PPP-Message-ID: <20220209182103.31391.93361@plesklin7.if1.ehiweb.it> X-PPP-Vhost: potorti.it X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226501 Archived-At: Francesco Potortì writes: >>>Do we have a convenience function that says whether we have a match in >>>auto-mode-alist? `set-auto-mode--apply-alist' seems to be the closest I >>>can find, and... it's not that close. :-/ But I guess it could be >>>refactored out of there. >> >> This one seems to do the job: >> (add-to-list 'auto-mode-alist >> (cons diary-file 'diary-mode) >> (lambda (a b) (equal (car a) (car b)))) > >The user may have used a regexp like "diary$", "diary\\'", etc, so that >doesn't work. Sorry, I don't get it. I am suggeting to add the name of the actual file (the one in diary-file) to the mode alist. Looking for possible matches is a (small) optimisation. Why do we need a completely reliable matching code? >>>We could move diary-file out of calendar.el and put it in... >>>bindings.el or something, though? >> >> I would add it to the mode alist just after diary-file's defcustom > >As I said, that wouldn't help that much, because then you only get it >added to auto-mode-alist after loading calendar.el (since there's where >it's defined today). In fact, both M-x diary and M-x appt-activate do load calendar, so it seems that any usage of diary, appointment or calendar functions would do the right thing, as long as the diary file is found after that. Well, better than nothing, maybe. In principle, after adding the hook, one could check whether any buffer is finding the diary file and change its mode...