From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#54636: dired fails to update subdirs when files are created/deleted/renamed Date: Wed, 30 Mar 2022 18:32:41 +0200 Message-ID: <87zgl7z99s.fsf@gnu.org> References: <877d8b3d4w.fsf@igel.home> <87y20r1vys.fsf@igel.home> <87o81n1ue5.fsf@gnu.org> <835ynv8ti4.fsf@gnu.org> <87k0cb1rpa.fsf@gnu.org> <831qyj8rxl.fsf@gnu.org> <87czi31p1l.fsf@gnu.org> <83zgl7780z.fsf@gnu.org> <878rsr1kss.fsf@gnu.org> <83y20r768z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15342"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.12; emacs 29.0.50 Cc: 54636@debbugs.gnu.org, schwab@linux-m68k.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 30 18:38:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZbKx-0003rf-Mo for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 18:38:23 +0200 Original-Received: from localhost ([::1]:44170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZbKw-00021e-5o for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 12:38:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZbKd-0001z2-O0 for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 12:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42887) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZbKb-0002QY-VD for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 12:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZbKb-0000HX-Sd for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 12:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Mar 2022 16:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54636 X-GNU-PR-Package: emacs Original-Received: via spool by 54636-submit@debbugs.gnu.org id=B54636.16486582681060 (code B ref 54636); Wed, 30 Mar 2022 16:38:01 +0000 Original-Received: (at 54636) by debbugs.gnu.org; 30 Mar 2022 16:37:48 +0000 Original-Received: from localhost ([127.0.0.1]:36784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZbKO-0000H1-Az for submit@debbugs.gnu.org; Wed, 30 Mar 2022 12:37:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZbKN-0000Gp-A7 for 54636@debbugs.gnu.org; Wed, 30 Mar 2022 12:37:47 -0400 Original-Received: from [2001:470:142:3::e] (port=39086 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZbKH-0002ND-PG; Wed, 30 Mar 2022 12:37:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=vDPDUQPGbUqbuXN1YvsxqZYibAlHQZ7p0okgr8/puus=; b=SMTOxrfeWxQerw ojG2IAWFK/WAyWlH4G+t2kum4HLbguZzCak8WgoO7BJ0aHFkMhlVowRjQWVUkmb7Ig9crnr68Edac UGWSfoPlCgJ73d06TY6SeN7g5OZqJDOIU6UCJC9wGb0yuEEyF+Yd/fbxTqyFSjktNJqTqBK/kp4b0 im4v8NdIHmawVqkE7fS3k0kEa6AhD1fI3Rppq7+wKDAzho3Cs0zqYhh/rzW6Gzk/XbVyZvndxiJrB FuXuzAMWZDrLjLqwj+CNRLHy9NESmV8vj9KSDvExj6F40fxDj21L8DhhE1oWspZuQwUES+vyCtVj3 KiE8mBZiDZNO0Bz4T6Vg==; Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:60297) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZbKE-0002MT-1N; Wed, 30 Mar 2022 12:37:41 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id 9AC4127C005B; Wed, 30 Mar 2022 12:37:37 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 30 Mar 2022 12:37:37 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeivddguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvffuffgjkfggtgesthdtredttdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe evveeikeetkeeviefgfeffiedvteeguddvffeuueduveegtddthedvhfeuveffhfenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnod hmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedv leekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Mar 2022 12:37:36 -0400 (EDT) In-reply-to: <83y20r768z.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229123 Archived-At: Eli Zaretskii writes: >> From: Tassilo Horn >> Cc: schwab@linux-m68k.org, 54636@debbugs.gnu.org >> Date: Wed, 30 Mar 2022 18:02:15 +0200 >> >> Eli Zaretskii writes: >> >> > So when will SUBDIRS be non-nil? dired-clean-up-after-deletion is >> > called not only when a directory is deleted, I think. >> >> Yes, it's also called when deleting a file but in that case >> dired-buffers-for-dir will return nil, so no buffer will be deleted. > > What about moving/renaming a directory? No, it's only called from dired-delete-entry which is only called from dired-internal-do-deletions which is only called from dired-do-delete and dired-do-flagged-delete. So only real deletions. >> I think my patch is valid but now I think I should just create a >> separate function dired-buffers-for-cleanup and use that from >> dired-clean-up-after-deletion (or just collect the buffers in that >> function) and remove the SUBDIRS argument from dired-buffers-for-dir as >> it changes its logic too drastically. >> >> I'll prepare a patch in that direction later. > > At this point, I'd prefer the safest, simplest patch for the release > branch, because I intend to release Emacs 28.1 VSN. We can make a > cleaner fix on master later. The other patch with the separate function only called by dired-clean-up-after-deletion is equivalent and safer than the modification of dired-buffers-for-dir which is called in many places. In the worst case, we have a cleanup problem after directory deletion. > Do you think this patch you posted is safe enough for Emacs 28.1? Yes, but I'd very much prefer to use the newer patch from my mail some minutes ago for the reasons explained above. Bye, Tassilo