From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#56227: 29.0.50; Eshell globs ending with '/' should match directories only Date: Sun, 26 Jun 2022 16:52:57 +0200 Message-ID: <87zghzeat2.fsf@gnus.org> References: <59d27492-84bb-02d1-0c10-55b8e861aeb7@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24257"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56227@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 26 16:54:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5TeX-00066V-76 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Jun 2022 16:54:21 +0200 Original-Received: from localhost ([::1]:33820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5TeW-0005ue-3a for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Jun 2022 10:54:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5TeF-0005sj-0e for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2022 10:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54711) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5TeE-0008CU-Ov for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2022 10:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5TeE-0008In-OR for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2022 10:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2022 14:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56227 X-GNU-PR-Package: emacs Original-Received: via spool by 56227-submit@debbugs.gnu.org id=B56227.165625518731785 (code B ref 56227); Sun, 26 Jun 2022 14:54:02 +0000 Original-Received: (at 56227) by debbugs.gnu.org; 26 Jun 2022 14:53:07 +0000 Original-Received: from localhost ([127.0.0.1]:48597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5TdL-0008Ga-Es for submit@debbugs.gnu.org; Sun, 26 Jun 2022 10:53:07 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5TdK-0008Fj-Ii for 56227@debbugs.gnu.org; Sun, 26 Jun 2022 10:53:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2aeTbcDJ627XdlRSubH7n/fguFnWfmCyhFeaEYQAxZs=; b=PCO6ebcBbYswbdU3eEgNWrWS0m a+iRiNGFZ0xj9iUNGQokVK26umLHCLvf/7yaKLg6BmNNKwxAj+PxENpbjxLMiGEW/mnO8Lm76dEur MbM70/I9iACPSAVmCR/y2oqY1QMIcEf5pqJVYojAlfu5QnBlJP42Qjd1EFCsRLHCAPpA=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5TdC-00036A-4f; Sun, 26 Jun 2022 16:53:00 +0200 In-Reply-To: (Jim Porter's message of "Sat, 25 Jun 2022 18:52:57 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235343 Archived-At: Jim Porter writes: > Here's the patch. The first part refactors em-glob.el a bit, and > converts globs into regexps ahead of time. This is partly to make the > second patch simpler, but also improves performance by a few percent > when `eshell-glob-entries' examines many directories: it no longer > repeatedly converts the same glob component for each sibling > directory. > > The second part is the actual patch for this bug. Thanks; pushed to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no