From: Visuwesh <visuweshm@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 56323@debbugs.gnu.org
Subject: bug#56323: 29.0.50; [v2] Add new customisable phonetic Tamil input method
Date: Sat, 02 Jul 2022 14:58:32 +0530 [thread overview]
Message-ID: <87zghrj22n.fsf@gmail.com> (raw)
In-Reply-To: <83edz3di24.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Jul 2022 11:39:47 +0300")
[சனி ஜூலை 02, 2022] Eli Zaretskii wrote:
>> > Why do you need a single function for all of them? Would a separate
>> > setter function for each defcustom do the job?
>> >
>>
>> Because it is harder to clear the old translation rules and add the new
>> translation rules than clearing ALL translation rules and starting over
>> again. When the user changes tamil-vowel-translation, then not only
>> does the translation rule for the vowels change, we also need to change
>> the translation rules for consonant+vowel pairs so that means we need to
>> check if the consonant var is bound. (The translation rules for
>> consonant+vowel pairs are auto-generated based on the rules for vowels
>> and consonants.)
>
> If the rules are generated based on both defcustom's, then shouldn't
> we have just one defcustom for both? IOW, what is the purpose of
> having two separate defcustom's here?
>
It simply seemed natural to me to separate consonants and vowels. I
combined the three defcustoms (vowels, consonants and misc) as you told
but the native digits defcustom is still a problem... hmm. I can just
leave it to the user to add the native digit translations to the
defcustom if they want.
>> > I also don't understand the need for the boundp tests -- the function
>> > will live on the same indian.el file as the defcustoms, so if the
>> > function is defined, the defcustoms are also bound, no?
>> >
>>
>> IIUC, when we load indian.el, first, the vowel defcustom will be bound,
>> then the consonant defcustom and so on. So this boundp test is needed,
>> I think?
>
> Wouldn't that be fixed by having the setter function defined before
> the defcustom's?
>
>> See above for why the defcustoms have a "dependency" on each
>> other. When the vowel defcustom is loaded, then its job _sometimes_
>> depends on the consonant defcustom being bound as well.
>
> Since the defcustom's have their default value, I don't think I see
> the problem. Did you actually see any problems, and if so, in which
> scenario, and what were the error messages?
>
I was mostly worried about the tamil-native-digits defcustom but that
can be easily avoided.
>> I thought the subject could be "Translation rules for the Tamil input
>> method." If you think the group name is too general, then "tamil-im"
>> could work?
>
> tamil-input, perhaps?
Okay, then. That looks better to me as well.
I will post an updated patch later when I clean up the comments, and
docstrings. Thanks.
next prev parent reply other threads:[~2022-07-02 9:28 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 12:13 bug#56323: 29.0.50; Add new customisable phonetic Tamil input method Visuwesh
2022-06-30 14:08 ` Visuwesh
2022-06-30 15:53 ` Visuwesh
2022-07-01 12:59 ` bug#56323: 29.0.50; [v2] " Visuwesh
2022-07-01 13:01 ` Visuwesh
2022-07-01 13:22 ` Eli Zaretskii
2022-07-01 13:47 ` Visuwesh
2022-07-01 14:06 ` Eli Zaretskii
2022-07-01 14:30 ` Visuwesh
2022-07-01 16:09 ` Eli Zaretskii
2022-07-01 16:37 ` Visuwesh
2022-07-01 18:16 ` Eli Zaretskii
2022-07-02 4:02 ` Visuwesh
2022-07-02 6:35 ` Eli Zaretskii
2022-07-02 6:54 ` Visuwesh
2022-07-02 7:17 ` Eli Zaretskii
2022-07-02 7:35 ` Eli Zaretskii
2022-07-02 7:46 ` Eli Zaretskii
2022-07-02 8:11 ` Visuwesh
2022-07-02 8:29 ` Eli Zaretskii
2022-07-02 8:40 ` Visuwesh
2022-07-02 8:54 ` Eli Zaretskii
2022-07-02 9:33 ` Visuwesh
2022-07-02 9:38 ` Eli Zaretskii
2022-07-02 10:31 ` Visuwesh
2022-07-02 10:46 ` Eli Zaretskii
2022-07-02 12:08 ` Visuwesh
2022-07-02 11:05 ` समीर सिंह Sameer Singh
2022-07-02 12:04 ` Visuwesh
2022-07-02 12:23 ` Eli Zaretskii
2022-07-02 6:58 ` Eli Zaretskii
2022-07-02 7:58 ` Visuwesh
2022-07-02 8:39 ` Eli Zaretskii
2022-07-02 9:28 ` Visuwesh [this message]
2022-07-10 3:56 ` Visuwesh
2022-07-10 5:34 ` Eli Zaretskii
2022-07-10 6:42 ` Visuwesh
2022-07-10 7:32 ` Visuwesh
2022-07-14 6:34 ` Eli Zaretskii
2022-07-14 7:11 ` Visuwesh
2022-07-02 12:15 ` Visuwesh
2022-07-03 3:57 ` Visuwesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zghrj22n.fsf@gmail.com \
--to=visuweshm@gmail.com \
--cc=56323@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).