From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#56635: 29.0.50; [PATCH] hide-show in python-mode supports ONLY function and class blocks Date: Sat, 23 Jul 2022 09:58:57 +0200 Message-ID: <87zgh01cqm.fsf@gnus.org> References: <87v8ruysep.fsf@secretsauce.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37552"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: kobarity , 56635@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 23 10:01:04 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oFA4N-0009Xd-51 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jul 2022 10:01:03 +0200 Original-Received: from localhost ([::1]:55248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFA4L-0003Wz-Q4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jul 2022 04:01:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFA3a-0003Tu-1J for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2022 04:00:14 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53456) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oFA3Q-0005Cu-1c for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2022 04:00:13 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oFA3O-00028m-Ps for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2022 04:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jul 2022 08:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56635-submit@debbugs.gnu.org id=B56635.16585631508111 (code B ref 56635); Sat, 23 Jul 2022 08:00:02 +0000 Original-Received: (at 56635) by debbugs.gnu.org; 23 Jul 2022 07:59:10 +0000 Original-Received: from localhost ([127.0.0.1]:43205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFA2X-00026l-Op for submit@debbugs.gnu.org; Sat, 23 Jul 2022 03:59:09 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:48164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFA2V-00026T-NU for 56635@debbugs.gnu.org; Sat, 23 Jul 2022 03:59:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=63s4/YoLG9L3kmUKhev8P+EVZvICxIeIlTbemzN74Y0=; b=Z37wSoM3QmcnkMrX5oDSdwK0it UMbxoD5VNAkOYKdtAI3LjKlH9A9OzDRZThchWf6ZQU8JnMcl4ohynkVk6weLMuKfEB0luLkPlgpRg oS7vquldBnoswS+cR5R/YXBeaQe8/jC7hPYQSXLiwWqgY4MzfKp24lpLoTC4Gs4rh3nM=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oFA2M-000053-Ff; Sat, 23 Jul 2022 09:59:00 +0200 In-Reply-To: <87v8ruysep.fsf@secretsauce.net> (Dima Kogan's message of "Mon, 18 Jul 2022 15:20:30 -0700") X-Now-Playing: The Residents's _Subterranean Modern_: "Time's Up" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237695 Archived-At: Dima Kogan writes: > Obvious options: > > 1. Leave the code as it is, don't support other blocks > > 2. Take this patch, with the understanding that it'll collapse some > stuff that it shouldn't > > 3. Patch hide-show to potentially accept non-regex logic > > I've been dogfooding the patch for a few days now, and it's behaving 99% > properly for me, so I'm inclined to suggest option 2. Making hide-show > smarter (option 3) doesn't feel worth the effort to fix THIS problem. Hm; don't know either. Kobarity's done some work in related areas in python-mode lately, and perhaps has some comments, so added to the CCs.