From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 57087@debbugs.gnu.org, dalanicolai@gmail.com
Subject: bug#57087: 29.0.50; (face-at-point nil t) does not return all faces when hl-line-mode is active
Date: Fri, 12 Aug 2022 15:55:35 +0200 [thread overview]
Message-ID: <87zgg9pnvs.fsf@gnus.org> (raw)
In-Reply-To: <83lerwsuge.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 10 Aug 2022 05:28:33 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> Yes, probably. However, "return the first one" doesn't tell which one
> this would be. Also "character has more than one face" is inaccurate,
> we should say "more than one source of face information" or somesuch.
Yup. And `thing' is an unfortunate argument name, since people might
interpret that as the face property should be gotten from that thing (as
with get-text-property and friends with `object').
>> I think it sounds like it would be more useful if it did indeed return
>> all the faces at point instead of just the face(s) from either the
>> overlay or the face(s) from the text property.
>
> AFAICT, there's only one user of MULTIPLE, and that is org.el, so we
> should ask them what they expect. There's always a possibility to add
> a new function, say faces-at-point.
Yes, I think perhaps adding a new function like that might make more
sense, because `face-at-point' seems like a very DWIM-ish function with
unclear semantics (like preferring the `read-face-name' over `face'
property, etc).
So I've now just explained this in the doc string. I think the function
is basically fine as is -- it works well as a prompt default function.
prev parent reply other threads:[~2022-08-12 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 18:55 bug#57087: 29.0.50; (face-at-point nil t) does not return all faces when hl-line-mode is active dalanicolai
2022-08-09 19:20 ` Eli Zaretskii
2022-08-09 19:35 ` Lars Ingebrigtsen
2022-08-10 2:28 ` Eli Zaretskii
2022-08-12 13:55 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgg9pnvs.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=57087@debbugs.gnu.org \
--cc=dalanicolai@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).