From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57152: 29.0.50; Emacs executable isn't rebuilt when loaddefs.el is modified Date: Fri, 12 Aug 2022 17:14:26 +0200 Message-ID: <87zgg9o5nx.fsf@gnus.org> References: <83k07endtb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22407"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57152@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 12 17:16:04 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMWOJ-0005i7-Tz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Aug 2022 17:16:03 +0200 Original-Received: from localhost ([::1]:37774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oMWOI-0008Cr-RQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Aug 2022 11:16:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50134) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMWNK-0008AN-SS for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2022 11:15:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40618) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oMWNK-0004vB-Ik for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2022 11:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oMWNK-0005uN-ET for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2022 11:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Aug 2022 15:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57152 X-GNU-PR-Package: emacs Original-Received: via spool by 57152-submit@debbugs.gnu.org id=B57152.166031727822661 (code B ref 57152); Fri, 12 Aug 2022 15:15:02 +0000 Original-Received: (at 57152) by debbugs.gnu.org; 12 Aug 2022 15:14:38 +0000 Original-Received: from localhost ([127.0.0.1]:58600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMWMw-0005tR-Aj for submit@debbugs.gnu.org; Fri, 12 Aug 2022 11:14:38 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMWMu-0005tA-2G for 57152@debbugs.gnu.org; Fri, 12 Aug 2022 11:14:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4gF+ZdMKhV/TRmo+aW9os93Fq3EIGBkNIdLum26AAHE=; b=HCI5H9G0ehMfsKI1gUSupAum0P RtXfrRmPnQckK8B4fREmEWEvdCtN+jiorD5df4tp1bmiRD9EF+s5E1RYC16HltjizXwE+oPBCahJg 79ERSdVCDOEdPEr932SltwDX2/j4Bpu9A+xQ8XV9tgTysrgmT/5wuXsNmWGPr971vTN0=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMWMl-0006Mk-Ee; Fri, 12 Aug 2022 17:14:29 +0200 In-Reply-To: <83k07endtb.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Aug 2022 10:03:44 +0300") X-Now-Playing: Joni Mitchell's _Joni Mitchell_: "Song To A Seagull" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239421 Archived-At: Eli Zaretskii writes: > The current Makefile's still exhibit the problem that when loaddefs.el > is updated, the Emacs executable is not re-dumped to reflect those > updates. This leads to an annoying and error-prone practice that one > needs to watch the build, detect the telltale "ELC loaddefs.elc" > command (which means loaddefs.el was actually modified), and then > manually invoke "make" again to re-dump Emacs. > > AFAICT, the root cause of this is that src/Makefile.in doesn't know > about the dependencies of loaddefs.el, which are spelled out in > lisp/Makefile.in, and therefore it doesn't realize that loaddefs.el > will be modified as part of the current build. Yes. So the next time you say "make", it'll rebuild the executable. In one way, this is slightly better than what we had before, where loaddefs.el wouldn't be rebuilt until after VCWITNESS had changed, while it's now actually updated all the time (that something changes). It's more... regular? But on the other hand, these updates are seldom actually necessary, so we're doing it a bit too much now, perhaps. Anyway, back to the problem -- I've poked at this quite a bit, but no solutions seem really... nice? If we updated the loaddefs.el file a bit earlier (before we build the Emacs executable), that'd fix the problem, but I could find a way to do that without breaking something else. There's probably something trivial I'm overlooking here.