From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matt Armstrong Newsgroups: gmane.emacs.bugs Subject: bug#57150: 29.0.50; [PATCH] Add test coverage for overlay modification hooks Date: Sat, 13 Aug 2022 17:44:59 -0700 Message-ID: <87zgg7fyb8.fsf@rfc20.org> References: <87ilmygjyv.fsf@rfc20.org> <878rns946i.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33747"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57150@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 14 02:46:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oN1lq-0008Yz-0L for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Aug 2022 02:46:26 +0200 Original-Received: from localhost ([::1]:59562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oN1lo-0007yI-Ef for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Aug 2022 20:46:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oN1lS-0007y9-W3 for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2022 20:46:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45636) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oN1lS-0005Gv-Nn for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2022 20:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oN1lS-00036Y-Ge for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2022 20:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matt Armstrong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Aug 2022 00:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57150 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57150-submit@debbugs.gnu.org id=B57150.166043791311859 (code B ref 57150); Sun, 14 Aug 2022 00:46:02 +0000 Original-Received: (at 57150) by debbugs.gnu.org; 14 Aug 2022 00:45:13 +0000 Original-Received: from localhost ([127.0.0.1]:35385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oN1kf-00035D-1n for submit@debbugs.gnu.org; Sat, 13 Aug 2022 20:45:13 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:35935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oN1kb-00034v-Fk for 57150@debbugs.gnu.org; Sat, 13 Aug 2022 20:45:11 -0400 Original-Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id 5337F100002; Sun, 14 Aug 2022 00:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1660437902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2Hv1nVJaxTsShVojeUVjxQ72D+DdvEU/w/RxDtPdYqg=; b=f6s1VF2HoETlGaSSkrEFb4TocBGmDcrZcdjlPAHgzObO54WPSZlTX3dgGdEMZha1hFyyAN cQplEMfWELXIaToSNU1lDXWpxjdCsHL+k7tVcwY7DMlZ7xUzAmNxnkwGK4N0P98sdOmxcg 2r4qUnTZrLBo1gZjwjtdsn+UetLB2VXQzZdjRyB89aluIK/Wx8cbhXGpKMJBtBbHM6dQe7 YPXFzSIe4187fV7zKvEbWVRNno/vuLuM6ctOgTcCo06f8C1BWZJQGHgTxEkCQyGG7QJgdO WtZP+dS5t5IFZTcvGxBiANqyerMng4yM0s9z8nmVpuAsQlvbB6pTQf0e0MKl1w== Original-Received: from matt by naz with local (Exim 4.96) (envelope-from ) id 1oN1kR-000Gbr-1Y; Sat, 13 Aug 2022 17:44:59 -0700 In-Reply-To: <878rns946i.fsf@localhost> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239602 Archived-At: Ihor Radchenko writes: > Matt Armstrong writes: > >> I noticed there was no explicit test against the overlay modification >> hook boundary conditions. The attached patch adds some, which might be >> nice to have if a person (possibly me) someday optimizes overlay >> performance with a change in data structure. > > Just in case. Have you seen > https://lists.gnu.org/archive/html/emacs-devel/2019-12/msg00323.htlm > ? > > I am not sure how much progress have been made on the noverlay branch, > but there was at least some existing test suitcase in there. Not sure if > it has been merged or if your proposed patch is not covered. Yes, thank you for pointing that out. I have gone as far as importing the entire history of emacs-devel into https://notmuchmail.org/ and read as much history about the overlay problem as I could discover. I have been in contact with both Andreas (the original feature/noverlay author) and Vladimir (who later examined it). Andreas had no plans to return to looking at the problem and did not recall the precise state the branch was left in. Vladimir, despite his interest, was unfortunately not able to get his employer to sign FSF papers. Both wished me luck. Fortunately all of the test cases from the feature/noverlay branch were merged to the master branch, I believe by Eli, shortly after they were written years ago. As for feature/noverlay itself, I have been exploring alternative approaches that might be simpler or clearer than Andreas' approach, with the clear advantage of seeing his implementation, of course. Failing any improvement I can always start right where he left off.