From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#57673: [PATCH] Parse --help messages for pcomplete Date: Wed, 14 Sep 2022 23:23:48 +0200 Message-ID: <87zgf14pln.fsf@gmail.com> References: <87zgfagqfs.fsf@gmail.com> <87sfl1leip.fsf@gmail.com> <87pmg3ef6j.fsf@gmail.com> <877d25day5.fsf@gmail.com> <87edwd3gpv.fsf@gnus.org> <8735ctd9qe.fsf@gmail.com> <87a6713ffm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1624"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 57673@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 14 23:24:34 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYZs1-0000Hc-9g for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Sep 2022 23:24:33 +0200 Original-Received: from localhost ([::1]:53580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYZs0-0006X8-DF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Sep 2022 17:24:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYZrW-0006VV-W8 for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 17:24:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39475) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYZrW-0007K3-Or for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 17:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oYZrW-0000iz-Ak for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 17:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Sep 2022 21:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57673 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57673-submit@debbugs.gnu.org id=B57673.16631906382774 (code B ref 57673); Wed, 14 Sep 2022 21:24:02 +0000 Original-Received: (at 57673) by debbugs.gnu.org; 14 Sep 2022 21:23:58 +0000 Original-Received: from localhost ([127.0.0.1]:56407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYZrR-0000ig-Pu for submit@debbugs.gnu.org; Wed, 14 Sep 2022 17:23:58 -0400 Original-Received: from mail-ed1-f41.google.com ([209.85.208.41]:45780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYZrQ-0000iT-T0 for 57673@debbugs.gnu.org; Wed, 14 Sep 2022 17:23:57 -0400 Original-Received: by mail-ed1-f41.google.com with SMTP id m3so4330528eda.12 for <57673@debbugs.gnu.org>; Wed, 14 Sep 2022 14:23:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=4u/oweXjNBglpK1WggxkldGwDQJqm3pwuVFp93qsEK4=; b=iPUXfrsfXvWmpOV9gpyOaSDgBydRJnv+vYgyc35Te3bMNsHIkKno03lQSSEayxiu/z SkJpZVwT+6NlEwcbykWXfxde/MCbVNxD+2cmSjjcMyEEaRgut8yInAwlDqjJd9/wUB+5 J9Ktm7wWwvidM+zpIhOB7gknmtkxpk7krBOK4PhTUGfBAlzrdH2amqibQgz+gGybKisH YLp9JXqsau9uS9NqXSDI3bijn4bS35pn0AiYBnGq0feNdMgdHbMxu69VJdgWlt2ZA+YT eP2I3qmroQRmvCKe2CStakv5IWO65kDfxFSZcMwTVdxC14swBzWUJjDU97n5J2Aooy7R uPtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=4u/oweXjNBglpK1WggxkldGwDQJqm3pwuVFp93qsEK4=; b=XaNJxPCNokGdA3QE1HzTfGs/yKwG4a0jtiGzJGKUdk+IXTDZ4MmOKBUD+VGcQkZpok he8IEs97JbttMi7LXe6U38mb0G06Q+Z9DqldoXjLyo85yGsg65D1Tv3XUo3+4iCkIp+I qdtHZ8jvG5DaOd936vXst6YM6o7fkFHx1iYuGLq1JE9cRpK5BC9MEPjX2/CFvVJqnBCJ Na5V6l9tZMq+dYMBQa3gzYBPAVM5KyhMl3JNwSPoPVjQv0Dg2DHF/pJiqe6xdY6+z9xv 9pCnJDIYFDBkZE5W1mZK026ZxTZvOkXWsiRkkvnizLjvWkHLhcD4bSYx4cEq4wUVO0Rx DuzA== X-Gm-Message-State: ACgBeo1Hlc/NEU7nm6bb0bC38BZNBwS+nIbXGtfeAMtvdLnt3mNCbPnZ n8tndQu/gu2ZYtLBUoRN0Ai6iTGW1gs= X-Google-Smtp-Source: AA6agR5342kpgt3dJs+idPKAUvuhDS/YXOQ28+9RS9KTj6Zau8IhTVG3qrsDzgHa049oO5PMGGCqSg== X-Received: by 2002:a05:6402:1d4e:b0:451:d378:eed2 with SMTP id dz14-20020a0564021d4e00b00451d378eed2mr14482286edb.23.1663190630539; Wed, 14 Sep 2022 14:23:50 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::8510]) by smtp.gmail.com with ESMTPSA id x17-20020a1709065ad100b0073d87068042sm8069634ejs.110.2022.09.14.14.23.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 14:23:49 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 14 Sep 2022 16:40:43 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242537 Archived-At: On Wed, 14 Sep 2022 at 16:40, Stefan Monnier wrote: > Tho to be perfectly honest, I think any keyword argument whose default > value is not the same as nil is a problem (I know, sometimes there can > be good reasons for that, but we should try to avoid them as much as > possible). Hum, that's a strong claim, and if I heard it from a clean code influencer I would be rather suspicious. So I'm curious why you think that way. My thinking is that in the body of the function you can do anything at all, while in the arglist the only thing you can do (sanely) is to nominate a value. So if your default _is_ just a plain old value, it's reassuring to see it declared in the arglist.