From: Michael Albinus <michael.albinus@gmx.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Gustavo Barros <gusbrs.2016@gmail.com>, 57856@debbugs.gnu.org
Subject: bug#57856: 28.2; bookmark context strings in encrypted files
Date: Mon, 19 Sep 2022 14:16:47 +0200 [thread overview]
Message-ID: <87zgevimog.fsf@gmx.de> (raw)
In-Reply-To: <87mtavvafd.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 19 Sep 2022 14:03:02 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
Hi Lars,
> Michael Albinus <michael.albinus@gmx.de> writes:
>
>> Thinking further about, there are also other files which shouldn't
>> expose snippets to bookmarks. Think about .authinfo / .netrc (more
>> general, all files used as auth-sources backend). And perhaps other
>> files.
>>
>> Wouldn't it be better, if packages like Tramp, epa, auth-sources, you
>> name it, could mark files to be excluded from bookmark-make-record? For
>> example, a hook a package could contribute to. In Tramp, we would run
>>
>> (add-hook 'bookmark-inhibit-bookmark-hook #'tramp-crypt-file-name-p)
>
> Yes, that's true, but we don't really have a way to define
> auth-source-file-p except by heuristics -- a netrc file may be called
> anything.
>
> So I'm not sure how that'd look...
auth-source-file-name-p could scan the auth-sources declarations for a
file based backend, and return t for such files. Shouldn't be too hard
to implement (oops, do I offer to volunteer?)
Let's start with bookmark-inhibit-bookmark-hook, adding
tramp-crypt-file-name-p and epa-file-name-p, and see, who else wants to
be added.
Best regards, Michael.
next prev parent reply other threads:[~2022-09-19 12:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 11:08 bug#57856: 28.2; bookmark context strings in encrypted files Gustavo Barros
2022-09-16 12:07 ` Lars Ingebrigtsen
2022-09-16 12:30 ` Gustavo Barros
2022-09-16 13:01 ` Lars Ingebrigtsen
2022-09-16 13:18 ` Michael Albinus
2022-09-18 10:19 ` Lars Ingebrigtsen
2022-09-18 10:43 ` Michael Albinus
2022-09-19 7:42 ` Lars Ingebrigtsen
2022-09-19 9:00 ` Michael Albinus
2022-09-19 12:03 ` Lars Ingebrigtsen
2022-09-19 12:16 ` Michael Albinus [this message]
2022-09-19 12:34 ` Lars Ingebrigtsen
2022-09-19 13:03 ` Michael Albinus
2022-09-19 18:44 ` Lars Ingebrigtsen
2022-09-20 14:49 ` Michael Albinus
2022-09-20 14:53 ` Lars Ingebrigtsen
2022-09-20 15:00 ` Michael Albinus
2022-09-20 15:03 ` Gustavo Barros
2022-09-20 16:19 ` Michael Albinus
2022-09-19 11:13 ` Gustavo Barros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgevimog.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=57856@debbugs.gnu.org \
--cc=gusbrs.2016@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).