From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: Alan Third <alan@idiocy.org>,
36403@debbugs.gnu.org, Pip Cet <pipcet@gmail.com>
Subject: bug#36403: 27.0.50; Trivial image.c bugs
Date: Tue, 04 Oct 2022 16:06:28 +0200 [thread overview]
Message-ID: <87zgeb65uj.fsf@gnus.org> (raw)
In-Reply-To: <87y1tvwv9g.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 04 Oct 2022 16:52:59 +0300")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> Which means image-test-circular-specs signals:
>
> (circular-list (:dummy . #0))
>
> So how important is it to support image specs with circular property
> values? Should the test be marked :expected-result :failed?
Hm... don't know.
> - (setcdr circ1 circ1)
> - (setcdr circ2 circ2)
> - (and (equal (image-size spec1 t) (cons 1 1))
> - (equal (image-size spec2 t) (cons 1 1))))))
> + (setcdr circ1 circ1)
> + (setcdr circ2 circ2)
> + (should (equal (image-size spec1 t) '(1 . 1)))
> + (should (equal (image-size spec2 t) '(1 . 1)))))
(cons 1 1) is not eq to (cons 1 1), but '(1 . 1) may or may not be eq to
'(1 . 1) (depending on whether compiled or phase of the moon), which may
be why that code is written that way? But in this case, I can't see how
it would make a difference...
next prev parent reply other threads:[~2022-10-04 14:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 16:28 bug#36403: 27.0.50; Trivial image.c bugs Pip Cet
2019-06-27 17:40 ` Eli Zaretskii
2019-06-28 15:05 ` Pip Cet
2019-06-28 19:52 ` Eli Zaretskii
2019-07-22 2:55 ` Pip Cet
2019-07-26 6:56 ` Eli Zaretskii
2019-07-28 14:50 ` Pip Cet
2019-09-24 16:26 ` Lars Ingebrigtsen
2020-08-03 7:47 ` Lars Ingebrigtsen
2020-08-18 16:28 ` Lars Ingebrigtsen
2020-08-20 23:03 ` Alan Third
2020-08-20 23:13 ` Lars Ingebrigtsen
2020-08-20 23:17 ` Lars Ingebrigtsen
2020-08-20 23:32 ` Lars Ingebrigtsen
2020-08-21 9:26 ` Pip Cet
2020-08-21 11:26 ` Lars Ingebrigtsen
2022-10-04 13:52 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-04 14:06 ` Lars Ingebrigtsen [this message]
2022-10-04 18:05 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-14 22:14 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgeb65uj.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=36403@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=contovob@tcd.ie \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).