From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic Date: Sat, 08 Oct 2022 13:15:03 +0200 Message-ID: <87zge67eiw.fsf@gmail.com> References: <87pmffd8ya.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21929"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: 58141@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 08 13:16:43 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oh7ow-0005WI-Db for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Oct 2022 13:16:42 +0200 Original-Received: from localhost ([::1]:41730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oh7ou-0005fG-Sm for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Oct 2022 07:16:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh7oI-0005es-Os for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 07:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39345) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oh7oI-00044n-EV for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 07:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oh7oI-0005OR-6x for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 07:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Oct 2022 11:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58141 X-GNU-PR-Package: emacs Original-Received: via spool by 58141-submit@debbugs.gnu.org id=B58141.166522771320667 (code B ref 58141); Sat, 08 Oct 2022 11:16:02 +0000 Original-Received: (at 58141) by debbugs.gnu.org; 8 Oct 2022 11:15:13 +0000 Original-Received: from localhost ([127.0.0.1]:38423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oh7nV-0005NH-HP for submit@debbugs.gnu.org; Sat, 08 Oct 2022 07:15:13 -0400 Original-Received: from mail-ej1-f51.google.com ([209.85.218.51]:34334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oh7nT-0005Mb-HA for 58141@debbugs.gnu.org; Sat, 08 Oct 2022 07:15:11 -0400 Original-Received: by mail-ej1-f51.google.com with SMTP id ot12so16168547ejb.1 for <58141@debbugs.gnu.org>; Sat, 08 Oct 2022 04:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=SU0LaqCn0WxnAa8q43Vsv+/L92fsTC1mBg+j5engugQ=; b=M6uNTvpyqfzLNHTH0aoFruNeAaxEhK8lqCGferadgeO6O4k5bwTEk3HztVcqhd3UX6 1map9jINo8knk4rvY9sHj0FAyG3pL1QPeOc4dx0MalCoA/26WIjmoaOMHQdO6hFfzaBl tOfKd0/NsbPXLMP4fnRCDtTs4p7COfH1NVc9l06coS6Cjec4q1M4Skh29M0o08NoeA1N JNXbPCsudEtN4eadmZuU7ZKleR9EvspNMKzuMDVncncfomxvupKTPuLS++tA811/xl6s ziJcNKABckgD1ohs0W4llY/pmHQJ9h787dGulwcvBLnADG7+kJ7CPlcl1KJITHtNd8// ve8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SU0LaqCn0WxnAa8q43Vsv+/L92fsTC1mBg+j5engugQ=; b=amdiq5usQSTqjZG+pF6J9/uiDbL7z99ApOct2/msnhzM3XZ4PcxCKcqqmL/TmcRybT crZDwp0oCWMOWMBUOKWF6ux4klC8Rbb7BIEJKY3NqH8ACvXhYgWURqm8w4mCPiEe16tP U9hr3W4+3vMupB+immRjLDDFrbYgwxlRXryEfkDZvwYI3+zF1XOdr+fMRdzjEY3huEGt DFPTB+fNJJU0U6iLSa+NOvNn3xJPpKcWcZ20SqI0B6FS/YpnVDpRIWfQ5MN0ZMoeyAl/ 2Bx4Qx6UF2gOctliq4Kuy3HJoIC7AHqe+vkASOd2Dk5EfG86p27IaPmpbUhmz76jYwC+ 01KQ== X-Gm-Message-State: ACrzQf1EPXqyqMfycx8flOA/TX1gazHCbFgPxmiPfVRn1JdyoWKx0a8H m80W7Z88vUKJ7b9YRCrkKHU= X-Google-Smtp-Source: AMsMyM61a9O/dWwPQ6uFyowsClMlAQ+B2sGF9eV5IBRssVXKXkPAsem+VKLbuTvCUTPQ2vsLyW71QQ== X-Received: by 2002:a17:906:fe46:b0:730:ca2b:cb7b with SMTP id wz6-20020a170906fe4600b00730ca2bcb7bmr7704866ejb.703.1665227705455; Sat, 08 Oct 2022 04:15:05 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::89aa]) by smtp.gmail.com with ESMTPSA id bo1-20020a170906d04100b0073d753759fasm2623496ejb.172.2022.10.08.04.15.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Oct 2022 04:15:04 -0700 (PDT) In-Reply-To: <87pmffd8ya.fsf@gmail.com> (Augusto Stoffel's message of "Wed, 28 Sep 2022 13:39:25 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244882 Archived-At: On Wed, 28 Sep 2022 at 13:39, Augusto Stoffel wrote: > Finally, I think it's hard to be sure the result is readable in all > custom themes, even all reasonable ones. I initially wrote this as an abstract argument, but let me point out that in the Modus Operandi theme (which is eminently reasonable), the shadow face and font-lock-comment-face are equal. So it's hard to distinguish commented-out code from (presumably) unnecessary code. Here's a concrete suggestion: when a language server diagnostic says some code is "unnecessary", then apply _both_ eglot-diagnostic-tag-unnecessary-face and the usual Flymake face, with that order of priority. If the user so wishes, they can use eglot-diagnostic-tag-unnecessary-face to override any attribute of the flymake-* faces. But, by default, the eglot-diagnostic-tag-* faces are best kept empty.