From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58984: 29.0.50; M-x compile misinterprets libcheck error message format Date: Sun, 06 Nov 2022 14:10:56 +0200 Message-ID: <87zgd4uvu7.fsf@tcd.ie> References: <87a6589of4.fsf@tcd.ie> <87edui3ax7.fsf@tcd.ie> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24433"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58984@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 06 13:12:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oreVm-0006AX-8w for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Nov 2022 13:12:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oreVP-0002eG-IQ; Sun, 06 Nov 2022 07:12:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oreVO-0002e0-9m for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 07:12:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oreVO-0003zl-1N for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 07:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oreVN-0008Oz-PU for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 07:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Nov 2022 12:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58984 X-GNU-PR-Package: emacs Original-Received: via spool by 58984-submit@debbugs.gnu.org id=B58984.166773667032232 (code B ref 58984); Sun, 06 Nov 2022 12:12:01 +0000 Original-Received: (at 58984) by debbugs.gnu.org; 6 Nov 2022 12:11:10 +0000 Original-Received: from localhost ([127.0.0.1]:58863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oreUX-0008Nn-Mt for submit@debbugs.gnu.org; Sun, 06 Nov 2022 07:11:10 -0500 Original-Received: from mail-ed1-f43.google.com ([209.85.208.43]:34737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oreUT-0008ND-33 for 58984@debbugs.gnu.org; Sun, 06 Nov 2022 07:11:07 -0500 Original-Received: by mail-ed1-f43.google.com with SMTP id v27so13669642eda.1 for <58984@debbugs.gnu.org>; Sun, 06 Nov 2022 04:11:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=wn3e133WZf7p8MGKGMQdbm4pHOUyXi0kX4Mi4Sprdtg=; b=OfW791+hrsTBwRitl4HVyyjf+Z62VFo9rkAV2CAhGJwvT33A62I/ebTlsNzCq5PTNW gXrbkyuXvmw5/eIqHZS9XAoceUZHX6+DiNZ6Si76aCLBuwzzdxZqksJEGmikD1J3USaZ GXkaB5gs8DoADAA4NtOCzmjFZ35asUEsY/IDGzCnFGeccl8cUBim/ftBt2M6iqvE4gwp b7eFU4EYURHCLVS1YQ0i1lgoBIyNczPUPUDOWi0pf3a8R7ouYmN3iExYeRLD3qeFjfs3 50E56hg/Y5yEloZNAlkb+882m9AsZebgM9hXUuXRppx0xhxDuktgCtwT5ZIeAHxbS5UN uNcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wn3e133WZf7p8MGKGMQdbm4pHOUyXi0kX4Mi4Sprdtg=; b=5P7/9sBJefq2enmTTS51DdOp/yyovcuEK6QvfT/fHPSkQkoNk0ClTdrhHqvhS8e1hF bx9/UlWLoqv6h8sMXCz1CF7+8wICAwIVVvWn7ZuVRpQ4ut3YcmNeihQ7lNEkK4Wwq7NK Yu2gMJGqAJAKi0PxZUee4RvmpVFaA0qrnSJougoZVHi3xZWZSzTwHLpAhi7vfU+jZbcj cAPtJ8y7sP5AAlrnsD04XlRPPjsoFKudyJHTRp2hsOFAKApZs98uCEGdEve8rsgmKFzC CNk4ZIlkAYiCifcpL1LR5aEcO2pmsT3/kXLtVVq7AelgAHl4zMC85VfcboZmJYp8Wgi6 1P7g== X-Gm-Message-State: ACrzQf0ODMF9rhkuXTmzrj5aAC5pYgHHfoYNwAbdNdn9uHyqXoSq4By2 5GsBrFCBelDs0ZMtIpmtJLUZ7g== X-Google-Smtp-Source: AMsMyM7pd1kvzUYDByDVeLN98GFYW5c1sWWWJMjmjkHbx9b90wPudx3U/noLbEdpd4O9rlYDQ5VyfA== X-Received: by 2002:a50:eb05:0:b0:457:c6f5:5f65 with SMTP id y5-20020a50eb05000000b00457c6f55f65mr44165136edp.311.1667736659236; Sun, 06 Nov 2022 04:10:59 -0800 (PST) Original-Received: from localhost ([2a02:587:320c:8829:23:8156:16ed:40c2]) by smtp.gmail.com with ESMTPSA id g22-20020a50ee16000000b004616b006871sm2551391eds.82.2022.11.06.04.10.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Nov 2022 04:10:58 -0800 (PST) In-Reply-To: ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Fri, 4 Nov 2022 18:49:08 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247204 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mattias Engdeg=C3=A5rd [2022-11-04 18:49 +0100] wrote: > 4 nov. 2022 kl. 18.08 skrev Basil L. Contovounesios : >> itree-tests.c:71:F:insert1:test_insert_1:0: Assertion 'N_50.red' failed > > This doesn't quite conform to GNU message standards, does it? For it to h= ave the > > [PROGRAM:]FILE:LINE: MESSAGE > > form, there should be a space before the message (that is, before the > 'F'). Otherwise parsing these things become almost impossible with all the > possible variations, file names containing spaces and colons and so > on. I imagined as much, which is why I pinged you for comment from the outset ;). > Currently, the machinery interprets "tree-tests.c" as the program name and > "71:F:insert1:test_insert_1" as the file which is of course nonsense. > > Any hope the tool can have its output format adjusted? The only alternative format I'm aware of is after compiling the test runner in CK_SUBUNIT mode instead of CK_NORMAL or CK_ENV. I.e. with the following patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=errors.diff diff --git a/test/manual/noverlay/Makefile.in b/test/manual/noverlay/Makefile.in index 3c8dba1ce1..c0fa705174 100644 --- a/test/manual/noverlay/Makefile.in +++ b/test/manual/noverlay/Makefile.in @@ -33,7 +33,7 @@ .PHONY: all: check check: $(PROGRAM) - ./check-sanitize.sh ./$(PROGRAM) + ./$(PROGRAM) itree-tests.o: emacs-compat.h $(top_srcdir)/src/itree.c $(top_srcdir)/src/itree.h diff --git a/test/manual/noverlay/itree-tests.c b/test/manual/noverlay/itree-tests.c index 278e65f9bf..a8c69c79be 100644 --- a/test/manual/noverlay/itree-tests.c +++ b/test/manual/noverlay/itree-tests.c @@ -68,8 +68,8 @@ START_TEST (test_insert_1) */ interval_tree_insert (&tree, &N_50); - ck_assert (! N_50.red); - ck_assert_ptr_eq (&N_50, tree.root); + ck_assert (N_50.red); + ck_assert_ptr_ne (&N_50, tree.root); } END_TEST @@ -88,7 +88,7 @@ START_TEST (test_insert_2) ck_assert_ptr_eq (&N_50, tree.root); ck_assert_ptr_eq (N_30.parent, &N_50); ck_assert_ptr_eq (N_50.left, &N_30); - ck_assert_ptr_null (N_50.right); + ck_assert_ptr_nonnull (N_50.right); ck_assert_ptr_null (N_30.left); ck_assert_ptr_null (N_30.right); } @@ -737,7 +737,7 @@ START_TEST (test_remove_10) itree_remove (&tree, &nodes[index[i]]); } ck_assert_ptr_null (tree.root); - ck_assert_int_eq (tree.size, 0); + ck_assert_int_ne (tree.size, 0); } END_TEST @@ -749,11 +749,11 @@ START_TEST (test_remove_10) START_TEST (test_generator_1) { struct itree_node node, *n; - struct itree_iterator *g; + struct itree_iterator *g = NULL; interval_tree_init (&tree); itree_insert (&tree, &node, 10, 20); - g = itree_iterator_start (&tree, 0, 30, ITREE_ASCENDING, NULL, 0); + /* g = itree_iterator_start (&tree, 0, 30, ITREE_ASCENDING, NULL, 0); */ n = itree_iterator_next (g); ck_assert_ptr_eq (n, &node); ck_assert_int_eq (n->begin, 10); @@ -1282,7 +1282,7 @@ main (void) SRunner *sr = srunner_create (s); init_itree (); - srunner_run_all (sr, CK_ENV); + srunner_run_all (sr, CK_SUBUNIT); int nfailed = srunner_ntests_failed (sr); srunner_free (sr); return (nfailed == 0) ? EXIT_SUCCESS : EXIT_FAILURE; --=-=-= Content-Type: text/plain I get the following output: --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=errors.txt -*- mode: compilation; default-directory: "~/.local/src/emacs/test/manual/noverlay/" -*- Compilation started at Sun Nov 6 14:08:38 make gcc -O0 -g3 -pthread -I ../../../src -c -o itree-tests.o itree-tests.c gcc itree-tests.o -lcheck_pic -pthread -lrt -lm -lsubunit -lm -o itree-tests ./itree-tests test: insert1:test_insert_1 failure: insert1:test_insert_1 [ itree-tests.c:71: Assertion 'N_50.red' failed ] test: insert1:test_insert_2 failure: insert1:test_insert_2 [ itree-tests.c:91: Assertion 'N_50.right != NULL' failed: N_50.right == 0 ] test: insert1:test_insert_3 success: insert1:test_insert_3 test: insert1:test_insert_4 success: insert1:test_insert_4 test: insert1:test_insert_5 success: insert1:test_insert_5 test: insert1:test_insert_6 success: insert1:test_insert_6 test: insert2:test_insert_7 success: insert2:test_insert_7 test: insert2:test_insert_8 success: insert2:test_insert_8 test: insert2:test_insert_9 success: insert2:test_insert_9 test: insert2:test_insert_10 success: insert2:test_insert_10 test: insert2:test_insert_11 success: insert2:test_insert_11 test: insert2:test_insert_12 success: insert2:test_insert_12 test: insert3:test_insert_13 success: insert3:test_insert_13 test: insert3:test_insert_14 success: insert3:test_insert_14 test: remove1:test_remove_1 success: remove1:test_remove_1 test: remove1:test_remove_2 success: remove1:test_remove_2 test: remove1:test_remove_3 success: remove1:test_remove_3 test: remove1:test_remove_4 success: remove1:test_remove_4 test: remove2:test_remove_5 success: remove2:test_remove_5 test: remove2:test_remove_6 success: remove2:test_remove_6 test: remove2:test_remove_7 success: remove2:test_remove_7 test: remove2:test_remove_8 success: remove2:test_remove_8 test: remove3:test_remove_9 success: remove3:test_remove_9 test: remove3:test_remove_10 failure: remove3:test_remove_10 [ itree-tests.c:740: Assertion 'tree.size != 0' failed: tree.size == 0, 0 == 0 ] test: generator:test_generator_1 ../../../src/itree.c:1370:eassert condition failed: g && g->running error: generator:test_generator_1 [ itree-tests.c:749: (after this point) Early exit with return value 1 ] test: generator:test_generator_2 success: generator:test_generator_2 test: generator:test_generator_3 success: generator:test_generator_3 test: generator:test_generator_5 success: generator:test_generator_5 test: generator:test_generator_6 success: generator:test_generator_6 test: generator:test_generator_7 success: generator:test_generator_7 test: generator:test_generator_8 success: generator:test_generator_8 test: generator:test_generator_9 success: generator:test_generator_9 test: insert_gap:test_gap_insert_1 success: insert_gap:test_gap_insert_1 test: insert_gap:test_gap_insert_2 success: insert_gap:test_gap_insert_2 test: insert_gap:test_gap_insert_3 success: insert_gap:test_gap_insert_3 test: insert_gap:test_gap_insert_4 success: insert_gap:test_gap_insert_4 test: insert_gap:test_gap_insert_5 success: insert_gap:test_gap_insert_5 test: insert_gap:test_gap_insert_6 success: insert_gap:test_gap_insert_6 test: insert_gap:test_gap_insert_7 success: insert_gap:test_gap_insert_7 test: insert_gap:test_gap_insert_8 success: insert_gap:test_gap_insert_8 test: insert_gap:test_gap_insert_9 success: insert_gap:test_gap_insert_9 test: insert_gap:test_gap_insert_10 success: insert_gap:test_gap_insert_10 test: insert_gap:test_gap_insert_11 success: insert_gap:test_gap_insert_11 test: delete_gap:test_gap_delete_1 success: delete_gap:test_gap_delete_1 test: delete_gap:test_gap_delete_2 success: delete_gap:test_gap_delete_2 test: delete_gap:test_gap_delete_3 success: delete_gap:test_gap_delete_3 test: delete_gap:test_gap_delete_4 success: delete_gap:test_gap_delete_4 test: delete_gap:test_gap_delete_5 success: delete_gap:test_gap_delete_5 test: delete_gap:test_gap_delete_6 success: delete_gap:test_gap_delete_6 test: delete_gap:test_gap_delete_7 success: delete_gap:test_gap_delete_7 test: delete_gap:test_gap_delete_8 success: delete_gap:test_gap_delete_8 make: *** [Makefile:36: check] Error 1 Compilation exited abnormally with code 2 at Sun Nov 6 14:08:39 --=-=-= Content-Type: text/plain This is much more verbose, but the error messages are in a more readily grokked format. Not sure which is preferable between that and the status quo (filtering through check-sanitize.sh). In any case the feature request was to support Check's default output (what we do with our small manual test suite is largely inconsequential), so if that's too difficult and brittle for few gains, we can close this as wontfix. Thanks, -- Basil --=-=-=--