From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Date: Wed, 09 Nov 2022 11:06:08 +0100 Message-ID: <87zgd0fnn3.fsf@gmail.com> References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> <83sfj08sgz.fsf@gnu.org> <83fsety049.fsf@gnu.org> <878rklh4bv.fsf@gmail.com> <83edudxywx.fsf@gnu.org> <874jv9h3ci.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8669"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 58909@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 09 11:07:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oshzL-0001yD-EZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Nov 2022 11:07:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oshz5-0007KM-Lh; Wed, 09 Nov 2022 05:07:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oshz4-0007Jz-3s for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 05:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oshz3-00050E-Rq for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 05:07:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oshz3-0001vl-N8 for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 05:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Nov 2022 10:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16679883777353 (code B ref 58909); Wed, 09 Nov 2022 10:07:01 +0000 Original-Received: (at 58909) by debbugs.gnu.org; 9 Nov 2022 10:06:17 +0000 Original-Received: from localhost ([127.0.0.1]:39094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oshyK-0001uX-UG for submit@debbugs.gnu.org; Wed, 09 Nov 2022 05:06:17 -0500 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:38466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oshyJ-0001uK-UP for 58909@debbugs.gnu.org; Wed, 09 Nov 2022 05:06:16 -0500 Original-Received: by mail-wr1-f48.google.com with SMTP id a14so24973295wru.5 for <58909@debbugs.gnu.org>; Wed, 09 Nov 2022 02:06:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=lPysdg+sfzv99Y8ItrW2T3lPMQ+AohqAZ3bkNuS919Q=; b=REGMB6Iy9sVIR+yx7p3c11KVvxzANU99JRgKHy9tvuF6HUoR9qATPA3Ssq7HZsfAYL Qtee+4b78W3oaF6vasSRUsHqSaMQJpH9cbLJksJAYM3vDxN4hxUpsdQLNlC6Ni0sY/J6 LirLr14Yp606vO1M2BzMSwjtoPUuitwrR/5ZY0+raRFXF8cHXFBPQRdhB40G6Nku80+w Vum4O99uqk0bkOZvnhexPHPXW0Kds3grhTruI5dhKUdd0rOomNbsS7LWJ/28VCfVUQUm nT6zZ/hHX2zX+N8uMGtq2GpDvj5nBJeN5TnDUCNl1Zi+4ttiwjiB3GrF+LMFEd5dLF7U VNdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lPysdg+sfzv99Y8ItrW2T3lPMQ+AohqAZ3bkNuS919Q=; b=KQ5g15M89jNrZOFbvuPvpZmG4IVVkNr9CfFc6TpmlEg8gc/4Ty+pMf/ppt0ple7q7U lAvkdk22t4pO6yyvXTZRmWaqu6nWTo2UZI6pgtIKGVZyzSD9dZnnu0bS901V14vnO4Ba 5jEvPhscl6HIEN5ipCXpUlvVkYe5MXpRrjHjOVoUicTiGffAb502q6YHrE36l56VgH0r p/YmjONnUm8Koo7jB5sMgQSKyToTVltYwniUgQYBcOH4YUQczTCdt8oGpI40NH7ayxwB m1HBld3/K2WPNk6Z8HLrmR9k9B9T1TUhE/bft/u70+SBQ9ruqyR7bXC9//9kwAQyjfwJ fArg== X-Gm-Message-State: ACrzQf2rg3CLauedeI//k9/FVmzPdURi3UiFU6/1AGvrmmBTAio1EnWO wPmKkbDolJWJo11nvP4UzHdQfzKYjJk= X-Google-Smtp-Source: AMsMyM674QXw0a+iLB4mmi1ddL+o0Mi6BccVq2ILtWYxbZ6ijgiWTtd3Up8q3yIrkV1cM0jPyz43qQ== X-Received: by 2002:a5d:590d:0:b0:236:4ddd:1869 with SMTP id v13-20020a5d590d000000b002364ddd1869mr36742756wrd.709.1667988369489; Wed, 09 Nov 2022 02:06:09 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id bo13-20020a056000068d00b00236644228besm12790207wrb.40.2022.11.09.02.06.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 02:06:08 -0800 (PST) In-Reply-To: (Jim Porter's message of "Tue, 8 Nov 2022 08:52:10 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247395 Archived-At: >>>>> On Tue, 8 Nov 2022 08:52:10 -0800, Jim Porter = said: Jim> On 11/8/2022 7:29 AM, Robert Pluim wrote: >> OK. I don=CA=BCt see what benefit the *use* of the minor mode in thi= s way >> brings :-) Jim> The actual change that I'd like to merge is just to make the minor Jim> mode activate/deactivate consistently, whereas previously it would Jim> activate in some situations where you start the Emacs server, but = not Jim> others. I'd classify that as "not working". That sounds good Jim> Having the minor mode makes it easier for third-party code (user Jim> configs or packages) to define key bindings that are only active w= hen Jim> the server is running. That's useful to me, since I don't *always*= use Jim> the Emacs server. as does this Jim> As for the change to how 'C-x C-c' is bound, I don't have any stro= ng Jim> opinion on merging it. It's probably more risk than it's worth, an= d if Jim> we were to merge it, I'd prefer to do so after cutting the 29 bran= ch, Jim> since then there'd be more time to find any bugs.[1] However, since Jim> the only real benefit is to clean up some dependencies in the code, Jim> I'm not sure it's worth the effort. I think it would be too risky a change. Robert --=20