From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#59141: 28.1.90; Face :extend when all the line but trailing \n is invisible Date: Mon, 14 Nov 2022 12:02:06 +0100 Message-ID: <87zgctajf5.fsf@gmail.com> References: <871qqcdfvr.fsf@localhost> <83h6z5psqe.fsf@gnu.org> <83bkpdpf92.fsf@gnu.org> <8335app826.fsf@gnu.org> <831qq9p7b7.fsf@gnu.org> <87bkpc4e06.fsf@gmail.com> <865yfkoz1n.fsf@mail.linkov.net> <87mt8vnn6h.fsf@gmail.com> <86leoebv1q.fsf@mail.linkov.net> <87leoev6j0.fsf@gmail.com> <864jv26l0g.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28803"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59141@debbugs.gnu.org, Eli Zaretskii , Abdul-Lateef Haji-Ali , yantar92@posteo.net To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 15 01:14:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oujap-0007Eh-3C for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Nov 2022 01:14:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouiow-0001A6-Qm; Mon, 14 Nov 2022 18:24:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouigu-0006aC-Hb for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 18:16:37 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouXF0-0004oq-JB for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 06:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ouXF0-0006Oi-1N for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 06:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Nov 2022 11:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59141 X-GNU-PR-Package: emacs Original-Received: via spool by 59141-submit@debbugs.gnu.org id=B59141.166842374124547 (code B ref 59141); Mon, 14 Nov 2022 11:03:01 +0000 Original-Received: (at 59141) by debbugs.gnu.org; 14 Nov 2022 11:02:21 +0000 Original-Received: from localhost ([127.0.0.1]:48980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouXEK-0006Nq-Vm for submit@debbugs.gnu.org; Mon, 14 Nov 2022 06:02:21 -0500 Original-Received: from mail-wm1-f43.google.com ([209.85.128.43]:37457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouXEE-0006NX-O8 for 59141@debbugs.gnu.org; Mon, 14 Nov 2022 06:02:18 -0500 Original-Received: by mail-wm1-f43.google.com with SMTP id ay14-20020a05600c1e0e00b003cf6ab34b61so10379143wmb.2 for <59141@debbugs.gnu.org>; Mon, 14 Nov 2022 03:02:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wRXXICF83pCJCKiSbxUHG3t+aUNuRcGddjjmRBqu1Gw=; b=n7Js5zPb7Q82ZhiFo/M2YS0t8k3Ua22P5uBgtBC4WJjxpnr/Gceh09mEIL2jQacjAg cyoTq5OgwBZO6IbQQnGRBt5g1NvzNd+OFsoi//b3lwOlk2TkOxEJJliKRijQ6J9MP5Pm D8mkm4N02RYsCoNVBPRLt3Ty9dVj+ic1g+G68402gD1djVDJ/7HRP8nkJOhcSrFl0opR CMxUVPf7Rv1LZ6gps2IuJuhh4oXiEZNvKc4BAoiQgdFrhSoEvkPnbFFTB1P5lvId0CZL geWY4WaVWarPquo7rewk21YWVsThW0oOXcOUDPeDHAhlNW2GT/REv+PleCLxt2J2zuwx rzAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wRXXICF83pCJCKiSbxUHG3t+aUNuRcGddjjmRBqu1Gw=; b=pPU8PmyTdoZIxkAR8uGhEc/e98Ux7o3EzsnDHmLMJp9Xc+u+/t5N2+qNlJj+A7g6rg v7vDFEjpGEjXq1MJOM4Hps5HT7dA2zOwy9jIC6oZC/dx0izNyla3EYHVx6kxT+IcHyMo ALFPwkUg2HbSxu2q6F1wmkfPlsETe00g1VKMBM1xyUIp/HhmrjjKy4d3XKN9xqJtbcmW hsBWG3yK0s/1lT2/Lc91tgfxLhq1MfyhhvsR2Hjnxg30XFausYVVDvgCK778tSNQb97D +A0x/M6mHNpoDsJqnZ2ELx6SVlpNxgfiVnxJsFGU9mvUGCN4dRQdzMs+09sTS+tQ6E4M SWbw== X-Gm-Message-State: ANoB5pm8ucNuZ7P4SuQ88Zpx+SVnlJrYgPrjYe2jMUW2bP05Xas1lIDy qKOsgLjBna22TkhH63ojZMM= X-Google-Smtp-Source: AA0mqf4w4IACpGZcdLnGBRDeM8RMXx7Uf4hfrbNnGy0FFbQ/cD6tbm6+xDISrvlOxjFGorgGJ/tXMg== X-Received: by 2002:a05:600c:501f:b0:3cf:7801:c780 with SMTP id n31-20020a05600c501f00b003cf7801c780mr7618653wmr.29.1668423727693; Mon, 14 Nov 2022 03:02:07 -0800 (PST) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id l26-20020a05600c2cda00b003cf774c31a0sm18790216wmc.16.2022.11.14.03.02.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Nov 2022 03:02:06 -0800 (PST) In-Reply-To: <864jv26l0g.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 14 Nov 2022 09:43:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247850 Archived-At: Juri Linkov writes: >> * when a hunk is folded, the background for the final newline of the >> hunk content (#100f10) does not "bleed" into the hunk header's >> extension, >> >> * instead, this hunk header's extension keeps the color it has when the >> hunk is unfolded, i.e. the same color as the rest of the header >> (#323232). >> >> Let me know if that clarifies things, or if I've misunderstood what you >> are asking for. > > Thanks for the clarification. One thing I still don't understand is > does magit use outline-mode? It does not; it relies on magit-section (see references a couple of messages prior), which does more or less the exact same job outline.el does: let the user navigate and un/fold a hierarchy of headings. Some recent features of outline.el have indeed been in magit-section for a long time: visibility cycling with TAB/S-TAB, bitmap fringe indicators (with fallback to outline-style ellipses e.g. on TTYs). My point with this comparison is to show that an outline-like UI with :extended backgrounds is obviously possible; in my previous messages, I tried to highlight the relevant code in magit-section that handles delimiting section headings vs content and setting the overlays. I did that mainly FTR, so that Someone=E2=84=A2 with motivation and time ca= n see if outline.el could grow a user option to support a similar way to display outlines, thus solving the problem of :extended backgrounds.