From: Michael Albinus <michael.albinus@gmx.de>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 60722@debbugs.gnu.org
Subject: bug#60722: 30.0.50; [PATCH] Using Tramp to sudo in Eshell doesn't change prompt sigil
Date: Mon, 16 Jan 2023 10:09:58 +0100 [thread overview]
Message-ID: <87zgailuah.fsf@gmx.de> (raw)
In-Reply-To: <70904df5-9acb-e6e5-db51-23889a5fea34@gmail.com> (Jim Porter's message of "Sun, 15 Jan 2023 21:38:41 -0800")
Jim Porter <jporterbugs@gmail.com> writes:
Hi Jim,
> I didn't do this part though, since it wasn't so simple. Instead, I
> made the function (now named 'file-user-uid'[1]) work like the
> function 'exec-path'. Since the regular 'user-uid' is also a function,
> I think this implementation is the most straightforward.
>
> [1] I named it this way to mimic the relationship between
> 'start-process' and 'start-file-process'. (But 'user-file-uid' didn't
> sound right, so 'file-user-uid' it is.)
Fine with me. I've roughly scanned the patch, it looks OK. So I guess
you shall install it; if there's something left to do we can still do it
on master.
After that, I will add the implementation for ange-ftp.el and some tests
in tramp-tests.el, and I'll check whether the implementation of
tramp-archive-handle-file-user-uid is OK.
> diff --git a/doc/lispref/os.texi b/doc/lispref/os.texi
>
> +@defun file-user-uid
> +This function returns the connection-local for the user's effective
"connection-local value"
> diff --git a/etc/NEWS b/etc/NEWS
>
> +** New function 'file-user-uid'.
> +This function is like 'user-uid', but is aware of file name handlers,
> +so it will return the remote UID for remote files.
Perhaps you could also mention -1 as the "don't know" result.
Best regards, Michael.
next prev parent reply other threads:[~2023-01-16 9:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 23:50 bug#60722: 30.0.50; [PATCH] Using Tramp to sudo in Eshell doesn't change prompt sigil Jim Porter
2023-01-11 2:12 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-11 9:35 ` Michael Albinus
2023-01-11 9:33 ` Michael Albinus
2023-01-11 13:59 ` Michael Albinus
2023-01-14 21:59 ` Jim Porter
2023-01-14 22:10 ` Jim Porter
2023-01-15 9:23 ` Michael Albinus
2023-01-16 5:38 ` Jim Porter
2023-01-16 9:09 ` Michael Albinus [this message]
2023-01-17 1:21 ` Jim Porter
2023-01-17 9:12 ` Michael Albinus
2023-01-18 1:04 ` Jim Porter
2023-01-17 15:03 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgailuah.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=60722@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).