From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Danny Freeman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60127: treesit-end-of-defun: possible bug with clojure grammar Date: Tue, 17 Jan 2023 10:49:45 -0500 Message-ID: <87zgahgnj3.fsf@dfreeman.email> References: <83zgah2vz8.fsf@gnu.org> Reply-To: Danny Freeman Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3959"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , 60127@debbugs.gnu.org, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 17 17:00:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHoNt-0000sp-SX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Jan 2023 17:00:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHoNZ-0001iS-AP; Tue, 17 Jan 2023 11:00:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHoNX-0001iC-UB for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2023 11:00:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHoNW-0001aK-Uf for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2023 11:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pHoNW-0006H0-Pe for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2023 11:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Danny Freeman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Jan 2023 16:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60127 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: pending Original-Received: via spool by 60127-submit@debbugs.gnu.org id=B60127.167397117924058 (code B ref 60127); Tue, 17 Jan 2023 16:00:02 +0000 Original-Received: (at 60127) by debbugs.gnu.org; 17 Jan 2023 15:59:39 +0000 Original-Received: from localhost ([127.0.0.1]:38044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHoN9-0006Fx-C8 for submit@debbugs.gnu.org; Tue, 17 Jan 2023 10:59:39 -0500 Original-Received: from out-57.mta0.migadu.com ([91.218.175.57]:50748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHoN7-0006Fp-5y for 60127@debbugs.gnu.org; Tue, 17 Jan 2023 10:59:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dfreeman.email; s=key1; t=1673971173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y3uHXltXHSLFknm3nsGgAmn7gA3cwoxuqPaGML61ggU=; b=iedVc/9RGHfdFBk6iLfCHGFse7Stcfq0FoO3NxL++PGnNKS3Pu+aSikXzazRHFYWMODwL6 VXSegwX5dcdbj5FEcBQFp+i1xyS/BpEhhie2h1ZXYXY8dJLJPiaKAE/YW60vbHQM4HCEkd UVhKRjvqpJGb8R+G0wAAcQmhYqdhYSw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <83zgah2vz8.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253562 Archived-At: Eli Zaretskii writes: >> From: Yuan Fu >> Date: Tue, 17 Jan 2023 01:30:22 -0800 >> Cc: 60127@debbugs.gnu.org, >> Danny Freeman , >> Eli Zaretskii >>=20 >>=20 >> > I=E2=80=99d rather not use treesit_search_dfs, as it does much more wo= rk than >> > the current code. You know what, I can write a custom >> > ts_node_first_child_for_byte and use that in Emacs, I=E2=80=99ve alrea= dy done >> > that for ts_node_parent anyway. >>=20 >> I did that. I tested with the Clojure example and it works fine now. >>=20 >> Eli, we don=E2=80=99t use ts_node_first_child_for_pos for now until tree= -sitter >> fix that function, should I removed the boilerplate for it or should I >> leave it as-is? I saw you removed ts_node_parent when I did a similar >> fix. > > It should be either removed or #ifdef'ed away, because otherwise GCC > complains in the MS-Windows build about unused macro. Thanks for tackling this problem on the Emacs end Yuan. I tested it out with clojure-ts-mode and it seems to have addressed my problems. I also took the liberty of linking to your commit in the tree-sitter github issue in case the maintainers want to take a look at it. --=20 Danny Freeman