From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#60893: 30.0.50; ad-deactive has broken interactive TAB completion Date: Wed, 18 Jan 2023 12:34:51 +0100 Message-ID: <87zgaghy90.fsf@web.de> References: <87lem09ajl.fsf@secretsauce.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="581"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60893@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 18 12:36:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pI6jy-000AUo-R6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Jan 2023 12:36:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pI6jc-0007v5-IC; Wed, 18 Jan 2023 06:36:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pI6ja-0007gg-No for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2023 06:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pI6ja-0008Ex-Dd for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2023 06:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pI6ja-00036H-9Q for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2023 06:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Jan 2023 11:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60893 X-GNU-PR-Package: emacs Original-Received: via spool by 60893-submit@debbugs.gnu.org id=B60893.167404170611840 (code B ref 60893); Wed, 18 Jan 2023 11:36:02 +0000 Original-Received: (at 60893) by debbugs.gnu.org; 18 Jan 2023 11:35:06 +0000 Original-Received: from localhost ([127.0.0.1]:39590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI6if-00034u-Jl for submit@debbugs.gnu.org; Wed, 18 Jan 2023 06:35:05 -0500 Original-Received: from mout.web.de ([212.227.15.14]:52015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI6id-00034L-Sz for 60893@debbugs.gnu.org; Wed, 18 Jan 2023 06:35:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1674041694; bh=uOzcY9E9snReRGluB7lP9Qy34fiG6JUdBEDJt917X4E=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Uz5G1LrEJ8bmRAK9IPUZuMJ+gRnveEfklW0VWLca87DKh6OPA41L8Eah2zfVMvx8a dFe/N0oDthcLxvUKhdnWDm9joZO+DYtB4Rqzk7L8+1T6aJk1OTM60t45tzSN+YDjHu aAPxWBCUlsAaDPoqYgdz0PRwKJ4kvZF3Fqmev6RVJA5UoXnQ+6HzjcbclkTl0pXJdH 92LGO0vKrdqBCPBZqmq2wEq94bOPp2B7nwX4RMRO5PO7UC27hDS+Rm6lS3UMGZ3Cdu cyuaYgJPPNLAhQVnjnTo5k8atlLHOzQ8x0ezfWo18dAokZql3uMFN2/n//G8uoIXs0 7eSpRDAZK4BuA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MHVen-1pV31D220v-00DNJ5; Wed, 18 Jan 2023 12:34:54 +0100 In-Reply-To: <87lem09ajl.fsf@secretsauce.net> (Dima Kogan's message of "Tue, 17 Jan 2023 12:21:50 -0800") X-Provags-ID: V03:K1:SJq0+Z+UFvBV1Vtuhgn5AeQo3FvT/KGdiJjljJ6bUtoD5M0dbzs LO2LlMCkpZCOWaTjwZepPt7aYV18Itj22X4tRRT8/cGPJgWT3DYP3PwKuWCchbAcQrz8dUp tdDU3mLwQJa0vqW1zNe8A57zQnAV0al9TyLX0hwT5FI10Z94cflKokavSatGgwC9O/6A92h MrdWZ6A6N6tZFyhw9nHOQ== UI-OutboundReport: notjunk:1;M01:P0:qu/L2g8PZA8=;4hNzRgZYRhIx722srtprbqV+G/a fqoyfbvud1QWJgbnznTpIFu9NpvS3dAd26wN2re4GZtOVnyD75uyvitNRHwcA14+VBkqJwVtV IYovcypZbd4rRIng5XXik7ROEB90UOg4vSzQtcWvqb2/q4env1Wa73plEw1Z0okyk7w8H9v9G jfBEoU+KSPQ08l+XI7xxjOOaGNglyUVgM2Pmkpn3S2Gv26yCM5707WOhke4NQCZXrAXXqXuDV BL0KSHd8rQI/2NgKfKkpNPT3YxGKqGqI73bA8HjKxwaDw92dlaeVCUBhDpKA4rfEg3FiFEtH+ DPSKRK+TEkdvqPfrphHlJk1YO6TRNB7pIr7jQDVMaR+Uh5O0xrjLP/QvT8+m00Lpm7uTtqCTo mp7ULALlwUmFvvUC11q24C7KJ+aL1lxuYmzNCOWQGkBPZ+w14fPVTQ0oG03zgukrUj6X4TNiy UwtCTBGxFaecg2cRKN1tFIBhUPOoWP4I6Bvx2hMYFsrNVlhJbnX5/bOLzYlALyRxaFARSaZwD j1SuTXEhdI6/MtDcgWAuihNWvXDSMlsQl3dDmJda+as0K962EMw696uu8Whxc4JU4g3qbh4p7 G2en/Vntp/uwA+3MvdMzPLHI0Jpt1Apsn6sTJDVLIAVvPJ9tMzhjq++zrNWjjiNv5iU98UGJz IFqNT0eSpV5K0DbMOCevJRoVa+w+OBYUITm36Flsjr/zDYGEEbPGh0p+yYTiJwmkbmOQU4chn RNtCX5KnhhpY72gyHVVKne4AxkjUqBjvCadKBir1op4770BG4qdSWfv6fmChqEgPUN84c76t X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253620 Archived-At: --=-=-= Content-Type: text/plain Dima Kogan writes: > 4. M-x ad-deactivate TAB > > It should try to complete to a list of existing advised functions. > Intead it throws an error: > > completion--some: Wrong type argument: listp, "open-line" Looks like a regression introduced by 77c3c464a16 * lisp/emacs-lisp/advice.el (ad-advised-functions): Make it a plain list Stefan Monnier 2018-09-17 Does this fix your problem? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-WIP-Fix-60893.patch Content-Transfer-Encoding: quoted-printable =46rom 5e0980aac23cfa9e5417f07b8853405ad10ee228 Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Wed, 18 Jan 2023 12:32:05 +0100 Subject: [PATCH] WIP: Fix #60893 =2D-- lisp/emacs-lisp/advice.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el index 080a6d84498..56f0ae2212c 100644 =2D-- a/lisp/emacs-lisp/advice.el +++ b/lisp/emacs-lisp/advice.el @@ -1850,7 +1850,7 @@ ad-read-advised-function ad-advised-functions (if predicate (lambda (function) - (funcall predicate (intern (car function))))) + (funcall predicate (intern function)))) t))) (if (equal function "") (if (ad-is-advised default) =2D- 2.30.2 --=-=-= Content-Type: text/plain Thanks, Michael. --=-=-=--