From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60983: 29.0.60; Tree-sitter user-level control Date: Sat, 21 Jan 2023 13:40:49 +0100 Message-ID: <87zgacgiwe.fsf@thornhill.no> References: <83tu0kkuqo.fsf@gnu.org> <87tu0k3y6t.fsf@thornhill.no> <83mt6ckqts.fsf@gnu.org> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11017"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60983@debbugs.gnu.org, casouri@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 21 13:41:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJDBH-0002lq-Nl for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Jan 2023 13:41:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJDBA-0002Nn-1i; Sat, 21 Jan 2023 07:41:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJDB9-0002Ne-99 for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 07:41:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJDB8-0002tv-Ua for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 07:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJDB8-0005af-Gu for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 07:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jan 2023 12:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60983 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, casouri@gmail.com Original-Received: via spool by submit@debbugs.gnu.org id=B.167430485821472 (code B ref -1); Sat, 21 Jan 2023 12:41:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Jan 2023 12:40:58 +0000 Original-Received: from localhost ([127.0.0.1]:48267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJDB4-0005aF-0C for submit@debbugs.gnu.org; Sat, 21 Jan 2023 07:40:58 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:44148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJDB2-0005a7-08 for submit@debbugs.gnu.org; Sat, 21 Jan 2023 07:40:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJDB1-0002ND-Ah for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 07:40:55 -0500 Original-Received: from out-127.mta0.migadu.com ([2001:41d0:1004:224b::7f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJDAz-0002rj-Ab for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 07:40:55 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1674304850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XN25MGuD6aWPxEtW9EGQlZdeEsxKB8AeJ50QW5lUqUE=; b=nJn/luWcHVUbyb84KyZwknSRIh6AZRFHsO76i4tc2D7lnpErryaE/0ypvOC2nD3BjKe5iW Qy6XyapZoPT9yqEUEDh5mGc4+zkSC32rmFK/xj/VZgyeDr9BFaB+i43khfDdDAvmBX9qQw 8wLlxcXJTV4zZzEIj5VhgyliUtOvRnkoAlge57SGS+AXLuYE8lZPp1EewtoJEBn6taAwzt AC/D0IseJxeaVeWNoZ3z/pe66zdRjrGT4/hCbgNDsZ4xZHWcxawgRm711CMlceZe1HI8i7 lg4ZVesc6cgj3kYEs1UWGI9gugLt0CwyqrC8/JlGiDqP/U3Ee3d6rNFupYcWhA== In-Reply-To: <83mt6ckqts.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::7f; envelope-from=theo@thornhill.no; helo=out-127.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253858 Archived-At: Eli Zaretskii writes: >> From: Theodor Thornhill >> Cc: Yuan Fu >> Date: Sat, 21 Jan 2023 12:48:58 +0100 >> >> Eli Zaretskii writes: >> >> > . How does one change the indentation style in c-ts-mode? >> > >> > - There is a defcustom c-ts-mode-indent-style, but I don't think I >> > see any difference in indentation of new code when I change the >> > value. What am I missing? >> > >> >> (setq c-ts-mode-indent-style 'bsd) then revert-buffer fixes it for me. >> It seems you need to reload the file to enable the new style. Should I >> add a command that can be set explicitly as in c-mode? >> 'c-ts-mode-set-style'? > > I think we need both a command and a :set function for the defcustom. > Ok, I'll make a bugreport for this. >> However, going over it I see there are lots of regressions after the new >> bracket-counting code added recently, effectively making the indent >> styles pretty broken right now... > > That's a separate issue, and I'm sure it will be fixed. And adding > tests to the test suite will prevent us from breaking it too easily in > the future. > And this. >> > . What commands are affected by treesit-defun-tactic? >> >> 'treesit--navigate-thing' uses it, so 'beginning-of-defun', >> 'forward-sentence' etc uses it through 'treesit-beginning-of-thing'. > > What commands except those that call treesit--navigate-thing call > beginning-of-defun and treesit-beginning-of-thing? I'll defer to Yuan for this :) Theo